Eli Zaretskii writes: >> From: Wilhelm Kirschbaum >> Cc: 61996@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no >> Date: Sun, 12 Mar 2023 11:54:33 +0200 >> >> Eli Zaretskii writes: >> >> > In elixir-ts--call-parent-start: >> > progmodes/elixir-ts-mode.el:459:38: Warning: Unused lexical >> > argument `node' >> > progmodes/elixir-ts-mode.el:463:15: Warning: reference to >> > free >> > variable `parent' >> > >> > In elixir-ts--forward-sexp: >> > progmodes/elixir-ts-mode.el:482:8: Warning: reference to >> > free >> > variable `heex-ts--sexp-regexp' >> >> Ah, not sure how I missed them. The new patches have further >> tweaks and >> should resolve the above issue. > > Thanks, but the first of the two patches lacks the commit log > message. And since you said there are further tweaks, I wasn't > sure > the one from the previous version was still accurate. Attached are the updated patches with added test cases and indentation rule enhancements. I still see this warning on a non-treesitter build: In elixir-ts--forward-sexp: elixir-ts-mode.el:490:8: Warning: reference to free variable ‘heex-ts--sexp-regexp’ But not sure why and how to fix it, because defcons heex-ts--sexp-regexp and (require 'heex-ts-mode) is called. Random concern: how will backwards compatibility work when the grammars get updated? It might just be better to add both modes in one patch if more changes are required perhaps?