From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: master a30781399b3: * subr-x (eval-command-interactive-spec): New function. Date: Mon, 05 Jun 2023 10:24:16 +0000 Message-ID: <87a5xeb41b.fsf@posteo.net> References: <168595059426.2523.2109338263713299231@vcs2.savannah.gnu.org> <20230605073635.19060C00613@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20756"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Sean Whitton To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 05 12:25:28 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q67Oy-00059q-IL for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Jun 2023 12:25:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q67Nx-0005kR-5U; Mon, 05 Jun 2023 06:24:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q67Nu-0005kA-Bl for emacs-devel@gnu.org; Mon, 05 Jun 2023 06:24:22 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q67Ns-0003sx-DU for emacs-devel@gnu.org; Mon, 05 Jun 2023 06:24:22 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 7E5A0240104 for ; Mon, 5 Jun 2023 12:24:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1685960658; bh=iMcrWV2ppF/59Db3qlVQ/QnEWQrPMe592Kmp973+jM0=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=UogWFYsFoNQZjdoHvb8/ZBiINF5vUIg2UsxbR28iI15Ajcpe7Og8kw6EaVEtzoAbt RQpJsW+BnsKFyEc7Dlf0m/aclimRIrBjb1A+VoQk0uB2NltAWoNxHgZdU43VEMAnX3 Go7r+0PRZYnoC8OupwfzJSL6cxy2U2I4bcTwWfKB/V9hv9jPLDrkWuFCYwctyR8NkR 23bRk7+X/91tzcLFcYTpnCxkK65PKBd7tmH/bFHmoxcRp7rfZnFu5vU/omxZKj6DQz 9JglPGZdBaD9DCRJAd66j4NQK3urhuvLRNuzBjlwOEjH9lNta3Hfr9HWiBwVPJCUXQ 1Uzs7tWSPA0WQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QZV8K5znhz9rxK; Mon, 5 Jun 2023 12:24:17 +0200 (CEST) In-Reply-To: <20230605073635.19060C00613@vcs2.savannah.gnu.org> (Sean Whitton's message of "Mon, 5 Jun 2023 03:36:34 -0400 (EDT)") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306643 Archived-At: Sean Whitton writes: > branch: master > commit a30781399b3ef48150b9cb13cb0aeba7086c2d9e > Author: Sean Whitton > Commit: Sean Whitton > > * subr-x (eval-command-interactive-spec): New function. > --- > etc/NEWS | 5 +++++ > lisp/emacs-lisp/nadvice.el | 2 ++ > lisp/emacs-lisp/subr-x.el | 7 +++++++ > 3 files changed, 14 insertions(+) > > diff --git a/etc/NEWS b/etc/NEWS > index 9529282f047..910472e5519 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -648,6 +648,11 @@ Since circular alias chains now cannot occur, 'function-alias-p', > 'indirect-function' and 'indirect-variable' will never signal an error. > Their 'noerror' arguments have no effect and are therefore obsolete. > > +--- > +** New function 'eval-command-interactive-spec' in the subr-x library. > +This function evaluates a command's interactive form and returns the > +resultant list. What is the motivation for this feature? > > + > > * Changes in Emacs 30.1 on Non-Free Operating Systems > > diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el > index e457387acc9..e6977f2012a 100644 > --- a/lisp/emacs-lisp/nadvice.el > +++ b/lisp/emacs-lisp/nadvice.el > @@ -165,6 +165,8 @@ DOC is a string where \"FUNCTION\" and \"OLDFUN\" are expected.") > (buffer-string)) > usage)))) > > +;; FIXME: How about renaming this to just `eval-interactive-spec'? > +;; It's not specific to the advice system. > (defun advice-eval-interactive-spec (spec) > "Evaluate the interactive spec SPEC." > (cond > diff --git a/lisp/emacs-lisp/subr-x.el b/lisp/emacs-lisp/subr-x.el > index 9e906930b92..a7d8f785508 100644 > --- a/lisp/emacs-lisp/subr-x.el > +++ b/lisp/emacs-lisp/subr-x.el > @@ -504,6 +504,13 @@ Used by `emacs-authors-mode' and `emacs-news-mode'." > (progn (forward-line -1) (point)) > (point-max))))) > > +(defun eval-command-interactive-spec (command) > + "Evaluate COMMAND's interactive form and return resultant list. > +If COMMAND has no interactive form, return nil." > + (advice-eval-interactive-spec > + (cadr (or (and (symbolp command) (get command 'interactive-form)) > + (interactive-form command))))) > + > (provide 'subr-x) > > ;;; subr-x.el ends here