From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#64046: 30.0.50; Quoting in customize choice tags Date: Sat, 24 Jun 2023 10:50:11 +0200 Message-ID: <87a5wpfdmk.fsf@gmx.net> References: <87v8frihny.fsf@gmx.net> <837cs7we2z.fsf@gnu.org> <47e13491-1654-db22-2f8b-f12195953232@gmail.com> <87o7lhrm2x.fsf@gmx.net> <87edm3tg57.fsf@gmx.net> <613827fd-46e8-b8e8-dd91-1539f007a099@gmail.com> <878rc9rfef.fsf@gmx.net> <83352h1i35.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19303"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64046-done@debbugs.gnu.org, maurooaranda@gmail.com, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 24 10:51:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qCyzQ-0004gL-9T for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Jun 2023 10:51:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCyz4-0004L0-04; Sat, 24 Jun 2023 04:51:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCyz0-0004KP-KE for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 04:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qCyz0-0006Jw-BU for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 04:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qCyyz-0006T7-PJ for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 04:51:01 -0400 Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Jun 2023 08:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 64046 X-GNU-PR-Package: emacs Mail-Followup-To: 64046@debbugs.gnu.org, stephen.berman@gmx.net, stephen.berman@gmx.net Original-Received: via spool by 64046-done@debbugs.gnu.org id=D64046.168759662724801 (code D ref 64046); Sat, 24 Jun 2023 08:51:01 +0000 Original-Received: (at 64046-done) by debbugs.gnu.org; 24 Jun 2023 08:50:27 +0000 Original-Received: from localhost ([127.0.0.1]:39904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCyyR-0006Rx-Ca for submit@debbugs.gnu.org; Sat, 24 Jun 2023 04:50:27 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:40027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCyyM-0006RY-51 for 64046-done@debbugs.gnu.org; Sat, 24 Jun 2023 04:50:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1687596612; x=1688201412; i=stephen.berman@gmx.net; bh=/RHjQbJttf7ImyPAK/TWtnzDkAez/NRJsv6DF1D+ScU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=FT+pZWGtFmrVTNb8nuqDuTmLibl8wXDjSWx+dPPImzszbazcP0xcPmKvRysAMLahvSvn6je OAXdZiNzErbvK8HIXB0B/l4w3D29l+zQOd3oQWODoeiZR9ocDbbLx97wYbrdJ0sFZwRAe5Tsb TlWTpixghSL3VEDnFO6NxGKq3AQGH+akGiJaaKkV31OF+ku/ibZg6tFQP9xu7N5U1U/nyTVoW nZy718BYXcr5tgcQjWI8P11gMGzLgkTgCjW8v4NvsNQTQFXIocKFUDlfr7KotWnzkD7u6MQ6R Sk0lfVeOvy4Ts0kyOB1tG3wbBezSBLqxtus1yy86ZxW+usKVP/fA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfssd ([94.134.196.23]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MPog5-1qPzWB2zA3-00MwM6; Sat, 24 Jun 2023 10:50:12 +0200 In-Reply-To: <83352h1i35.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Jun 2023 09:37:34 +0300") X-Provags-ID: V03:K1:ceG8kHJnGPvZ5QQK8Xzbi3ny7z534oDiAcX4FeMD000WLlDpxe5 5imrmaE31J/lUbRIp5kXvLHR2rznO2B8Qj1csX8KidSzh1YRDUMcdtk2g+sw8t/3i27vmcO y5BvJ8MOAF1B8dtw9EjROa8H0nhvcSI+aWg8xLSsEtQpwgm3T0EU5+pQZcd7Og4VGymX83s NNFwtDWnHFByeVKXL5gnw== UI-OutboundReport: notjunk:1;M01:P0:UkCv1w76Xeo=;rJziX16toTT89ByK8yY8gd65mgy zsFg7hfOVO2gHOVeu1x1/GjJqELbQNwI6oqswS4IpwfFkxdFcNd9Bcntg2FEShPNJSSLPV4gq f99i1YLzRDxGxSIrLvT0eW2vtahD0r/IMEiFvC9dO9RUuXTMtbsQjmSrrFiAv8JcN485rUn/A KHDpjPe33pKz6Mn/JI1HaskMtJLdDvLu3p61RHJ3fKM2bI8WicIU4vEm4BA3lLJxLrePcy3Db RsIIAqMz5E/5w1Yq0Bv97RU/eeS85lBFnuCGjHGlCxydP/N8G/iQcBjMl9jRe69XTN5RPr/It 3YIPcZWQ8X1nNk223kmEwiCIjGDmB8qJ3RxVaxAGG3Kc/RhZq6PXUZq32FCrB76TjhW0BGQBO juQrkdjBK9FzjDt5g/j9jMRKalrjjDzMF4V8ZeYdjyhx7eo/+Bj4qM90UXtfsjicUA8lMHO/i SwvmP2AWTd/5ieNQODmjbPGDLxQ+1L2KRrm+sadvpUkeWwjcQJw8xtvoVrPwHodkqTo2hDWri Rl4FQ4n1E+BCerndXTTn7mDVMWY3z0poLvPDGEwiZdO7RIRvZB9hjIT+XrtR8rQBYnnKMRfmc Qj3052/Ud+m2Ols4HKP4mTH98nEh6bIWJiHbGmZA2179RAuOJZNDGYZgUxFkhU8v62PxQN34t cJOlGl701uTndhUBqbutY8c82OHy3fILbjr98UxkxqFfFWSw+ulSmcNb0fHCISkW5TRDRmE+J FV6zsvMjQj/OuafgM+b7W8eDVYP/HsbADjxu+HeCOeiDCVpm9FHtYs8OAjVdxm7YBWxq2m6t X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263977 Archived-At: On Sat, 24 Jun 2023 09:37:34 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: 64046@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier >> >> Date: Sat, 24 Jun 2023 00:18:48 +0200 >>=20 >> On Thu, 22 Jun 2023 19:59:26 -0300 Mauro Aranda = wrote: >>=20 >> > Stephen Berman writes: >> > >> >>> Thanks for the feedback.=C2=A0 You're right, that patch is too super= ficial; >> >>> it also fails to do substitution in popup extended menus like the one >> >>> produced by clicking the "State" button, with the result that in the >> >>> item "Revert This Session's Customization" the apostrophe is not >> >>> displayed in the "curve" style.=C2=A0 So I revised the patch, attach= ed below, >> >>> to iterate over the elements of each item in ITEMS, and it now appea= rs >> >>> to handle substitution with the "State" button display correctly, bo= th >> >>> as popup menu and as text menu buffer.=C2=A0 The latter is the resul= t of >> >>> applying widget--simplify-menu, if I debugged correctly, so I think = this >> >>> answers your concerns (though the text menu buffer already shows the >> >>> substitution independently of my patch, due to commit bd3b426ebb).= =C2=A0 Or >> >>> have I misunderstood your concerns about widget--simplify-menu?=C2= =A0 If so, >> >>> can you give an example where the new patch fails? >> >> >> >> Just pinging in case this fell under the radar.=C2=A0 If there's no r= esponse, >> >> what's the next step forward? >> >> >> >> Steve Berman >> > >> > It did, thanks for the ping. >> > >> > Since there's no problem with widget--simplify-menu, the patch looks >> > good to me. >>=20 >> Thanks. So Eli, should this go into master, since it's not a >> regression, or is it ok to install this to the release branch? It does >> seem pretty safe, since it's only applying substitute-command-keys in a >> few more places in widget-choose. > > Pleased install on master. The problem is very minor and we have > lived with it for many years, so it can wait a bit more. Done with commit 6d55d93379f, closing the bug. Thanks. Steve Berman