From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#65735: [PATCH] key-translate should use the 1st key of a key sequence Date: Thu, 07 Sep 2023 13:57:14 +0200 Message-ID: <87a5tyfb6t.fsf@gmail.com> References: <87edjafmfu.fsf@gmail.com> <83zg1yz9e7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24784"; mail-complaints-to="usenet@ciao.gmane.io" Cc: one.last.kiss@outlook.com, 65735@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 07 13:58:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeDeG-0006CO-TJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Sep 2023 13:58:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeDe6-0003iK-S3; Thu, 07 Sep 2023 07:58:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeDe5-0003iB-2u for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 07:58:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeDe4-0000ug-Qb for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 07:58:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeDe6-00022b-2B for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 07:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Sep 2023 11:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65735 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65735-submit@debbugs.gnu.org id=B65735.16940878507805 (code B ref 65735); Thu, 07 Sep 2023 11:58:02 +0000 Original-Received: (at 65735) by debbugs.gnu.org; 7 Sep 2023 11:57:30 +0000 Original-Received: from localhost ([127.0.0.1]:38751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeDdZ-00021p-Qo for submit@debbugs.gnu.org; Thu, 07 Sep 2023 07:57:30 -0400 Original-Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:48475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeDdU-00021Z-1b for 65735@debbugs.gnu.org; Thu, 07 Sep 2023 07:57:28 -0400 Original-Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-402d499580dso9946355e9.1 for <65735@debbugs.gnu.org>; Thu, 07 Sep 2023 04:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694087836; x=1694692636; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=rmsf+MSvxD8+5zUjmGvTNfNPGcNK6tdAQeLjJXlaOpw=; b=RZx3lBBwyKThz3SvrWC//sO+DdPoalOzZzAD9UmOopsHhUqec13vf2+9P9OWRmBiT9 1lXEAhdoR/L60/IlMbM8L5R9Vq89GuRGHuvmtAeUIa8RNgOTV4XW4FF5JU6z2t5/kTp/ BkkUyMkG7vEpL5UoIEQFiLa+HLh9ZiG29xo9hFtrn2GIqlxFd81kUuVRMG1Bjdzu8htQ QLp4seZBEIHBuTZ+hhxTCnm0JyBs1aaVALgNsyiYKpohKu4ZgCKsLjhsQ9y/LwgI3jdq pk8zZvk5JnQAGOOTr4EoMGWc71Jha6f/XZFfKwtMc6pi63zWo46EM590wrpydp5J9mwp 0bLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694087836; x=1694692636; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rmsf+MSvxD8+5zUjmGvTNfNPGcNK6tdAQeLjJXlaOpw=; b=Tsd4Otq2Ll6SMyECsDWEnD9JEKRn6Y8yjJmUlKMlgoaarVEzmAPGwYBvruTORmehRs /WfbFtF1PX6Zxem3zd9Dto8xKlY5jXMisMOLLJKtBttNauzgUlpKdITyDQcQARIGZkob zH5PAJm2pM2PsuF+GNHN4NL5y3e4PGPMuDW/Tt6/UVCLwT9akEDgzh0+sD1XUpXU8CPB peKOlW55tvU/tFamgQKR41S/koau2WR9NKUqxfs7Fz9cPN0tK9l/N7dlJkR7veDbIEUz 0/BpAc8+k6Vx7H+K23W9U0JNLIUUmskZxfNBLiRxvs3aBePetwMiq5JrcHB33YuMsJZS e39Q== X-Gm-Message-State: AOJu0YwgPP/z7Hx+Li5kphh6tS/2ECE8av2JxlkDUUtkGNCch0CiZvFG BAvDCqW7nwtsKvM4+xur5uJ2FoJpY06/VA== X-Google-Smtp-Source: AGHT+IGkNzP2Hb4ymnPxZHss47P5yPQGCl4OYsISbQJv/iQRjnuN8gY8R9zJr/umHUT/y0/SFlg6sQ== X-Received: by 2002:a05:6000:10d0:b0:31d:c3d2:42fd with SMTP id b16-20020a05600010d000b0031dc3d242fdmr4563922wrx.64.1694087835806; Thu, 07 Sep 2023 04:57:15 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:6de:8192:75e5:c4ea]) by smtp.gmail.com with ESMTPSA id r5-20020adfe685000000b003143867d2ebsm23167338wrm.63.2023.09.07.04.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Sep 2023 04:57:15 -0700 (PDT) In-Reply-To: <83zg1yz9e7.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Sep 2023 11:15:44 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269642 Archived-At: >>>>> On Thu, 07 Sep 2023 11:15:44 +0300, Eli Zaretskii said: >> Cc: 65735@debbugs.gnu.org >> From: Robert Pluim >> Date: Thu, 07 Sep 2023 09:54:13 +0200 >>=20 >> I see commits from you both with and without >> Copyright-paperwork-exempt, do you have a copyright assignment on >> file? Eli> He does, now. OK. Then I=CA=BCll push it to emacs-29, since otherwise `key-translate' is completely useless. In the interests of, uhm, eating our own dogfood, how about the following as well for master (or should I let sleeping dogs lie =F0=9F=98= =BA) diff --git i/lisp/simple.el w/lisp/simple.el index 05a3c4b93d6..da9db1685c4 100644 --- i/lisp/simple.el +++ w/lisp/simple.el @@ -10658,10 +10658,10 @@ normal-erase-is-backspace-mode (t (if enabled (progn - (keyboard-translate ?\C-h ?\C-?) - (keyboard-translate ?\C-? ?\C-d)) - (keyboard-translate ?\C-h ?\C-h) - (keyboard-translate ?\C-? ?\C-?)))) + (key-translate "C-h" "DEL") + (key-translate "DEL" "C-d")) + (key-translate "C-h" "C-h") + (key-translate "DEL" "DEL")))) =20 (if (called-interactively-p 'interactive) (message "Delete key deletes %s" diff --git i/lisp/term/bobcat.el w/lisp/term/bobcat.el index 983c8cded2f..2f611953523 100644 --- i/lisp/term/bobcat.el +++ w/lisp/term/bobcat.el @@ -3,8 +3,8 @@ (defun terminal-init-bobcat () "Terminal initialization function for bobcat." ;; HP terminals usually encourage using ^H as the rubout character - (keyboard-translate ?\177 ?\^h) - (keyboard-translate ?\^h ?\177)) + (key-translate "DEL "C-h") + (key-translate "C-h "DEL")) =20 (provide 'term/bobcat) =20 Robert --=20