From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manphiz Newsgroups: gmane.emacs.bugs Subject: bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting Date: Thu, 21 Sep 2023 08:00:55 -0700 Message-ID: <87a5tf3714.fsf@debian-hx90.lan> References: <87bke85hsb.fsf@gmail.com> <87a5tobby9.fsf@debian-hx90.lan> <871qf0atqs.fsf@debian-hx90.lan> <878r97ooxs.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31940"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65882@debbugs.gnu.org, Ryan Yeske , Stefan Kangas , Leo Liu To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 21 17:24:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjLXS-0008Av-Vy for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Sep 2023 17:24:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjLX1-0007XA-5v; Thu, 21 Sep 2023 11:23:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjLWz-0007WZ-KO for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 11:23:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjLWz-0007dh-CG for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 11:23:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjLX8-0008NK-V4 for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 11:24:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manphiz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Sep 2023 15:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65882 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65882-submit@debbugs.gnu.org id=B65882.169530984032179 (code B ref 65882); Thu, 21 Sep 2023 15:24:02 +0000 Original-Received: (at 65882) by debbugs.gnu.org; 21 Sep 2023 15:24:00 +0000 Original-Received: from localhost ([127.0.0.1]:34644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjLX3-0008Mv-UZ for submit@debbugs.gnu.org; Thu, 21 Sep 2023 11:24:00 -0400 Original-Received: from mail-oi1-x22f.google.com ([2607:f8b0:4864:20::22f]:55767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjLB4-0007lQ-MN for 65882@debbugs.gnu.org; Thu, 21 Sep 2023 11:01:17 -0400 Original-Received: by mail-oi1-x22f.google.com with SMTP id 5614622812f47-3ab7fb1172cso595704b6e.3 for <65882@debbugs.gnu.org>; Thu, 21 Sep 2023 08:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695308459; x=1695913259; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=7dpA3qFILjjhywEpTDxtxSJT5LKZNGyDMwi1sNqCfl4=; b=LM2WIPMcJivB7QfoYYa08oy+69FdnRxl+rtpzCb9sVZhYCwTwLn5cG3hpBGDRQ29RY 2cFJ0JZW8tn2oSv11jebKUz6BCvscpQ9HviqBZzmj0eJ3zR9ezMjcZ6bPZvNHldt6cVr sDQGJ6yKF7hYH9dAVO7Kkj9fb+ZCGg7VAnhXlp5QTMHMSgkQOBkVSPSglX6gntcydbob fVnesNNow8hF3CHJieDCHEHAaqE2K2SRDuPmMZ3z+IzeI0zXIp4nnkVHoEtprA/mnGRa +6YQCq4izwuUmBTXj7EQimujwOuqM7HoSatXOlQr9h2QBAW0EUPswsdRvEyz2OFMxNJ5 a32Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695308459; x=1695913259; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7dpA3qFILjjhywEpTDxtxSJT5LKZNGyDMwi1sNqCfl4=; b=cshQ+Fy7TFe3lGWLmC0pzUTIDsFd1PcuF1EuD2m4HufZ82dhFFeXq3Quct8wf8vG5k MFQXeheNiIEtV+zjPk/UTqqNoYf+H5NW5bbn1PsQ6fPQB4UwB/BpGM4Q+Wq/X3ngItir 51V2nQC/yUZfiV4alrOvngA7SKe2eAv2JdbLmKj6JgR/XGGjWv4AMM59zditphGBUF98 1L9BAsqiKmA6bGWGjAKP2LKfwls78UHSosBaAvCoJVemslyXCkKwVoR9IpKGTHTS0hVv bs8rc8v9dW1rbCIadyCDbn8FOgT0dUMuIV2HohdqIYCr/urUCGkchAo46Xlb28I1yHGr MOqA== X-Gm-Message-State: AOJu0Yz9CnajQhx0E/p4bkFcJOunEvb1nym0FKVTScRmWSkCDxqOo8EN aW2MptBX8m+j8l2Qoj4SFew= X-Google-Smtp-Source: AGHT+IFjSMIltEQ/xlo5UbxdoXDU9lY8IOcBQBvBw9XRpDY2O3yhM0by2kl22pOT8W4CTcv7IXPBnQ== X-Received: by 2002:a05:6808:1994:b0:3a9:b9eb:998e with SMTP id bj20-20020a056808199400b003a9b9eb998emr6544632oib.51.1695308458769; Thu, 21 Sep 2023 08:00:58 -0700 (PDT) Original-Received: from debian-hx90 (2603-8000-a400-0cdc-4543-1b99-0367-6d9f.res6.spectrum.com. [2603:8000:a400:cdc:4543:1b99:367:6d9f]) by smtp.gmail.com with ESMTPSA id a13-20020a63704d000000b00578f1a71a91sm1397207pgn.79.2023.09.21.08.00.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 08:00:58 -0700 (PDT) In-Reply-To: <878r97ooxs.fsf@posteo.net> (Philip Kaludercic's message of "Fri, 15 Sep 2023 07:50:23 +0000") X-Mailman-Approved-At: Thu, 21 Sep 2023 11:23:56 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271000 Archived-At: Philip Kaludercic writes: > The change makes sense, but I'll want to try it out to make sure we are > doing the right thing. Unless I write something here, ping me in a few > days. These kinds of auto-reconnect bugs can be annoying to debug in > real-life situations. > Friendly ping. > Manphiz writes: > >> Stefan Kangas writes: >> >>> severity 65882 + minor >>> thanks >>> >>> Manphiz writes: >>> >>>> I noticed that you lowered the severity of this bug from "normal" to >>>> "wishlist". AIUI rcirc provides a way to automatically join channels >>>> upon connecting to a server and currently this is not working as >>>> intended, so IMHO it should be considered a bug instead of a feature >>>> request (a wishlist). >>> >>> Thanks, so I bumped it to minor. I hope that makes more sense. >>> >> >> Thanks! >> >>>> (If you are using severity as a means to manage bug triage priority >>>> I'm OK with that.) >>> >>> My impression is that almost no one pays attention to bug severities, so >>> I wouldn't make too much of it. Bug reports that come with a patch, >>> like yours did, tend to get more visibility though. >>> >> >> Ah got it. It's my first time filing bug here so not very familiar with >> the convention. Looks like tagging patch was a good move :) > > So this patch would be applied without a copyright assignment, right? > >>>> Personally, as the patch is sufficiently trivial, I would hope it won't >>>> take too much work for a review. But I would understand if dealing with >>>> rcirc-user-authenticated is more involved than it looks like and should >>>> be handled with care. >>> >>> I've copied in the rcirc maintainers. Let's see if they have any >>> comments first. >> >> Great! Thanks again! -- Manphiz