From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66393: [PATCH] Make package-vc-install-from-checkout NAME argument optional Date: Sun, 08 Oct 2023 13:50:40 -0700 Message-ID: <87a5ssu9ck.fsf@breatheoutbreathe.in> References: <87o7haw9zj.fsf@breatheoutbreathe.in> <87o7h9ktli.fsf@posteo.net> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10195"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66393@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 08 22:52:01 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qpakq-0002PM-V4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Oct 2023 22:52:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qpakb-0004Eb-4Z; Sun, 08 Oct 2023 16:51:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpakY-0004Di-RH for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2023 16:51:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qpakY-0007S0-Ha for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2023 16:51:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qpaks-0003fZ-Lk for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2023 16:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Oct 2023 20:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66393 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66393-submit@debbugs.gnu.org id=B66393.169679828114031 (code B ref 66393); Sun, 08 Oct 2023 20:52:02 +0000 Original-Received: (at 66393) by debbugs.gnu.org; 8 Oct 2023 20:51:21 +0000 Original-Received: from localhost ([127.0.0.1]:58752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpakC-0003eF-In for submit@debbugs.gnu.org; Sun, 08 Oct 2023 16:51:20 -0400 Original-Received: from out-198.mta0.migadu.com ([91.218.175.198]:44780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpak9-0003e4-Hv for 66393@debbugs.gnu.org; Sun, 08 Oct 2023 16:51:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1696798255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mjZIe9zOMPrh60/0eEQ12IphI8gD7R1j/AwcbHcWd4s=; b=fxY+vo9WMnG1+LB4KrdE4pvTjm9ggiuDkxy6kox8bXr2Rbxwq6MImjQO6QybSz+yM+eDq/ PS0u0Xc0WCimtuM/on97kr1SO251Il32iz2pAOjXG1752gXr1BsBbuOLTF1H4OJxLm473i HM2/O6IRVSi5exoyz9ADCT9rIkQCvIE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <87o7h9ktli.fsf@posteo.net> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272108 Archived-At: Philip Kaludercic writes: > Joseph Turner writes: > >> Tags: patch >> >> The purpose of this change is to simplify the noninteractive usage of package-vc-install-from-checkout. >> >> From cfdd990c6e00decff370e5f224d60862c13be309 Mon Sep 17 00:00:00 2001 >> From: Joseph Turner >> Date: Sat, 7 Oct 2023 11:38:43 -0700 >> Subject: [PATCH] Make package-vc-install-from-checkout NAME argument optional >> >> * lisp/emacs-lisp/package-vc.el (package-vc-install-from-checkout): >> Allow nil NAME; update documentation. >> --- >> lisp/emacs-lisp/package-vc.el | 12 +++++------- >> 1 file changed, 5 insertions(+), 7 deletions(-) >> >> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el >> index c7a30736e32..e47deca6d7a 100644 >> --- a/lisp/emacs-lisp/package-vc.el >> +++ b/lisp/emacs-lisp/package-vc.el >> @@ -841,18 +841,16 @@ for the last released version of the package." >> (find-file directory))) >> >> ;;;###autoload >> -(defun package-vc-install-from-checkout (dir name) >> +(defun package-vc-install-from-checkout (dir &optional name) >> "Set up the package NAME in DIR by linking it into the ELPA directory. >> +NAME defaults to the base name of DIR. >> Interactively, prompt the user for DIR, which should be a directory >> under version control, typically one created by `package-vc-checkout'. >> If invoked interactively with a prefix argument, prompt the user >> -for the NAME of the package to set up. Otherwise infer the package >> -name from the base name of DIR." >> +for the NAME of the package to set up." >> (interactive (let ((dir (read-directory-name "Directory: "))) >> - (list dir >> - (if current-prefix-arg >> - (read-string "Package name: ") >> - (file-name-base (directory-file-name dir)))))) >> + (list dir (when current-prefix-arg > > This looks fine, I'm just going to replace the `when' with a `and', ok? Sure! >> + (read-string "Package name: "))))) >> (unless (vc-responsible-backend dir) >> (user-error "Directory %S is not under version control" dir)) >> (package-vc--archives-initialize)