Current Org-mode does not work with Emacs 27

Current Org-mode does not work with Emacs 27

[Yasushi SHOJI]

Hi all,

 It appears that Emacs 27 lacks the optional argument for
`get-buffer-create`, while `org-element-parse-secondary-string`
relies on it. This problem was introduced by the commit 37d6bde27fe2.

Additionally, `org-id-find-id-in-file` also uses `get-buffer-create`
with a second argument, but it checks the function and has a condition
to call it with or without the argument.

Given that `org-compat.el` already contains compatibility functions
for different Emacs versions, should we create one for
`get-buffer-create` to address this issue? Since `org-compat.el`
provides compatibility layers for Emacs 26.1 and later, it's
reasonable to assume that Org mode still supports Emacs 27?

Thanks,
-- 
           yashi

[BUG] CI jobs do not appear to be running (was: Current Org-mode does not work with Emacs 27)

[Ihor Radchenko]

Yasushi SHOJI <yasushi.shoji@gmail.com> writes:

>  It appears that Emacs 27 lacks the optional argument for
> `get-buffer-create`, while `org-element-parse-secondary-string`
> relies on it. This problem was introduced by the commit 37d6bde27fe2.

This was not caught by our CI tests for some reason, despite
make test EMACS=emacs-27 failing locally.
And the last message in https://lists.sr.ht/~bzg/org-build-failures is a
month ago.

Bastien, may you please check if there is anything wrong with the script
running tests on sr.ht?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] CI jobs do not appear to be running

[Bastien Guerry]

Ihor Radchenko <yantar92@posteo.net> writes:

> Yasushi SHOJI <yasushi.shoji@gmail.com> writes:
>
>>  It appears that Emacs 27 lacks the optional argument for
>> `get-buffer-create`, while `org-element-parse-secondary-string`
>> relies on it. This problem was introduced by the commit 37d6bde27fe2.
>
> This was not caught by our CI tests for some reason, despite
> make test EMACS=emacs-27 failing locally.
> And the last message in https://lists.sr.ht/~bzg/org-build-failures is a
> month ago.

There was a problem with the oauth token not being able to interact
with the (legacy) builds.sr.ht API.  I've updated the script so that
it now uses the hut utility (see https://git.sr.ht/~emersion/hut) 
and tests are running again.

-- 
 Bastien Guerry

Re: [BUG] CI jobs do not appear to be running

[Ihor Radchenko]

Bastien Guerry <bzg@gnu.org> writes:

> There was a problem with the oauth token not being able to interact
> with the (legacy) builds.sr.ht API.  I've updated the script so that
> it now uses the hut utility (see https://git.sr.ht/~emersion/hut) 
> and tests are running again.

Thanks!
May you also check if new commits in Org repo still trigger the check?
https://lists.sr.ht/~bzg/org-build-failures ran the tests right after
<https://git.sr.ht/~bzg/org-mode-tests/commit/6a6d21723d7b60020a711382cdb40a3c3bbd9112>,
but my recent Org commits did not trigger anything.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] CI jobs do not appear to be running

[Bastien Guerry]

Hi Ihor,

Ihor Radchenko <yantar92@posteo.net> writes:

> May you also check if new commits in Org repo still trigger the check?

New commits in Org repo don't trigger the checks directly.

Instead, there is a cron job running every three hours and running the
checks iff there are new commits.

> https://lists.sr.ht/~bzg/org-build-failures ran the tests right after
> <https://git.sr.ht/~bzg/org-mode-tests/commit/6a6d21723d7b60020a711382cdb40a3c3bbd9112>,
> but my recent Org commits did not trigger anything.

Perhaps your email was sent less than three hours after the last
checks (I didn't check).

Can you check again after the next commits?  The cron job on the
machine is configured correctly and should run.  I'll see what's 
wrong if it does not run.

Thanks!

-- 
 Bastien

Re: [BUG] CI jobs do not appear to be running

[Ihor Radchenko]

Bastien Guerry <bzg@gnu.org> writes:

>> https://lists.sr.ht/~bzg/org-build-failures ran the tests right after
>> <https://git.sr.ht/~bzg/org-mode-tests/commit/6a6d21723d7b60020a711382cdb40a3c3bbd9112>,
>> but my recent Org commits did not trigger anything.
>
> Perhaps your email was sent less than three hours after the last
> checks (I didn't check).
>
> Can you check again after the next commits?  The cron job on the
> machine is configured correctly and should run.  I'll see what's 
> wrong if it does not run.

Still nothing, even though I did not address some recent
failures, like "FAILED ob-octave/session-multiline".

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] CI jobs do not appear to be running

[Bastien Guerry]

Ihor Radchenko <yantar92@posteo.net> writes:

> Still nothing, even though I did not address some recent
> failures, like "FAILED ob-octave/session-multiline".

I've pushed a fix, it should be okay now.

I've also updated the script which mirrors the main Org repository to
GitHub and Sourcehut, things are kept in sync every 3 hours.

-- 
 Bastien Guerry

Re: [BUG] CI jobs do not appear to be running

[Ihor Radchenko]

Bastien Guerry <bzg@gnu.org> writes:

> Ihor Radchenko <yantar92@posteo.net> writes:
>
>> Still nothing, even though I did not address some recent
>> failures, like "FAILED ob-octave/session-multiline".
>
> I've pushed a fix, it should be okay now.
>
> I've also updated the script which mirrors the main Org repository to
> GitHub and Sourcehut, things are kept in sync every 3 hours.

It does not look like there is any improvement.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] CI jobs do not appear to be running

[Bastien Guerry]

Ihor Radchenko <yantar92@posteo.net> writes:

> It does not look like there is any improvement.

Yes, something is wrong with cron. I'll have a look this week-end,
I don't have a stable connection right now.

-- 
 Bastien Guerry

Re: [BUG] CI jobs do not appear to be running

[Bastien Guerry]

Ihor Radchenko <yantar92@posteo.net> writes:

>> I've also updated the script which mirrors the main Org repository to
>> GitHub and Sourcehut, things are kept in sync every 3 hours.
>
> It does not look like there is any improvement.

Both cron jobs are now fixed, one that sync Org's repos every six
hours (instead of three) and one that checks every three hours for
changes in Org's repo and runs tests if needed.

I'll keep an eye on these scripts over the week-end, let me know
if something does not work as expected.

-- 
 Bastien Guerry

Re: Current Org-mode does not work with Emacs 27

[Ihor Radchenko]

Yasushi SHOJI <yasushi.shoji@gmail.com> writes:

>  It appears that Emacs 27 lacks the optional argument for
> `get-buffer-create`, while `org-element-parse-secondary-string`
> relies on it. This problem was introduced by the commit 37d6bde27fe2.

Thanks for reporting!
Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=73485aa06

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>