bug#67209: 29.1; ERC 5.5.0.29.1: /squery doesn't work in server buffer.

bug#67209: 29.1; ERC 5.5.0.29.1: /squery doesn't work in server buffer.

[osmkarp]

In ERC server buffer when writing:
/squery Alis LIST #linux*

it gives:
---
Incorrect arguments. Usage:
/SQUERY arg1
Send a Service Query to the service given as the first word in LINE.

The rest of LINE is the message to send.
---

Next command works well and do what we wanted.
/quote SQUERY Alis :LIST #linux*



In GNU Emacs 29.1 (build 2, x86_64-pc-linux-gnu) of 2023-11-14 built on
 pm
System Description: Debian GNU/Linux trixie/sid

Configured using:
 'configure --prefix=/home/me/root/usr --without-xaw3d --without-xpm
 --without-tiff --without-lcms2 --without-x --with-native-compilation'

Configured features:
GMP GNUTLS LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER SECCOMP
SOUND THREADS TREE_SITTER ZLIB

Important settings:
  value of $LANG: fi_FI.UTF-8
  locale-coding-system: utf-8-unix

Major mode: ERC

Minor modes in effect:
  shell-dirtrack-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-ring-mode: t
  erc-netsplit-mode: t
  erc-menu-mode: t
  erc-match-mode: t
  erc-list-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-dcc-mode: t
  erc-pcomplete-mode: t
  erc-autojoin-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  erc-networks-mode: t
  server-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: linux
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/me/.emacs.d/elpa/jsonrpc-1.0.17/jsonrpc hides /home/me/root/usr/share/emacs/29.1/lisp/jsonrpc
/home/me/.emacs.d/elpa/eglot-1.14/eglot hides /home/me/root/usr/share/emacs/29.1/lisp/progmodes/eglot
/home/me/.emacs.d/elpa/eldoc-1.14.0/eldoc hides /home/me/root/usr/share/emacs/29.1/lisp/emacs-lisp/eldoc

Features:
(shadow sort mail-extr emacsbug message rfc822 mml mml-sec epa derived
epg rfc6068 epg-config mm-decode mm-bodies mm-encode mailabbrev
gmm-utils mailheader sendmail timezone parse-time shell dired-aux alis
cl-print debug backtrace disp-table misearch multi-isearch find-func
shortdoc erc-button erc-ibuffer ibuf-ext ibuffer ibuffer-loaddefs
erc-log erc-notify erc-page erc-services erc-sound erc-speedbar speedbar
ezimage dframe erc-xdcc help-fns radix-tree mule-util erc-track erc-ring
erc-netsplit erc-menu erc-match erc-list erc-fill erc-stamp erc-dcc
erc-pcomplete pcomplete comint ansi-osc ansi-color ring erc-join
erc-goodies erc pp erc-backend erc-networks erc-common erc-compat
erc-loaddefs yank-media mhtml-mode css-mode smie color js c-ts-common
treesit imenu cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles
cc-align cc-engine cc-vars cc-defs sgml-mode facemenu newst-treeview
tree-widget newst-reader newst-backend iso8601 jka-compr textsec
uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check
gnutls network-stream url-http mail-parse rfc2231 rfc2047 rfc2045
ietf-drums url-gw nsm url-cache url-auth format-spec eww xdg url-queue
thingatpt shr pixel-fill kinsoku url-file image svg xml dom puny mm-url
gnus nnheader gnus-util text-property-search time-date mail-utils range
wid-edit mm-util mail-prsvr term/linux comp regexp-opt comp-cstr
warnings icons rx cl-extra help-mode server dired-x dired dnd
dired-loaddefs info tool-bar package browse-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x
map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc
iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads inotify multi-tty
make-network-process native-compile emacs)

Memory information:
((conses 16 605038 75080)
 (symbols 48 21049 0)
 (strings 32 117414 8570)
 (string-bytes 1 5719641)
 (vectors 16 71574)
 (vector-slots 8 1868959 48353)
 (floats 8 433 552)
 (intervals 56 10820 1348)
 (buffers 984 62))

bug#67209: 29.1; ERC 5.5.0.29.1: /squery doesn't work in server buffer.

[J.P.]

Hi,

osmkarp@gmail.com writes:

> In ERC server buffer when writing:
> /squery Alis LIST #linux*
>
> it gives:
> ---
> Incorrect arguments. Usage:
> /SQUERY arg1
> Send a Service Query to the service given as the first word in LINE.
>
> The rest of LINE is the message to send.
> ---
>
> Next command works well and do what we wanted.
> /quote SQUERY Alis :LIST #linux*

Thanks a lot for reporting this. Myself or someone else will look into
it shortly, hopefully in time for ERC 5.6, which is just around the
corner.

Cheers,
J.P.

P.S. Some additional context for the record [1].

[1] https://lists.gnu.org/archive/html/emacs-erc/2022-03/msg00004.html

bug#67209: 29.1; ERC 5.5.0.29.1: /squery doesn't work in server buffer.

[J.P.]

osmkarp@gmail.com writes:

> Patch for bug#67209
>
> 3714a3715,3717
> > (defalias 'erc-cmd-S #'erc-cmd-SQUERY)
> > (put 'erc-cmd-SQUERY 'do-not-parse-args t)

Thanks. In the future, it'd be preferable if you could follow the
procedure described in CONTRIBUTE [1] for preparing patches so we can
try them out, review them, and install them with relative ease. Also, as
mentioned in #erc, I've merged this patch's bug with the original report
(bug#67209), since we don't really differentiate between patches and
issues on this tracker. So, if you're up for it, please try re-exporting
your patch in the recommended fashion and attaching it in a reply-all to
this email. Thanks again!


[1] https://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE

bug#67209: [PATCH] /squery doesn't work in server buffer

[Osmo Karppinen]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

Tags: patch

Hello,

Here is patch for /squery bug descriped earlier posts. Setting
erc-cmd-SQUERY function property do-not-parse-args to true will
fix that bug.

Repository revision: c710bf48408aece9865eb07081ca93d905e3983d
Repository branch: master
System Description: Debian


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-erc-cmd-SQUERY-bug-by-setting-property-do-not-pa.patch --]
[-- Type: text/x-diff, Size: 770 bytes --]

From c710bf48408aece9865eb07081ca93d905e3983d Mon Sep 17 00:00:00 2001
From: Osmo Karppinen <osmkarp@gmail.com>
Date: Fri, 17 Nov 2023 12:31:50 +0200
Subject: [PATCH] Fix erc-cmd-SQUERY bug by setting property do-not-parse-args
 to true.

---
 lisp/erc/erc.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index edcfcf085e6..ef6d3e483d3 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -4592,6 +4592,8 @@ The rest of LINE is the message to send."
 The rest of LINE is the message to send."
   (erc-message "SQUERY" line))
 
+(put 'erc-cmd-SQUERY 'do-not-parse-args t)
+
 (defun erc-cmd-NICK (nick)
   "Change current nickname to NICK."
   (erc-log (format "cmd: NICK: %s (erc-bad-nick: %S)" nick erc-bad-nick))
-- 
2.42.0

bug#67209: [PATCH] /squery doesn't work in server buffer

[J.P.]

Osmo Karppinen <osmkarp@gmail.com> writes:

> Tags: patch
>
> Hello,
>
> Here is patch for /squery bug descriped earlier posts. Setting
> erc-cmd-SQUERY function property do-not-parse-args to true will
> fix that bug.
>
> Repository revision: c710bf48408aece9865eb07081ca93d905e3983d
> Repository branch: master
> System Description: Debian

This has been installed on master as

  64174ae148d * Fix command-line parsing for erc-cmd-SQUERY
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=64174ae1

Thanks and closing.