From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/ebdb f7b50402cf: Final round of compiler quieting Date: Fri, 15 Dec 2023 11:46:26 -0800 Message-ID: <87a5qb5jvx.fsf@ericabrahamsen.net> References: <169810882764.9789.14002053467217676494@vcs2.savannah.gnu.org> <20231024005348.35660C09BE2@vcs2.savannah.gnu.org> <87r0jogti2.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24049"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 15 20:47:33 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEE9k-00063v-Tf for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Dec 2023 20:47:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEE8r-0003gZ-6v; Fri, 15 Dec 2023 14:46:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEE8k-0003cz-Qj for emacs-devel@gnu.org; Fri, 15 Dec 2023 14:46:30 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEE8j-0004eZ-8Q for emacs-devel@gnu.org; Fri, 15 Dec 2023 14:46:30 -0500 Original-Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 49934FA49A; Fri, 15 Dec 2023 19:46:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1702669587; bh=PE2huYEGfTzJZUnw1FeoMTNW33CHY7EIBcVyzDFCOtc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ssA/Bi+Wcf7XxDwxTrFXiJrP9y918SO2GPV/C3KD4cYGfMyiC0o0rJYmU0SCwy4V0 e8aNJOcwB48sEiwpudbYM8UKollJIaYXGUGBeq1PW0A7LyhywjJuqCgKZR+xrMGijJ bmNpx+UDw51HAC8sS6eD+pPKMxfS7bPC0+1BSQEs= In-Reply-To: (Stefan Monnier's message of "Thu, 14 Dec 2023 21:36:54 -0500") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313861 Archived-At: Stefan Monnier writes: >> I'm finally getting to push this code! I decided that ebdb-add-to-list >> simply wasn't necessary -- there were hardly any cases where the element >> test was meaningful, and otherwise this could just be `ebdb-pushnew' >> that delegates to `cl-pushnew' with a :test. I'll keep >> ebdb-remove-from-list, with your re-definition, but couldn't guess how >> to rename it appropriately. `pop' isn't right, I suppose it could be >> `ebdb-delete-from-list' since it uses delete under the hood -- otherwise >> I don't see a clear convention in place, did you have something specific >> in mind? > > No, sorry, nothing specific in mind, the choice is all yours, Understood!