From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Sean Devlin <spd@toadstyle.org>
Cc: 68805@debbugs.gnu.org
Subject: bug#68805: 29.2; Tramp: out-of-band copy-file fails when tramp-copy-keep-date is nil
Date: Thu, 01 Feb 2024 14:49:19 +0100 [thread overview]
Message-ID: <87a5okguqo.fsf@gmx.de> (raw)
In-Reply-To: <87frycgvo7.fsf@gmx.de> (Michael Albinus via's message of "Thu, 01 Feb 2024 14:29:12 +0100")
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:
Hi Sean,
> Thanks for the report and the analysis. It is correct. Could you please
> check, whether this patch fixes it:
Oops, that's too lax. Pls try the following instead:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 638 bytes --]
diff --git a/lisp/tramp-sh.el b/lisp/tramp-sh.el
index 1301cd63..44c0bdc7 100644
--- a/lisp/tramp-sh.el
+++ b/lisp/tramp-sh.el
@@ -2521,6 +2521,12 @@ The method used must be an out-of-band method."
;; cached password).
(tramp-cleanup-connection v 'keep-debug 'keep-password))))
+ ;; The cached file properties might be wrong if NEWNAME didn't
+ ;; exist. Flush them.
+ (when v2
+ (with-parsed-tramp-file-name newname v2
+ (tramp-flush-file-properties v2 v2-localname)))
+
;; Handle KEEP-DATE argument.
(when (and keep-date (not copy-keep-date))
(tramp-compat-set-file-times
[-- Attachment #3: Type: text/plain, Size: 24 bytes --]
Best regards, Michael.
next prev parent reply other threads:[~2024-02-01 13:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 22:26 bug#68805: 29.2; Tramp: out-of-band copy-file fails when tramp-copy-keep-date is nil Sean Devlin
2024-02-01 13:29 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-01 13:49 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-02-01 15:34 ` Sean Devlin
2024-02-01 16:32 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-01 16:52 ` Sean Devlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5okguqo.fsf@gmx.de \
--to=bug-gnu-emacs@gnu.org \
--cc=68805@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=spd@toadstyle.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.