From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66114: [PATCH] Fix interactive prompt for selecting checkout directory Date: Thu, 15 Feb 2024 10:27:20 -0700 Message-ID: <87a5o1hc3b.fsf@breatheoutbreathe.in> References: <87h6npfhoa.fsf@breatheoutbreathe.in> <87h6nmvcru.fsf@posteo.net> <87bkdsp2ns.fsf@breatheoutbreathe.in> <87lecvbpt4.fsf@posteo.net> <87v8bzi7iz.fsf@breatheoutbreathe.in> <877cjgvpjl.fsf@breatheoutbreathe.in> <87eddfgf60.fsf@posteo.net> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37442"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66114-done@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 15 18:28:58 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rafXd-0009TH-MF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Feb 2024 18:28:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rafXR-0004lM-8F; Thu, 15 Feb 2024 12:28:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rafXP-0004ke-AU for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 12:28:43 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rafXP-0000T4-2I for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 12:28:43 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rafXh-0007Gb-I5 for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 12:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Feb 2024 17:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66114 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66114-done@debbugs.gnu.org id=D66114.170801809027869 (code D ref 66114); Thu, 15 Feb 2024 17:29:01 +0000 Original-Received: (at 66114-done) by debbugs.gnu.org; 15 Feb 2024 17:28:10 +0000 Original-Received: from localhost ([127.0.0.1]:56903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rafWr-0007FQ-Mv for submit@debbugs.gnu.org; Thu, 15 Feb 2024 12:28:10 -0500 Original-Received: from out-173.mta0.migadu.com ([91.218.175.173]:38387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rafWo-0007Eu-AW for 66114-done@debbugs.gnu.org; Thu, 15 Feb 2024 12:28:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1708018060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uDV9sANqjIlovmhMgAxFvN1re/oeJyzGat3yhSBthM4=; b=MVnTHZb3t5/qqhzjKivr+heIUpw7JjtVkVj+DUwQdTo9UHirBTN1XrVg4wwudoDbFMn+8F FN+k9Ecss83tJia/Qj7sHu/bjQRheQWct25ADtl8Xfu4NuV6sU5OFCpJMvPp0G3gexuba6 SYenQ0t9VOp7R47zj5e8HEjG6DoePuM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <87eddfgf60.fsf@posteo.net> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280068 Archived-At: Philip Kaludercic writes: > Joseph Turner writes: > >> Joseph Turner writes: >> >>> Philip Kaludercic writes: >>> >>>> Joseph Turner writes: >>>> >>>>> However, the behavior of >>>>> read-file-name is unspecified when a MUSTMATCH function returns nil: >>>>> >>>>> - a function, which will be called with the input as the >>>>> argument. If the function returns a non-nil value, the >>>>> minibuffer is exited with that argument as the value. >>>>> >>>>> Is this a bug, a case of under-documentation, or do I misunderstand something? >>>>> >>>>> I'm happy to post this in a separate bug thread if you think it's worth it. >>>> >>>> Perhaps that would be worth doing, that way the people who know more >>>> about completion than I do would be more likely to see it and help >>>> out. >>> >>> Okay, thanks! I'll do that. >> >> Now that #66187 >> () >> and bug#68815 >> () >> are fixed on emacs-29, I'm revisiting this issue. >> >> With the following patch, the interactive prompt in package-vc-checkout >> now offers all directory for completion (empty or not), but only exits >> when the minibuffer contains an empty directory or nonexistent filename. >> >> Testing this patch requires checking out emacs-29 after e6c82fe35e3. > > LGTM, I've pushed it to emacs-29. Thanks! Thanks!! Joseph