From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master babe6a5e948 1/2: Introduce a new TRAMP method `androidsu' Date: Sun, 03 Mar 2024 20:09:13 +0800 Message-ID: <87a5nf34ba.fsf@yahoo.com> References: <170892805989.23297.10872025500935567738@vcs2.savannah.gnu.org> <20240226061420.EF1D4C00231@vcs2.savannah.gnu.org> <875xybtxq0.fsf@gmx.de> <87a5nn61k7.fsf@yahoo.com> <87r0gzpopy.fsf@gmx.de> <875xyb5wct.fsf@yahoo.com> <87edcsptvh.fsf@gmx.de> <87sf182ep4.fsf@yahoo.com> <877cijhbxy.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39231"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 03 13:10:37 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rgkft-000A2h-Dg for ged-emacs-devel@m.gmane-mx.org; Sun, 03 Mar 2024 13:10:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rgkfA-0001fs-CY; Sun, 03 Mar 2024 07:09:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rgkf8-0001fb-F6 for emacs-devel@gnu.org; Sun, 03 Mar 2024 07:09:50 -0500 Original-Received: from sonic314-20.consmr.mail.ne1.yahoo.com ([66.163.189.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rgkf4-0005l8-Sl for emacs-devel@gnu.org; Sun, 03 Mar 2024 07:09:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1709467784; bh=OjIL4ttztptk4tmz6RXifIEdZMuCICc3/RntkkTvgmQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=BkMpvHqn0vbLhgQ+016o/DRNnZnhoTmk2XUz0AiVawKoUFuQJQbIKjfL9QiySDIUaPKltjMETVb0WKsfPJWEpSmJlYGx61j4E2dZevtgCedugzS9f/YvwsWypRoB1PslHkPHTefDyO5BGR/gKc1hELT6xr4rsZ0ozpV7yZUnkXV06F2yzTXM9mx1NoyIptEqgwW4vVjQLYzHE19UUmmtX0eCwpZYsl1mocYHzdO5sudFSLuA44rzCpJ40nlWYxJ7g6K4v5XPfA5Y0k739DnH+Xb7RvPloAKjdl6kB2j1JtD7DZ/T3Tmd77R4tBbucLcZJjn/hewDibFS4LEXuE0/0A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1709467784; bh=lfY1jVY+Lp1VhbcD4BcBSFErEi5o6UFVTKLP73svmpY=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=l4MGXhDvrsLo+bEd16yfL4+n+xg91QPPD4tjjpR2D5ZSEU3P3cqWDj6oLrnlwLJtGDs+YvtDTHRmNV3YRVFhRVTCCruoNTrhALWre/pO3aTUefG3OuaGSX25NAHqQeeUL3ELLuunDiNJtkK6FHtk1FVNJYdYyx/oaKEHMctnVLrdrP8q63W4cBv2+wjsEPU+HKmWtSYEOdd6kKS7u3x66JwD/PvdFpdVHa7Xkcl4LwhL9um6P/4oINgZ9//vKoXTPvI9SzdCxOQUNjTl7Rbl5KmRcBL8II1jCi2rGLMVF5fbNlz2OYMFP6FPrL9Ug+Gh4V1re7ZXFdPvXIz2/HYHkw== X-YMail-OSG: Iv50DysVM1lTqhRB6c4q.L2cDS7wztUu8szNT5wqg_oLmLGojjKT84h63FLEx0P TmZ0qDUE2BpjNOfzE8Oui6DxygGGvu_63OxmxqW6Nx34_2DbsiM9ARnDUqJwwrqsEycT41j_NgZX 8ReL7qnoFpbFIUaRD3ETKsr8XCXw2Aci2HlI6XbpovbfOVMIecQOCoRYgbGSx7hwyXKbDl2b5NKx 1M4CFSJGXrxlthUKfYqUIwbce5epYsD2yevjr0_9zdY3pR7O0jy8p7ZmZz3nWEMmDwJchCDgaPWL SDZ45InIOy_7AbP_PwNhPF1Bfh2r3CFnHbJJTBbGg8LCA_zoVfsu0i76QDZB4l19AnjfSXfgj6yX E0qhs4e3wWBx1cid7EgTS3aLRwDISvQjgQ8ssOTOWZbGdOPMp6a2W3DqDvJbZ622bTkKc1KGVDxF 5hO0zlPTlfOTTb4FzeQC1vdrL5QGtrG7x8zbmBPb7qKZtbeg2RBIBbE.Qe6Qs98t73sJqKgHnIE. K5LipPQzvcP8qQgaYphVswdgKWFU7b2WeMrS_YhA3rFaUKh_lnEieO6Q7jc.SJEA42zBgxSWefuv byAzn8KMiJHa5614uEq0I45gkuzuWPOfQ6fkmYqvHzoamoKIguNkj86piivBvgKNnjmQY_vgh6V1 SCVbDKzIxDUDP4PYzLotCHLIH.AbnLzi7aCUo_3liegge8EGoF7DYopoyaFkh9JNK9QTAnL8vCXk .WaXmXf5I9YNfHKdfSH_xdLVwZuX.vJj8KHm0ecM17oSVnwo2gxImcBQDNYX1s9HPVsT.v21bY1e 2IS8nqEgpNbVRrLKCC6Q.DBLtgnIgz.jownBw0rgzV X-Sonic-MF: X-Sonic-ID: 1be1bd8b-f318-47a9-9174-a09c09fa820b Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Sun, 3 Mar 2024 12:09:44 +0000 Original-Received: by hermes--production-sg3-6dc75bc8fb-ddr5z (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 026beef6053644485bde930b03d82697; Sun, 03 Mar 2024 12:09:38 +0000 (UTC) In-Reply-To: <877cijhbxy.fsf@gmx.de> (Michael Albinus's message of "Sun, 03 Mar 2024 11:00:41 +0100") X-Mailer: WebService/1.1.22103 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.146; envelope-from=luangruo@yahoo.com; helo=sonic314-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316747 Archived-At: Michael Albinus writes: > -(defconst tramp-androidsu-method "androidsu" > +(defconst tramp-androidsu-method "su" > "When this method name is used, forward all calls to su.") > > ;;;###tramp-autoload > @@ -66,10 +66,7 @@ tramp-androidsu-su-mm-supported > (tramp-remote-shell-login ("-l")) > (tramp-remote-shell-args ("-c")) > (tramp-tmpdir "/data/local/tmp") > - (tramp-connection-timeout 10))) > - > - (add-to-list 'tramp-default-host-alist > - `(,tramp-androidsu-method nil "localhost"))) > + (tramp-connection-timeout 10)))) > > (defvar android-use-exec-loader) ; androidfns.c. > > @@ -645,7 +642,8 @@ tramp-androidsu-file-name-handler-alist > (defsubst tramp-androidsu-file-name-p (vec-or-filename) > "Check whether VEC-OR-FILENAME is for the `androidsu' method." > (when-let* ((vec (tramp-ensure-dissected-file-name vec-or-filename))) > - (equal (tramp-file-name-method vec) tramp-androidsu-method))) > + (and (eq system-type 'android) > + (equal (tramp-file-name-method vec) tramp-androidsu-method)))) > > ;;;###tramp-autoload > (defun tramp-androidsu-file-name-handler (operation &rest args) I've yet to test this patch, but nevertheless won't it override the default file name handlers even in multi-hop connections, where su will definitely not be executed under Android?