From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71883: [PATCH] Fix tab-bar-auto-width with customized tab-bar-tab-face-function Date: Thu, 25 Jul 2024 11:52:19 -0700 Message-ID: <87a5i5fgnw.fsf@breatheoutbreathe.in> References: <87le2kaloz.fsf@breatheoutbreathe.in> <861q4ce1yb.fsf@mail.linkov.net> <877ce3damx.fsf@breatheoutbreathe.in> <86r0cb7l58.fsf@mail.linkov.net> <5aff3095-087f-493d-9251-8048b51280f9@alphapapa.net> <86msmzc7ne.fsf@mail.linkov.net> <86o77dox54.fsf@mail.linkov.net> <87a5ihgii9.fsf@breatheoutbreathe.in> <86jzhkgtb7.fsf@gnu.org> <865xt1lw66.fsf@mail.linkov.net> <87ikwttk96.fsf@breatheoutbreathe.in> <865xstibce.fsf@mail.linkov.net> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15104"; mail-complaints-to="usenet@ciao.gmane.io" Cc: adam@alphapapa.net, 71883@debbugs.gnu.org, Eli Zaretskii , shipmints@gmail.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 25 20:53:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sX3aX-0003jo-UE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jul 2024 20:53:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sX3aF-0001qT-V7; Thu, 25 Jul 2024 14:52:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sX3aE-0001qA-Ce for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2024 14:52:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sX3aB-0002SZ-EU for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2024 14:52:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sX3aH-0004Fa-Q4 for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2024 14:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2024 18:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71883-submit@debbugs.gnu.org id=B71883.172193356216307 (code B ref 71883); Thu, 25 Jul 2024 18:53:01 +0000 Original-Received: (at 71883) by debbugs.gnu.org; 25 Jul 2024 18:52:42 +0000 Original-Received: from localhost ([127.0.0.1]:37765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX3Zx-0004Ew-NF for submit@debbugs.gnu.org; Thu, 25 Jul 2024 14:52:42 -0400 Original-Received: from out-174.mta1.migadu.com ([95.215.58.174]:41564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sX3Zu-0004Ef-ST for 71883@debbugs.gnu.org; Thu, 25 Jul 2024 14:52:40 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1721933544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TGknkb3z0sB345NS46EqDajweFnyS2+/3E4sQghKhFE=; b=bOxGl/laNmyG0nHlmT7Ub4USPwtnXRbWvJzPoFqWmZ8tSB5YsUycHU8u8/02mnq3aMjnnM gFeeJ+21zDMfT7i2Kzn78eFnBlGqZkGgfCgxsaGgXqL1Las95LEAn9BAJ66fRmMIJzFOZb ZPU1WPQkmsHvr43/M8KsKhQMFnBC0SU= In-Reply-To: <865xstibce.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 25 Jul 2024 21:18:57 +0300") X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289332 Archived-At: Juri Linkov writes: >>> Replacing hard-coded logic with customizable variable >>> for external packages like activities.el is needed >>> as soon as possible on emacs-30 because hard-coded logic >>> hinders the use of packages. >>> >>> However, there is no hurry to change the default behavior >>> to match a symbol name instead of checking face names. >>> Therefore I think better to move the existing code >>> >>> (memq (get-text-property 0 'face (nth 2 item)) tab-bar-auto-width-faces) >>> >>> to the new predicate function on emacs-30. Then activities.el >>> can change it to another function that matches a symbol. >>> >>> Then on master the default body on the new predicate >>> could be replaced from checking the face to match a symbol. >>> Also changes in tab-bar--format-tab-group should be on master as well. >> >> Much as I'd like to use these changes asap, I think this patchset should >> go entirely on master. I see these changes as adding functionality >> (making tab-bar tabs more extensible) rather than bug fixes. > > Are you sure there is no hurry to make tab-bar more extensible > for activities.el? Then let's push to master for Emacs 31. The effect on activities.el is purely cosmetic. I think it's fine to wait for 31. Thanks for thinking it through together with me! Joseph