From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback) Date: Mon, 23 Sep 2024 13:34:27 +0200 Message-ID: <87a5fyioxo.fsf@ledu-giraud.fr> References: <87cyky43fb.fsf@ice9.digital> <86setu5f85.fsf@gnu.org> <87zfo22jy4.fsf@ice9.digital> <86bk0h5sx9.fsf@gnu.org> <87ldzlgxvh.fsf@ice9.digital> <87msk0oqoq.fsf@gnu.org> <87plovmmox.fsf@ice9.digital> <8734lqzx64.fsf@gnu.org> <877cb2kbta.fsf@ledu-giraud.fr> <87y13iyd0c.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39417"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Morgan Willcock , emacs-devel@gnu.org, Eli Zaretskii , visuweshm@gmail.com To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 23 13:35:32 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sshLn-000A4y-E4 for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Sep 2024 13:35:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sshL0-0001X6-KZ; Mon, 23 Sep 2024 07:34:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sshKu-0001Wr-UO for emacs-devel@gnu.org; Mon, 23 Sep 2024 07:34:37 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sshKr-0005YN-Ut; Mon, 23 Sep 2024 07:34:36 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=ApT6UkP/ N0a/ElPKYSAwCcwHWjjTd0pNz0LKTjyLMyI=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=FF0H8a21fhGcV7gigHB15yhlccTs+1 VeFi4+p1HYGkaR4IPDNMh7TjepjLtEho2UTv+yVnXWfIGDMlioQfYnBA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=ApT6UkP/N0a/ElPK YSAwCcwHWjjTd0pNz0LKTjyLMyI=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=a23REk75Foks9PjDLb8IranCKpssE15cwH/ted 5nwgZxG5iGI1YKFyPerjdeyx2JdFAP3BQv6iQsSNLdvBkr3oITnTKu919jHvW0P5sj0p+H jkeDpR5KUy5sxln1w96rBcfD2bDKuS9+v+DCvnen3I4SWHSAtKc+6JUlXrDatwkVPWzYun Z+7zdWokJ7AXLpgWdcNUYIhobgQXoqnYWSLmCKeszFTCe9xTyA11+cm5a7qSNxkLsOmB5P z1NC3Zwm2sCK/DIr3SO2Z0DRGIY3BGGiL7EvgpH3vR/ULaU7Ni3txtNrxlTSJYltVr5i1J EIQ9pifcaMbbZlyAjVd7qxVg== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 73999f01 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 23 Sep 2024 13:34:29 +0200 (CEST) In-Reply-To: <87y13iyd0c.fsf@gnu.org> (Tassilo Horn's message of "Mon, 23 Sep 2024 10:45:23 +0200") Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323954 Archived-At: Tassilo Horn writes: > Manuel Giraud writes: > > Hi Manuel, Hi Tassilo, >> When I introduced doc-view-svg-face to inherit from the default face, >> I thought it was right for reading long papers to match the user's >> preference. > > Did you read that when NOT inheriting from the default face and > therefore having all face properties nil also styles according to the > currently active theme? But yes, you replaced the old variables > doc-view-svg-background/foreground with the new face, and the old > variables where "white"/"black" by default. Yes. It seems that inherinting from default or having all properties to nil does the same thing. FWIW, I think we should still use the former which is more explicit. >> Now, for invoices or other more complex documents, it may be better to >> default to "black on white". > > Seems so. > >> But I think we should explain that one could inherit from the default >> face to have its theme used into the doc-view-svg-face's docstring. > > Certainly. Would you like to do that? Yes, I could file a bug report with both changes (face colors and docstring) but I'd like to hear Eli inputs first. -- Manuel Giraud