From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#72826: 30.0.90; icomplete-in-buffer becomes unusably slow in large Eshell Date: Fri, 04 Oct 2024 19:02:27 +0800 Message-ID: <87a5fkyvuk.fsf@melete.silentflame.com> References: <87seuqjuk4.fsf@melete.silentflame.com> <86r0aai1an.fsf@gnu.org> <8734ldxntq.fsf@melete.silentflame.com> <8634ldz07h.fsf@gnu.org> <87frpcwwge.fsf@melete.silentflame.com> <86y134xuqx.fsf@gnu.org> <871q0w44wu.fsf@melete.silentflame.com> <86r08wxhpq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27491"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: joaotavora@gmail.com, 72826@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 04 13:03:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1swg5a-0006xB-O6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Oct 2024 13:03:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swg5O-0007OG-GK; Fri, 04 Oct 2024 07:03:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swg5L-0007Nl-Od for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2024 07:02:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1swg5L-0004TB-BU for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2024 07:02:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=NEYLhPjziC/tizcM7qcjcMBscQ7XJFimoG/0s0PWLCw=; b=npsuJ9+n6eWXC4OqT9FQYhX+rwkeyS/hhJIcPK5c7xWtEcy9vg9oEas/KAD6weH5SlGw0RaRiY1F7q0W+MWmBCc1FictKMdqklU+8hC4IQiCp7dieJu7F9bRjo/VwdkKVbbh3R9sRtYcPOQzTy57eDswU3SnnU6lxbVAPl4nyo9lOxzebOqeunYMgjWyTE0dvTnJI3QLGbDvh2k49OptR/AALPRYg66O6SxiHShfrLDMoeoAWFysFVZ4295FR2+K47sOiyBf5B60f+ONedQrreISQW+R57DJGm2aP42mngIkpQDJSGq+rstsj6d7t5b/c7PwdtEWokGsLAWysk8Jpw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1swg5O-0006Ac-4f for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2024 07:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Oct 2024 11:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72826 X-GNU-PR-Package: emacs Original-Received: via spool by 72826-submit@debbugs.gnu.org id=B72826.172803976623689 (code B ref 72826); Fri, 04 Oct 2024 11:03:02 +0000 Original-Received: (at 72826) by debbugs.gnu.org; 4 Oct 2024 11:02:46 +0000 Original-Received: from localhost ([127.0.0.1]:34485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swg58-0006A0-0i for submit@debbugs.gnu.org; Fri, 04 Oct 2024 07:02:46 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:51586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swg52-00069i-SX for 72826@debbugs.gnu.org; Fri, 04 Oct 2024 07:02:45 -0400 DKIM-Signature: a=rsa-sha256; b=xN6TqAnBWlB97JF1z18fRHIJ6thF++Pai+lbIi+bUYknV3Fslo+JwvMup/ZZpctzYDj2aKHsNzg4zXKrG7qpsrYMWEgbNzcgqjHgT/J/r3oqDIC2adXtVkQrF+juc5wwfMEwoWvDLsvBLL7LkzRZG89kU1azXrawLyd20SDUe1toCsr12ZZjYRjRExs7tcOqTYsmO8kMov1fCNzigLiJ+4GlD/S7M9LlRYIwxrhWxHJFMJ/y1PFP83kFvBghE3gH7x6XflWQylKbm28BkzMuV8lvZGbwASxI6AjMm1OjQxejG2HHDJ1IsNlav1iGkDF374PRm3ke0W4N92K73k4pZg==; s=purelymail2; d=spwhitton.name; v=1; bh=mRYby/DG+g3Hpqa7GzwGTZsTp5TvyCHt8M6J49OZxWQ=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=rdgc46KUSisPLn9QRZklQOhHb1a74d0Y0VVjpnKKeiyY0FjF0GgZ64Xj1XC1G8DkT5VO+1DPj87yBpJQcX5l016Xw3J0ypsLWaFaaalg9hNhlLzB+onAbxJ2jjT/5tnWTuzgaqZrTrxYnceyo8VpAw8PVYPR8ut4WtBeLqo9WbE7R0N3igJ7QNBjgH+9IRsEC9AQX6oAT53RFeYFMrOHrm/lkR01O8TvPiKV8YXUMHXhR7WEccRhhmoVYa2EeryW/V0FG2iq76x4mV9iZsNqw1R1iRwzkL9GYjT8b/TbHhZu9MfV5WG2lbHhCZFbgMjD/sXs/VrHz4Dr9yrKjvAZog==; s=purelymail2; d=purelymail.com; v=1; bh=mRYby/DG+g3Hpqa7GzwGTZsTp5TvyCHt8M6J49OZxWQ=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 72826@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 2028418549; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 04 Oct 2024 11:02:30 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 1E1847E4A40; Fri, 4 Oct 2024 19:02:27 +0800 (CST) In-Reply-To: <86r08wxhpq.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Oct 2024 13:53:05 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292957 Archived-At: Hello, On Fri 04 Oct 2024 at 01:53pm +03, Eli Zaretskii wrote: >> From: Sean Whitton >> Cc: joaotavora@gmail.com, 72826@debbugs.gnu.org, juri@linkov.net >> Date: Fri, 04 Oct 2024 17:02:25 +0800 >> >> Cases where the old code and new code are different are when the >> minibuffer prompt contains line breaks. The new code effectively >> ignores all parts of the minibuffer prompt except its last line. I >> think that's correct, and the old code could have calculated an overly >> large width if previous lines of the minibuffer prompt were longer than >> the final line. > > So you are saying that the old code never worked correctly for > minibuffer prompts that include embedded newlines? Then how come no > one complained about that before? This bug is not about incorrect > result, it's about slow responses, and that's something entirely > different. Well, not many people use Icomplete mode, and not many minibuffer prompts have embedded newlines. If you prefer I could conditionalise the code so it does exactly the same as it always did in the minibuffer, and only does something different when completing in a region in a non-minibuffer? -- Sean Whitton