all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Morgan Willcock <morgan@ice9.digital>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 73533@debbugs.gnu.org
Subject: bug#73533: [PATCH] Rewrite speedbar expansion for all descendants
Date: Sat, 19 Oct 2024 18:30:13 +0100	[thread overview]
Message-ID: <87a5f0c862.fsf@ice9.digital> (raw)
In-Reply-To: <86y12klery.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Oct 2024 10:42:41 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> There seems to be still a problem with some files, in that
> speedbar-expand-line-descendants takes a very long time, and if I
> interrupt it with C-g, I see nested DEFUNs, something that shouldn't
> happen, because DEFUNs are never nested.  E.g., try this:
>
>  $ cd /path/to/emacs/src
>  $ ./emacs -Q
>  M-x speedbar RET
>
> At this point you should see all the files in the Emacs src directory.
> Go to androidfns.c and type '['.  After about 10 sec type C-g.  You
> should see nested DEFUns in the Speedbar frame.
>
> Could you please look into this?

This looks like an unrelated issue where the logic to modify the item
hierarchy does not make sense under certain conditions.  It only seems
to trigger when particular limits are met, but the limits can be lowered
for an easier demonstration:

  (require 'speedbar)
  (setq speedbar-tag-regroup-maximum-length 2)
  (setq speedbar-tag-split-minimum-length 2)

  (speedbar-prefix-group-tag-hierarchy
   '(("DEFUN" . 1)
     ("DEFUN" . 5)
     ("DEFUN" . 10)))

  => (("DEFUN" ("DEFUN" . 1) ("DEFUN" . 5) ("DEFUN" . 10)))

i.e. speedbar-prefix-group-tag-hierarchy (which is meant to restructure
the Imenu data to make better use of the available space in the
Speedbar) is generating a new parent item which contains the items that
were meant to be inserted.

It is probably best to open a separate bug report for this because
working out exactly how and why speedbar-prefix-group-tag-hierarchy
applies particular sorting actions will probably take someone a while.

-- 
Morgan Willcock





  reply	other threads:[~2024-10-19 17:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-28 19:05 bug#73533: [PATCH] Rewrite speedbar expansion for all descendants Morgan Willcock
2024-09-29  4:46 ` Eli Zaretskii
2024-09-29  9:52   ` Morgan Willcock
2024-09-30  9:03     ` Morgan Willcock
2024-09-30 18:28       ` Morgan Willcock
2024-10-08 18:36         ` Morgan Willcock
2024-10-19  7:42           ` Eli Zaretskii
2024-10-19 17:30             ` Morgan Willcock [this message]
2024-10-19 17:41               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5f0c862.fsf@ice9.digital \
    --to=morgan@ice9.digital \
    --cc=73533@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.