From: "Tor-björn Claesson" <tclaesson@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>, emacs-orgmode@gnu.org
Subject: Re: Org-cite: Replace basic follow-processor with transient menu?
Date: Tue, 22 Oct 2024 10:23:26 +0300 [thread overview]
Message-ID: <87a5ewfvo1.fsf@gmail.com> (raw)
In-Reply-To: <87r08lqlbu.fsf@localhost> (Ihor Radchenko's message of "Sat, 12 Oct 2024 17:31:49 +0000")
Ihor Radchenko <yantar92@posteo.net> writes:
> Thanks! This looks much more clean.
> Even better would be having a defcustom that defines the transient
> layout. The idea is to avoid hard-coding [["Open" ... ] ["Copy" ...]
> ...] and instead make it defcustom.
Here is a solution that works for me. Is this an OK use of eval, or is
there a better way of doing this?
(defcustom org-cite-basic-follow-actions
'[["Open"
("b" "bibliography entry" org-cite-basic-follow.open-bibliography)]
["Copy"
("d" "DOI" org-cite-basic-follow.copy-doi)]
["Browse"
("u" "url" org-cite-basic-follow.browse-url)]]
"Contents of the org-cite-basic-follow transient menu.
This can be customized directly using the customization
interface. Use setopt instead of setq if you change this option
in elisp, to ensure that the transient is rebuilt.
Further actions can be added using transient-define-suffix."
:group 'org-cite
:type 'sexp
:set (lambda (option-name new-value)
(eval
`(transient-define-prefix org-cite-basic-follow (citation &optional prefix)
"Follow a citation reference.
The contents of this transient menu is set in org-cite-basic-follow-actions."
,new-value
(interactive)
(if (or org-cite-basic-follow-ask prefix)
(transient-setup 'org-cite-basic-follow nil nil :scope (list citation prefix))
(org-cite-basic-goto citation prefix))))
(set-default-toplevel-value option-name new-value)))
>> (transient-define-suffix org-cite-basic-follow.open-bibliography (citation prefix)
>> "Find bibliography entry for citation"
>> (interactive (oref (transient-prefix-object) scope))
>> (org-cite-basic-goto citation prefix))
>>
>> ...
>
> (oref (transient-prefix-object) scope) is equivalent to (transient-scope)
>
Ah, thanks!
>> And I can then for example add my own pdf-action like this:
>>
>> (transient-append-suffix 'org-cite-basic-follow "b"
>> '("p" "pdf"
>> (lambda (citation prefix)
>> (interactive (oref (transient-prefix-object) scope))
>> (find-file-other-window
>> (concat
>> tbc/projektet
>> "Referensartiklar"
>> "/"
>> (org-element-property :key citation)
>> ".pdf")))))
>
> It feels a bit too complex to demand knowledge of these transient
> details (how to get the arglist) from users.
>
> I am wondering if we can somehow plug the existing commands passing the
> arguments without any extra setup on the user side.
The lambda form is much neater with your (transient-scope) suggestion:
(lambda (citation prefix)
(interactive (transient-scope))
...)
Is this simple enough? I don't feel a macro would improve the
situation.
Best regards,
Tor-björn
next prev parent reply other threads:[~2024-10-22 7:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 12:36 Org-cite: Replace basic follow-processor with transient menu? Tor-björn Claesson
2024-09-15 14:36 ` Ihor Radchenko
2024-09-17 12:18 ` Tor-björn Claesson
2024-09-22 12:50 ` Ihor Radchenko
2024-09-24 10:07 ` Tor-björn Claesson
2024-10-12 17:31 ` Ihor Radchenko
2024-10-22 7:23 ` Tor-björn Claesson [this message]
2024-10-22 17:58 ` Ihor Radchenko
2024-10-24 14:18 ` Jonas Bernoulli
2024-10-24 17:32 ` Ihor Radchenko
2024-10-26 11:45 ` Jonas Bernoulli
2024-10-27 8:09 ` Ihor Radchenko
2024-10-27 9:17 ` Tor-björn Claesson
2024-10-29 4:58 ` Tor-björn Claesson
2024-10-29 18:55 ` Ihor Radchenko
2024-10-30 5:37 ` Tor-björn Claesson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ewfvo1.fsf@gmail.com \
--to=tclaesson@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.