Missing follow-links in descr-text

Missing follow-links in descr-text

[martin rudalics]

Please consider adding a few follow-link properties to descr-text.el.
The current behavior of `describe-char', for example, is a bit chaotic
with `mouse-1-click-follows-link' non-nil.

	* descr-text.el (describe-text-widget, describe-text-sexp)
	(describe-property-list, describe-char): Add follow-link
	property.

*** descr-text.el	Thu Jan  5 07:44:36 2006
--- descr-text.el	Mon Feb 13 11:21:52 2006
***************
*** 41,47 ****
     (symbol-name (if (symbolp widget) widget (car widget)))
     'action `(lambda (&rest ignore)
  	      (widget-browse ',widget))
!    'help-echo "mouse-2, RET: browse this widget")
    (insert " ")
    (insert-text-button
     "(widget)Top" 'type 'help-info 'help-args '("(widget)Top")))
--- 41,48 ----
     (symbol-name (if (symbolp widget) widget (car widget)))
     'action `(lambda (&rest ignore)
  	      (widget-browse ',widget))
!    'help-echo "mouse-2, RET: browse this widget"
!    'follow-link t)
    (insert " ")
    (insert-text-button
     "(widget)Top" 'type 'help-info 'help-args '("(widget)Top")))
***************
*** 64,70 ****
  			(with-output-to-temp-buffer
  			    "*Pp Eval Output*"
  			  (princ ',pp)))
!        'help-echo "mouse-2, RET: pretty print value in another buffer"))))

  (defun describe-property-list (properties)
    "Insert a description of PROPERTIES in the current buffer.
--- 65,72 ----
  			(with-output-to-temp-buffer
  			    "*Pp Eval Output*"
  			  (princ ',pp)))
!        'help-echo "mouse-2, RET: pretty print value in another buffer"
!        'follow-link t))))

  (defun describe-property-list (properties)
    "Insert a description of PROPERTIES in the current buffer.
***************
*** 88,94 ****
  	      (symbol-name value)
  	      'action `(lambda (&rest ignore)
  			 (describe-text-category ',value))
! 	      'help-echo "mouse-2, RET: describe this category"))
              ((memq key '(face font-lock-face mouse-face))
  	     (insert-text-button
  	      (format "%S" value)
--- 90,97 ----
  	      (symbol-name value)
  	      'action `(lambda (&rest ignore)
  			 (describe-text-category ',value))
! 	      'help-echo "mouse-2, RET: describe this category"
! 	      'follow-link t))
              ((memq key '(face font-lock-face mouse-face))
  	     (insert-text-button
  	      (format "%S" value)
***************
*** 477,483 ****
  				(search-forward ,(char-to-string char)
  						nil t))))
  		  'help-echo
! 		  "mouse-2, RET: show this character in its character set")))
  	    ("syntax"
  	     ,(let ((syntax (syntax-after pos)))
  		(with-temp-buffer
--- 480,487 ----
  				(search-forward ,(char-to-string char)
  						nil t))))
  		  'help-echo
! 		  "mouse-2, RET: show this character in its character set"
! 		  'follow-link t)))
  	    ("syntax"
  	     ,(let ((syntax (syntax-after pos)))
  		(with-temp-buffer

Re: Missing follow-links in descr-text

[Juri Linkov]

> Please consider adding a few follow-link properties to descr-text.el.
> The current behavior of `describe-char', for example, is a bit chaotic
> with `mouse-1-click-follows-link' non-nil.

Instead of adding `follow-link t' to each and every place, what do you
think about fixing this at the top level with the following patch?

Index: lisp/button.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/button.el,v
retrieving revision 1.21
diff -c -r1.21 button.el
*** lisp/button.el	6 Feb 2006 14:33:32 -0000	1.21
--- lisp/button.el	13 Feb 2006 17:57:07 -0000
***************
*** 79,84 ****
--- 79,85 ----
  ;; Default properties for buttons
  (put 'default-button 'face 'button)
  (put 'default-button 'mouse-face 'highlight)
+ (put 'default-button 'follow-link t)
  (put 'default-button 'keymap button-map)
  (put 'default-button 'type 'button)
  ;; action may be either a function to call, or a marker to go to

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: Missing follow-links in descr-text

[martin rudalics]

 > Instead of adding `follow-link t' to each and every place, what do you
 > think about fixing this at the top level with the following patch?
 >
 > + (put 'default-button 'follow-link t)

That's what I had in my .emacs till today.  It's an abuse of the button
idea, nevertheless.  Although, the plethora of follow-links derived from
help-xref could serve as an excuse.  With other words, practically each
and every use of default-button already has a follow-link property,
hence why not store it at "top level" in the first place.