Re: [PATCH] Better error reporting in Gnus splitting.

[Karl Fogel <kfogel@red-bean.com>]

I was about to commit the patch below, when I realized that our Emacs
tree might not be master repository for Gnus.  When I do 'cvs log' on
lisp/gnus/<whatever>.el, it seems to indicate that changes generally
get merged in from somewhere else -- i.e., that we are not the master.

Is it okay to check new changes into lisp/gnus/, or should they go to
some other tree and get merged from there into ours?  Or is Arch magic
taking care of this whole problem and I shouldn't worry about it?

-Karl

Karl Fogel <kfogel@red-bean.com> writes:
> Any objections if I commit this patch?
>
> Without this patch, when splitting encounters an error (say, an
> invalid regular expression) in the nnmail-split-fancy list, then the
> user is simply told that there is an error, but is given no details
> about the error's nature.  The mail gets split into the 'bogus' mail
> group, and the user has no idea why.
>
> With this patch, the user is informed about the general nature of the
> error and may then be able to track it down.  (The error report could
> theoretically be even more informative than this, but I didn't want to
> make a large change.)  The mail is still filtered into 'bogus' group.
>
> See simple patch below.
>
> -Karl
>
> Index: ChangeLog
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/gnus/ChangeLog,v
> retrieving revision 1.474
> diff -u -r1.474 ChangeLog
> --- ChangeLog	19 Jul 2006 01:06:00 -0000	1.474
> +++ ChangeLog	19 Jul 2006 01:51:44 -0000
> @@ -1,3 +1,9 @@
> +2006-07-18  Karl Fogel  <kfogel@red-bean.com>
> +
> +	* nnmail.el (nnmail-article-group): If splitting raises an error, give
> +	some information about the error when saying that the `bogus' mail
> +	group will be used.
> +
>  2006-07-18  Andreas Seltenreich  <uwi7@rz.uni-karlsruhe.de>
>  
>  	[ Backported bug fixes from No Gnus. ]
> Index: nnmail.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/gnus/nnmail.el,v
> retrieving revision 1.33
> diff -u -r1.33 nnmail.el
> --- nnmail.el	9 Mar 2006 07:11:51 -0000	1.33
> +++ nnmail.el	19 Jul 2006 01:51:45 -0000
> @@ -1131,7 +1131,7 @@
>  	(if (and (symbolp nnmail-split-methods)
>  		 (fboundp nnmail-split-methods))
>  	    (let ((split
> -		   (condition-case nil
> +		   (condition-case error-info
>  		       ;; `nnmail-split-methods' is a function, so we
>  		       ;; just call this function here and use the
>  		       ;; result.
> @@ -1139,7 +1139,7 @@
>  			   '("bogus"))
>  		     (error
>  		      (nnheader-message
> -		       5 "Error in `nnmail-split-methods'; using `bogus' mail group")
> +		       5 "Error in `nnmail-split-methods'; using `bogus' mail group: %S" error-info)
>  		      (sit-for 1)
>  		      '("bogus")))))
>  	      (setq split (mm-delete-duplicates split))
>
>
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-devel