From: Ryan Yeske <rcyeske@gmail.com>
To: Ryan Yeske <rcyeske@gmail.com>
Cc: cyd@stupidchicken.com, emacs-devel@gnu.org,
monnier@iro.umontreal.ca, miles@gnu.org
Subject: Re: rcirc update
Date: Thu, 28 Jun 2007 02:51:55 -0700 [thread overview]
Message-ID: <878xa44dac.fsf@owie.lan> (raw)
In-Reply-To: <877ipyl7wf.fsf@owie.lan> (message from Ryan Yeske on Wed, 20 Jun 2007 12:53:36 -0700)
I sent this last week, and it hasn't been installed.
> Resending last patch, with changes.
>
> I renamed rcirc-connections, use :symbols, and improved the
> documentation.
2007-06-20 Ryan Yeske <rcyeske@gmail.com>
* rcirc.el (rcirc-server-alist): Rename from rcirc-connections.
(rcirc-default-full-name): Rename from
rcirc-default-user-full-name.
(rcirc-clear-activity): Make sure RCIRC-ACTIVITY isn't modified.
(rcirc-print): Never ignore messages from ourself.
Index: rcirc.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/net/rcirc.el,v
retrieving revision 1.35
diff -c -r1.35 rcirc.el
*** rcirc.el 13 Jun 2007 21:17:16 -0000 1.35
--- rcirc.el 20 Jun 2007 19:05:30 -0000
***************
*** 55,61 ****
:link '(custom-manual "(rcirc)")
:group 'applications)
! (defcustom rcirc-connections
'(("irc.freenode.net" :channels ("#rcirc")))
"An alist of IRC connections to establish when running `rcirc'.
Each element looks like (SERVER-NAME PARAMETERS).
--- 55,61 ----
:link '(custom-manual "(rcirc)")
:group 'applications)
! (defcustom rcirc-server-alist
'(("irc.freenode.net" :channels ("#rcirc")))
"An alist of IRC connections to establish when running `rcirc'.
Each element looks like (SERVER-NAME PARAMETERS).
***************
*** 63,72 ****
SERVER-NAME is a string describing the server to connect
to.
! PARAMETERS is a plist of optional connection parameters. Valid
! properties are: nick (a string), port (number or string),
! user-name (string), full-name (string), and channels (list of
! strings)."
:type '(alist :key-type string
:value-type (plist :options ((nick string)
(port integer)
--- 63,97 ----
SERVER-NAME is a string describing the server to connect
to.
! The optional PARAMETERS come in pairs PARAMETER VALUE.
!
! The following parameters are recognized:
!
! `:nick'
!
! VALUE must be a string. If absent, `rcirc-default-nick' is used
! for this connection.
!
! `:port'
!
! VALUE must be a number or string. If absent,
! `rcirc-default-port' is used.
!
! `:user-name'
!
! VALUE must be a string. If absent, `rcirc-default-user-name' is
! used.
!
! `:full-name'
!
! VALUE must be a string. If absent, `rcirc-default-full-name' is
! used.
!
! `:channels'
!
! VALUE must be a list of strings describing which channels to join
! when connecting to this server. If absent, no channels will be
! connected to automatically."
:type '(alist :key-type string
:value-type (plist :options ((nick string)
(port integer)
***************
*** 90,98 ****
:type 'string
:group 'rcirc)
! (defcustom rcirc-default-user-full-name (if (string= (user-full-name) "")
! rcirc-default-user-name
! (user-full-name))
"The full name sent to the server when connecting."
:type 'string
:group 'rcirc)
--- 115,123 ----
:type 'string
:group 'rcirc)
! (defcustom rcirc-default-full-name (if (string= (user-full-name) "")
! rcirc-default-user-name
! (user-full-name))
"The full name sent to the server when connecting."
:type 'string
:group 'rcirc)
***************
*** 335,341 ****
;;;###autoload
(defun rcirc (arg)
! "Connect to all servers in `rcirc-connections'.
Do not connect to a server if it is already connected.
--- 360,366 ----
;;;###autoload
(defun rcirc (arg)
! "Connect to all servers in `rcirc-server-alist'.
Do not connect to a server if it is already connected.
***************
*** 343,352 ****
(interactive "P")
(if arg
(let* ((server (completing-read "IRC Server: "
! rcirc-connections
nil nil
! (caar rcirc-connections)))
! (server-plist (cdr (assoc-string server rcirc-connections)))
(port (read-string "IRC Port: "
(number-to-string
(or (plist-get server-plist 'port)
--- 368,377 ----
(interactive "P")
(if arg
(let* ((server (completing-read "IRC Server: "
! rcirc-server-alist
nil nil
! (caar rcirc-server-alist)))
! (server-plist (cdr (assoc-string server rcirc-server-alist)))
(port (read-string "IRC Port: "
(number-to-string
(or (plist-get server-plist 'port)
***************
*** 362,380 ****
" "))
"[, ]+" t)))
(rcirc-connect server port nick rcirc-default-user-name
! rcirc-default-user-full-name
channels))
! ;; connect to servers in `rcirc-connections'
(let (connected-servers)
! (dolist (c rcirc-connections)
(let ((server (car c))
! (port (or (plist-get (cdr c) 'port) rcirc-default-port))
! (nick (or (plist-get (cdr c) 'nick) rcirc-default-nick))
! (user-name (or (plist-get (cdr c) 'user-name)
rcirc-default-user-name))
! (full-name (or (plist-get (cdr c) 'full-name)
! rcirc-default-user-full-name))
! (channels (plist-get (cdr c) 'channels)))
(when server
(let (connected)
(dolist (p (rcirc-process-list))
--- 387,405 ----
" "))
"[, ]+" t)))
(rcirc-connect server port nick rcirc-default-user-name
! rcirc-default-full-name
channels))
! ;; connect to servers in `rcirc-server-alist'
(let (connected-servers)
! (dolist (c rcirc-server-alist)
(let ((server (car c))
! (nick (or (plist-get (cdr c) :nick) rcirc-default-nick))
! (port (or (plist-get (cdr c) :port) rcirc-default-port))
! (user-name (or (plist-get (cdr c) :user-name)
rcirc-default-user-name))
! (full-name (or (plist-get (cdr c) :full-name)
! rcirc-default-full-name))
! (channels (plist-get (cdr c) :channels)))
(when server
(let (connected)
(dolist (p (rcirc-process-list))
***************
*** 423,429 ****
rcirc-default-port))
(nick (or nick rcirc-default-nick))
(user-name (or user-name rcirc-default-user-name))
! (full-name (or full-name rcirc-default-user-full-name))
(startup-channels startup-channels)
(process (make-network-process :name server :host server :service port-number)))
;; set up process
--- 448,454 ----
rcirc-default-port))
(nick (or nick rcirc-default-nick))
(user-name (or user-name rcirc-default-user-name))
! (full-name (or full-name rcirc-default-full-name))
(startup-channels startup-channels)
(process (make-network-process :name server :host server :service port-number)))
;; set up process
***************
*** 590,596 ****
process))))))
(defun rcirc-delete-process (process)
- (message "delete process %S" process)
(delete-process process))
(defvar rcirc-trap-errors-flag t)
--- 615,620 ----
***************
*** 1262,1272 ****
Format based on SENDER and RESPONSE. If ACTIVITY is non-nil,
record activity."
(or text (setq text ""))
! (unless (or (member sender rcirc-ignore-list)
! (member (with-syntax-table rcirc-nick-syntax-table
! (when (string-match "^\\([^/]\\w*\\)[:,]" text)
! (match-string 1 text)))
! rcirc-ignore-list))
(let* ((buffer (rcirc-target-buffer process sender response target text))
(inhibit-read-only t))
(with-current-buffer buffer
--- 1286,1297 ----
Format based on SENDER and RESPONSE. If ACTIVITY is non-nil,
record activity."
(or text (setq text ""))
! (unless (and (or (member sender rcirc-ignore-list)
! (member (with-syntax-table rcirc-nick-syntax-table
! (when (string-match "^\\([^/]\\w*\\)[:,]" text)
! (match-string 1 text)))
! rcirc-ignore-list))
! (not (string= sender (rcirc-nick process))))
(let* ((buffer (rcirc-target-buffer process sender response target text))
(inhibit-read-only t))
(with-current-buffer buffer
***************
*** 1635,1641 ****
(defun rcirc-clear-activity (buffer)
"Clear the BUFFER activity."
! (setq rcirc-activity (delete buffer rcirc-activity))
(with-current-buffer buffer
(setq rcirc-activity-types nil)))
--- 1660,1666 ----
(defun rcirc-clear-activity (buffer)
"Clear the BUFFER activity."
! (setq rcirc-activity (remove buffer rcirc-activity))
(with-current-buffer buffer
(setq rcirc-activity-types nil)))
next prev parent reply other threads:[~2007-06-28 9:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-09 5:21 rcirc update Ryan Yeske
2007-06-13 20:30 ` Chong Yidong
2007-06-13 21:17 ` Stefan Monnier
2007-06-16 3:02 ` Ryan Yeske
2007-06-16 3:58 ` Miles Bader
2007-06-16 5:08 ` Ryan Yeske
2007-06-16 21:26 ` Miles Bader
2007-06-17 23:33 ` Ryan Yeske
2007-06-20 19:53 ` Ryan Yeske
2007-06-28 9:51 ` Ryan Yeske [this message]
2007-06-29 0:54 ` Miles Bader
2007-06-29 7:34 ` Thien-Thi Nguyen
-- strict thread matches above, loose matches on Subject: below --
2009-10-02 0:11 Ryan Yeske
2009-10-15 6:50 ` Glenn Morris
2007-10-22 18:04 Ryan Yeske
2007-10-29 1:25 ` Glenn Morris
2007-10-31 5:21 ` Ryan Yeske
2007-11-01 4:04 ` Glenn Morris
2007-03-07 23:14 Ryan Yeske
2006-09-02 0:02 Ryan Yeske
2006-08-20 17:50 Ryan Yeske
2006-08-21 5:36 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878xa44dac.fsf@owie.lan \
--to=rcyeske@gmail.com \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.