From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.emacs.devel Subject: Re: 23.0.50; dbus Date: Wed, 02 Jan 2008 12:40:53 +0100 Message-ID: <878x38qwu2.fsf@ambire.localdomain> References: <87abod2b1x.fsf@gmx.de> <878x3umeo1.fsf@gmx.de> <87k5mufsl7.fsf@gmx.de> <87tzlwyfrr.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1199274181 24176 80.91.229.12 (2 Jan 2008 11:43:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Jan 2008 11:43:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 02 12:43:21 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JA20G-0006Sg-Ek for ged-emacs-devel@m.gmane.org; Wed, 02 Jan 2008 12:43:20 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JA1zu-0006hS-Fk for ged-emacs-devel@m.gmane.org; Wed, 02 Jan 2008 06:42:58 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JA1zh-0006ag-Fk for emacs-devel@gnu.org; Wed, 02 Jan 2008 06:42:45 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JA1zf-0006a1-S2 for emacs-devel@gnu.org; Wed, 02 Jan 2008 06:42:44 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JA1zf-0006Zw-HT for emacs-devel@gnu.org; Wed, 02 Jan 2008 06:42:43 -0500 Original-Received: from ppp-137-38.21-151.libero.it ([151.21.38.137] helo=ambire.localdomain) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JA1ze-0002tI-Vy for emacs-devel@gnu.org; Wed, 02 Jan 2008 06:42:43 -0500 Original-Received: from ttn by ambire.localdomain with local (Exim 4.63) (envelope-from ) id 1JA1xt-0001tF-Ay; Wed, 02 Jan 2008 12:40:53 +0100 In-Reply-To: <87tzlwyfrr.fsf@gmx.de> (Michael Albinus's message of "Wed, 02 Jan 2008 06:10:00 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85881 Archived-At: () Michael Albinus () Wed, 02 Jan 2008 06:10:00 +0100 Yes. But I still don't know what to do in the MacOS case, where tons of compiler warnings are raised due to the signedness of the SDATA return value. Peter has shown it in a recent message. Shall we always cast the type like "strlen ((char *) SDATA (uname))"? This would affect much more files but dbusbind.c. a quick scan of dbusbind.c shows these two cases: 1089: && (strlen (SDATA (service)) > 0) 1104: if (NILP (uname) || (strlen (SDATA (uname)) > 0)) i see in fns.c the following: DEFUN ("string-bytes", Fstring_bytes, Sstring_bytes, 1, 1, 0, doc: /* Return the number of bytes in STRING. If STRING is a multibyte string, this is greater than the length of STRING. */) (string) Lisp_Object string; { CHECK_STRING (string); return make_number (SBYTES (string)); } so i suggest using `SBYTES (uname)' directly instead of `strlen (SDATA (uname)) > 0'. thi