Re: 23.0.50; dbus

[Thien-Thi Nguyen <ttn@gnuvola.org>]

() Michael Albinus <michael.albinus@gmx.de>
() Wed, 02 Jan 2008 06:10:00 +0100

   Yes. But I still don't know what to do in the MacOS case,
   where tons of compiler warnings are raised due to the
   signedness of the SDATA return value. Peter has shown it
   in a recent message. Shall we always cast the type like
   "strlen ((char *) SDATA (uname))"? This would affect much
   more files but dbusbind.c.

a quick scan of dbusbind.c shows these two cases:

   1089:      && (strlen (SDATA (service)) > 0)
   1104:  if (NILP (uname) || (strlen (SDATA (uname)) > 0))

i see in fns.c the following:

  DEFUN ("string-bytes", Fstring_bytes, Sstring_bytes, 1, 1, 0,
         doc: /* Return the number of bytes in STRING.
  If STRING is a multibyte string, this is greater than the
  length of STRING.  */)
       (string)
       Lisp_Object string;
  {
    CHECK_STRING (string);
    return make_number (SBYTES (string));
  }
  
so i suggest using `SBYTES (uname)' directly
instead of `strlen (SDATA (uname)) > 0'.

thi