[richard_sharman@mitel.com: icalendar: icalendar-import-buffer when finds RDATE but no RRULE]

[richard_sharman@mitel.com: icalendar: icalendar-import-buffer when finds RDATE but no RRULE]

[Richard Stallman]

Would someone please DTRT and ack?  He does not say which version
he is using, so if you need to know that, please ask him.

------- Start of forwarded message -------
From: richard_sharman@mitel.com
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="FHL1W2vPLr"
Message-ID: <18357.56116.144190.918858@sharmanpc.mitel.com>
Date: Fri, 15 Feb 2008 13:34:28 -0500
To: ulf.jasper@web.de, bug-gnu-emacs@gnu.org
Cc: 
Subject: icalendar: icalendar-import-buffer when finds RDATE but no RRULE


- --FHL1W2vPLr
Content-Type: text/plain; charset=us-ascii
Content-Description: message body text
Content-Transfer-Encoding: 7bit

In function icalendar--format-ical-event,  in the inner `cond' function,
if the initial rrule condition is skipped but the second case - the rdate
one - is taken, then variable event-ok is not set to t.   So the function
then treats the event as invalid.

sharmanpc 10% diff -c icalendar.el{.orig,}
*** icalendar.el.orig	Fri Feb 15 13:19:58 2008
- --- icalendar.el	Fri Feb 15 13:20:04 2008
***************
*** 1641,1647 ****
                          (setq diary-string
                                (concat diary-string
                                        (format "......"))))
!                       (icalendar--split-value rdate)))
               ;; non-recurring event
               ;; all-day event
               ((not (string= start-d end-d))
- --- 1641,1648 ----
                          (setq diary-string
                                (concat diary-string
                                        (format "......"))))
!                       (icalendar--split-value rdate))
! 	      (setq event-ok t))
               ;; non-recurring event
               ;; all-day event
               ((not (string= start-d end-d))
sharmanpc 11% 


Here is the patch as a file in case this helps, and a file
to demonstrate the problem.  


- --FHL1W2vPLr
Content-Type: application/octet-stream
Content-Disposition: attachment;
	filename="Patch-3300"
Content-Transfer-Encoding: base64

KioqIFU6L1N5c3RlbS92eEltYWdlcy92eEltZ3g4Nl9BdGxhcy92eEltZ3g4Nl9BdGxhc19TcmMv
TU4zMzAwX3ZlcnNpb24uYwlUaHUgTm92ICAyIDExOjM5OjQ1IDIwMDYKLS0tIFN5c3RlbS92eElt
YWdlcy92eEltZ3g4Nl9BdGxhcy92eEltZ3g4Nl9BdGxhc19TcmMvTU4zMzAwX3ZlcnNpb24uYwlU
aHUgT2N0IDI1IDE2OjM2OjE4IDIwMDcKKioqKioqKioqKioqKioqCioqKiAxLDQwICoqKioKISAv
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqCiEgLy8gTU4zMzAwX1ZFUlNJT04uQwohIC8vIFRoaXMgZmlsZSBnZXRzIHVwZGF0ZWQg
YXQgYnVpbGQgdGltZSB3aXRoIHRoZSBjb3JyZWN0IGJ1aWxkCiEgLy8gdmVyc2lvbiwgYW5kIHRo
ZSBidWlsZCBkYXRlL3RpbWUgYnkgdGhlIENNIGdyb3VwCiEgLy8gQ3JlYXRlZCBieTogQ2VjaWxp
YSBTaWx2YQohIC8vIE1heSAxNiwgMjAwMQohICoqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKiovCiEgCiEgI2luY2x1ZGUgInZ4V29y
a3MuaCIKISAjaW5jbHVkZSAiTU4zMzAwX3ZlcnNpb24uaCIKISAKISAjZGVmaW5lIFZFUlNJT05U
QUcocykgU1RSSU5HSUZZKHMpCiEgI2RlZmluZSBTVFJJTkdJRlkocykgI3MKISAKISAKISAKISAK
ISB2b2lkIG1uMzMwMF9pY3Aodm9pZCkKISB7CiEgCXByaW50ZigiTWl0ZWwgTmV0d29ya3MgSW1h
Z2UgQnVpbGQgVmVyc2lvbiAlcyBcbiIsIFZFUlNJT05UQUcgKElNR1ZFUlNJT04pKTsKISB9CiEg
CiEgLyogKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKiog
Ki8KISAvKiBnZXRfbW4zMzAwX2ljcDogR2V0IHRoZSBjdXJyZW50IG1haW4gbG9hZCB2ZXJzaW9u
ICAqLwohIC8qICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICovCiEgLyogUkVUVVJOUzogT0sgICAgIGlmIHBhc3NlZCAgICAgICAgICAgICAgICAgICAg
ICAgICAgKi8KISAvKiAgICAgICAgICBFUlJPUiAgaWYgbGVuIDwgMTYgICAgICAgICAgICAgICAg
ICAgICAgICAqLwohIC8qICoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqICovCiEgCiEgU1RBVFVTIGdldF9tbjMzMDBfaWNwKHVuc2lnbmVkIGNoYXIgKnZl
cnNpb24sIGludCBsZW4pCiEgewohICAgIC8qIFJlY29tbWVuZCB0aGUgbGVuIHNpemUgaXMgYXQg
bGVhc3QgMTYgKi8KISAgICBpZihsZW4gPCBzdHJsZW4oVkVSU0lPTlRBRyAoSU1HVkVSU0lPTikp
KQohICAgICAgIHJldHVybihFUlJPUik7CiEgCiEgICAgc3RyY3B5KHZlcnNpb24sIFZFUlNJT05U
QUcgKElNR1ZFUlNJT04pKTsKISAKISAgICByZXR1cm4oT0spOwohIAohIH0KXCBObyBuZXdsaW5l
IGF0IGVuZCBvZiBmaWxlCi0tLSAxLDQwIC0tLS0KISAvKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqCiEgLy8gTU4zMzAwX1ZFUlNJ
T04uQwohIC8vIFRoaXMgZmlsZSBnZXRzIHVwZGF0ZWQgYXQgYnVpbGQgdGltZSB3aXRoIHRoZSBj
b3JyZWN0IGJ1aWxkCiEgLy8gdmVyc2lvbiwgYW5kIHRoZSBidWlsZCBkYXRlL3RpbWUgYnkgdGhl
IENNIGdyb3VwCiEgLy8gQ3JlYXRlZCBieTogQ2VjaWxpYSBTaWx2YQohIC8vIE1heSAxNiwgMjAw
MQohICoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKiovCiEgI2luY2x1ZGUgImltZ3ZlcnNpb24uaCIKISAjaW5jbHVkZSAidnhXb3Jr
cy5oIgohICNpbmNsdWRlICJNTjMzMDBfdmVyc2lvbi5oIgohIAohICNkZWZpbmUgVkVSU0lPTlRB
RyhzKSBTVFJJTkdJRlkocykKISAjZGVmaW5lIFNUUklOR0lGWShzKSAjcwohIAohIAohIAohIAoh
IHZvaWQgbW4zMzAwX2ljcCh2b2lkKQohIHsKISAJcHJpbnRmKCJNaXRlbCBOZXR3b3JrcyBJbWFn
ZSBCdWlsZCBWZXJzaW9uICVzIFxuIiwgVkVSU0lPTlRBRyAoSU1HVkVSU0lPTikpOwohIH0KISAK
ISAvKiAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKiAq
LwohIC8qIGdldF9tbjMzMDBfaWNwOiBHZXQgdGhlIGN1cnJlbnQgbWFpbiBsb2FkIHZlcnNpb24g
ICovCiEgLyogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgKi8KISAvKiBSRVRVUk5TOiBPSyAgICAgaWYgcGFzc2VkICAgICAgICAgICAgICAgICAgICAg
ICAgICAqLwohIC8qICAgICAgICAgIEVSUk9SICBpZiBsZW4gPCAxNiAgICAgICAgICAgICAgICAg
ICAgICAgICovCiEgLyogKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKiogKi8KISAKISBTVEFUVVMgZ2V0X21uMzMwMF9pY3AodW5zaWduZWQgY2hhciAqdmVy
c2lvbiwgaW50IGxlbikKISB7CiEgICAgLyogUmVjb21tZW5kIHRoZSBsZW4gc2l6ZSBpcyBhdCBs
ZWFzdCAxNiAqLwohICAgIGlmKGxlbiA8IHN0cmxlbihWRVJTSU9OVEFHIChJTUdWRVJTSU9OKSkp
CiEgICAgICAgcmV0dXJuKEVSUk9SKTsKISAKISAgICBzdHJjcHkodmVyc2lvbiwgVkVSU0lPTlRB
RyAoSU1HVkVSU0lPTikpOwohIAohICAgIHJldHVybihPSyk7CiEgCiEgfQoqKiogVTovU3lzdGVt
L3Z4SW1hZ2VzL3Z4SW1nODI2MFJUQy92eEltZzgyNjBSVENfU3JjL01OMzMwMF92ZXJzaW9uLmMJ
V2VkIE1hciAxMCAxMDoxODoxMSAyMDA0Ci0tLSBTeXN0ZW0vdnhJbWFnZXMvdnhJbWc4MjYwUlRD
L3Z4SW1nODI2MFJUQ19TcmMvTU4zMzAwX3ZlcnNpb24uYwlUaHUgT2N0IDI1IDE2OjM2OjE4IDIw
MDcKKioqKioqKioqKioqKioqCioqKiAxLDQwICoqKioKISAvKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqCiEgLy8gTU4zMzAwX1ZF
UlNJT04uQwohIC8vIFRoaXMgZmlsZSBnZXRzIHVwZGF0ZWQgYXQgYnVpbGQgdGltZSB3aXRoIHRo
ZSBjb3JyZWN0IGJ1aWxkCiEgLy8gdmVyc2lvbiwgYW5kIHRoZSBidWlsZCBkYXRlL3RpbWUgYnkg
dGhlIENNIGdyb3VwCiEgLy8gQ3JlYXRlZCBieTogQ2VjaWxpYSBTaWx2YQohIC8vIE1heSAxNiwg
MjAwMQohICoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKiovCiEgCiEgI2luY2x1ZGUgInZ4V29ya3MuaCIKISAjaW5jbHVkZSAiTU4z
MzAwX3ZlcnNpb24uaCIKISAKISAjZGVmaW5lIFZFUlNJT05UQUcocykgU1RSSU5HSUZZKHMpCiEg
I2RlZmluZSBTVFJJTkdJRlkocykgI3MKISAKISAKISAKISAKISB2b2lkIG1uMzMwMF9pY3Aodm9p
ZCkKISB7CiEgCXByaW50ZigiTWl0ZWwgTmV0d29ya3MgSW1hZ2UgQnVpbGQgVmVyc2lvbiAlcyBc
biIsIFZFUlNJT05UQUcgKElNR1ZFUlNJT04pKTsKISB9CiEgCiEgLyogKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKiogKi8KISAvKiBnZXRfbW4zMzAwX2lj
cDogR2V0IHRoZSBjdXJyZW50IG1haW4gbG9hZCB2ZXJzaW9uICAqLwohIC8qICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICovCiEgLyogUkVUVVJOUzog
T0sgICAgIGlmIHBhc3NlZCAgICAgICAgICAgICAgICAgICAgICAgICAgKi8KISAvKiAgICAgICAg
ICBFUlJPUiAgaWYgbGVuIDwgMTYgICAgICAgICAgICAgICAgICAgICAgICAqLwohIC8qICoqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqICovCiEgCiEgU1RB
VFVTIGdldF9tbjMzMDBfaWNwKHVuc2lnbmVkIGNoYXIgKnZlcnNpb24sIGludCBsZW4pCiEgewoh
ICAgIC8qIFJlY29tbWVuZCB0aGUgbGVuIHNpemUgaXMgYXQgbGVhc3QgMTYgKi8KISAgICBpZihs
ZW4gPCBzdHJsZW4oVkVSU0lPTlRBRyAoSU1HVkVSU0lPTikpKQohICAgICAgIHJldHVybihFUlJP
Uik7CiEgCiEgICAgc3RyY3B5KHZlcnNpb24sIFZFUlNJT05UQUcgKElNR1ZFUlNJT04pKTsKISAK
ISAgICByZXR1cm4oT0spOwohIAohIH0KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCi0tLSAx
LDQwIC0tLS0KISAvKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqCiEgLy8gTU4zMzAwX1ZFUlNJT04uQwohIC8vIFRoaXMgZmlsZSBn
ZXRzIHVwZGF0ZWQgYXQgYnVpbGQgdGltZSB3aXRoIHRoZSBjb3JyZWN0IGJ1aWxkCiEgLy8gdmVy
c2lvbiwgYW5kIHRoZSBidWlsZCBkYXRlL3RpbWUgYnkgdGhlIENNIGdyb3VwCiEgLy8gQ3JlYXRl
ZCBieTogQ2VjaWxpYSBTaWx2YQohIC8vIE1heSAxNiwgMjAwMQohICoqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKiovCiEgI2luY2x1
ZGUgImltZ3ZlcnNpb24uaCIKISAjaW5jbHVkZSAidnhXb3Jrcy5oIgohICNpbmNsdWRlICJNTjMz
MDBfdmVyc2lvbi5oIgohIAohICNkZWZpbmUgVkVSU0lPTlRBRyhzKSBTVFJJTkdJRlkocykKISAj
ZGVmaW5lIFNUUklOR0lGWShzKSAjcwohIAohIAohIAohIAohIHZvaWQgbW4zMzAwX2ljcCh2b2lk
KQohIHsKISAJcHJpbnRmKCJNaXRlbCBOZXR3b3JrcyBJbWFnZSBCdWlsZCBWZXJzaW9uICVzIFxu
IiwgVkVSU0lPTlRBRyAoSU1HVkVSU0lPTikpOwohIH0KISAKISAvKiAqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKiAqLwohIC8qIGdldF9tbjMzMDBfaWNw
OiBHZXQgdGhlIGN1cnJlbnQgbWFpbiBsb2FkIHZlcnNpb24gICovCiEgLyogICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKi8KISAvKiBSRVRVUk5TOiBP
SyAgICAgaWYgcGFzc2VkICAgICAgICAgICAgICAgICAgICAgICAgICAqLwohIC8qICAgICAgICAg
IEVSUk9SICBpZiBsZW4gPCAxNiAgICAgICAgICAgICAgICAgICAgICAgICovCiEgLyogKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKiogKi8KISAKISBTVEFU
VVMgZ2V0X21uMzMwMF9pY3AodW5zaWduZWQgY2hhciAqdmVyc2lvbiwgaW50IGxlbikKISB7CiEg
ICAgLyogUmVjb21tZW5kIHRoZSBsZW4gc2l6ZSBpcyBhdCBsZWFzdCAxNiAqLwohICAgIGlmKGxl
biA8IHN0cmxlbihWRVJTSU9OVEFHIChJTUdWRVJTSU9OKSkpCiEgICAgICAgcmV0dXJuKEVSUk9S
KTsKISAKISAgICBzdHJjcHkodmVyc2lvbiwgVkVSU0lPTlRBRyAoSU1HVkVSU0lPTikpOwohIAoh
ICAgIHJldHVybihPSyk7CiEgCiEgfQoqKiogVTovU3lzdGVtL3Z4SW1hZ2VzL3Z4SW1nODI2MEUy
VC92eEltZzgyNjBFMlRfU3JjL01OMzMwMF92ZXJzaW9uLmMJV2VkIE1hciAxMCAxMDoxODoxMSAy
MDA0Ci0tLSBTeXN0ZW0vdnhJbWFnZXMvdnhJbWc4MjYwRTJUL3Z4SW1nODI2MEUyVF9TcmMvTU4z
MzAwX3ZlcnNpb24uYwlUaHUgT2N0IDI1IDE2OjM2OjE4IDIwMDcKKioqKioqKioqKioqKioqCioq
KiAxLDQwICoqKioKISAvKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqCiEgLy8gTU4zMzAwX1ZFUlNJT04uQwohIC8vIFRoaXMgZmls
ZSBnZXRzIHVwZGF0ZWQgYXQgYnVpbGQgdGltZSB3aXRoIHRoZSBjb3JyZWN0IGJ1aWxkCiEgLy8g
dmVyc2lvbiwgYW5kIHRoZSBidWlsZCBkYXRlL3RpbWUgYnkgdGhlIENNIGdyb3VwCiEgLy8gQ3Jl
YXRlZCBieTogQ2VjaWxpYSBTaWx2YQohIC8vIE1heSAxNiwgMjAwMQohICoqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKiovCiEgCiEg
I2luY2x1ZGUgInZ4V29ya3MuaCIKISAjaW5jbHVkZSAiTU4zMzAwX3ZlcnNpb24uaCIKISAKISAj
ZGVmaW5lIFZFUlNJT05UQUcocykgU1RSSU5HSUZZKHMpCiEgI2RlZmluZSBTVFJJTkdJRlkocykg
I3MKISAKISAKISAKISAKISB2b2lkIG1uMzMwMF9pY3Aodm9pZCkKISB7CiEgCXByaW50ZigiTWl0
ZWwgTmV0d29ya3MgSW1hZ2UgQnVpbGQgVmVyc2lvbiAlcyBcbiIsIFZFUlNJT05UQUcgKElNR1ZF
UlNJT04pKTsKISB9CiEgCiEgLyogKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKiogKi8KISAvKiBnZXRfbW4zMzAwX2ljcDogR2V0IHRoZSBjdXJyZW50IG1h
aW4gbG9hZCB2ZXJzaW9uICAqLwohIC8qICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICovCiEgLyogUkVUVVJOUzogT0sgICAgIGlmIHBhc3NlZCAgICAg
ICAgICAgICAgICAgICAgICAgICAgKi8KISAvKiAgICAgICAgICBFUlJPUiAgaWYgbGVuIDwgMTYg
ICAgICAgICAgICAgICAgICAgICAgICAqLwohIC8qICoqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqICovCiEgCiEgU1RBVFVTIGdldF9tbjMzMDBfaWNwKHVu
c2lnbmVkIGNoYXIgKnZlcnNpb24sIGludCBsZW4pCiEgewohICAgIC8qIFJlY29tbWVuZCB0aGUg
bGVuIHNpemUgaXMgYXQgbGVhc3QgMTYgKi8KISAgICBpZihsZW4gPCBzdHJsZW4oVkVSU0lPTlRB
RyAoSU1HVkVSU0lPTikpKQohICAgICAgIHJldHVybihFUlJPUik7CiEgCiEgICAgc3RyY3B5KHZl
cnNpb24sIFZFUlNJT05UQUcgKElNR1ZFUlNJT04pKTsKISAKISAgICByZXR1cm4oT0spOwohIAoh
IH0KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCi0tLSAxLDQwIC0tLS0KISAvKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqCiEg
Ly8gTU4zMzAwX1ZFUlNJT04uQwohIC8vIFRoaXMgZmlsZSBnZXRzIHVwZGF0ZWQgYXQgYnVpbGQg
dGltZSB3aXRoIHRoZSBjb3JyZWN0IGJ1aWxkCiEgLy8gdmVyc2lvbiwgYW5kIHRoZSBidWlsZCBk
YXRlL3RpbWUgYnkgdGhlIENNIGdyb3VwCiEgLy8gQ3JlYXRlZCBieTogQ2VjaWxpYSBTaWx2YQoh
IC8vIE1heSAxNiwgMjAwMQohICoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKiovCiEgI2luY2x1ZGUgImltZ3ZlcnNpb24uaCIKISAj
aW5jbHVkZSAidnhXb3Jrcy5oIgohICNpbmNsdWRlICJNTjMzMDBfdmVyc2lvbi5oIgohIAohICNk
ZWZpbmUgVkVSU0lPTlRBRyhzKSBTVFJJTkdJRlkocykKISAjZGVmaW5lIFNUUklOR0lGWShzKSAj
cwohIAohIAohIAohIAohIHZvaWQgbW4zMzAwX2ljcCh2b2lkKQohIHsKISAJcHJpbnRmKCJNaXRl
bCBOZXR3b3JrcyBJbWFnZSBCdWlsZCBWZXJzaW9uICVzIFxuIiwgVkVSU0lPTlRBRyAoSU1HVkVS
U0lPTikpOwohIH0KISAKISAvKiAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKiAqLwohIC8qIGdldF9tbjMzMDBfaWNwOiBHZXQgdGhlIGN1cnJlbnQgbWFp
biBsb2FkIHZlcnNpb24gICovCiEgLyogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgKi8KISAvKiBSRVRVUk5TOiBPSyAgICAgaWYgcGFzc2VkICAgICAg
ICAgICAgICAgICAgICAgICAgICAqLwohIC8qICAgICAgICAgIEVSUk9SICBpZiBsZW4gPCAxNiAg
ICAgICAgICAgICAgICAgICAgICAgICovCiEgLyogKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKiogKi8KISAKISBTVEFUVVMgZ2V0X21uMzMwMF9pY3AodW5z
aWduZWQgY2hhciAqdmVyc2lvbiwgaW50IGxlbikKISB7CiEgICAgLyogUmVjb21tZW5kIHRoZSBs
ZW4gc2l6ZSBpcyBhdCBsZWFzdCAxNiAqLwohICAgIGlmKGxlbiA8IHN0cmxlbihWRVJTSU9OVEFH
IChJTUdWRVJTSU9OKSkpCiEgICAgICAgcmV0dXJuKEVSUk9SKTsKISAKISAgICBzdHJjcHkodmVy
c2lvbiwgVkVSU0lPTlRBRyAoSU1HVkVSU0lPTikpOwohIAohICAgIHJldHVybihPSyk7CiEgCiEg
fQoqKiogVTovRVNNL0VTTV9JbmMvSVBPQy5oCU1vbiBOb3YgMjAgMTU6Mjk6MDYgMjAwNgotLS0g
RVNNL0VTTV9JbmMvSVBPQy5oCVRodSBPY3QgMjUgMTM6NTQ6MzEgMjAwNwoqKioqKioqKioqKioq
KioKKioqIDI3LDMyICoqKioKLS0tIDI3LDM1IC0tLS0KICAjaWZuZGVmIF9JUE9DXwogICNkZWZp
bmUgX0lQT0NfCiAgCisgI2RlZmluZSBJUE9QX0ZFQVRVUkVfVkVSU0lPTl9UQUcgMworICNkZWZp
bmUgTUlTWU5DX1JFTEVBU0VfU1RSSU5HICJcIjMzMDAtOC4wXCIiCisgCiAgdHlwZWRlZiBzdHJ1
Y3QgSVBPQ19MYXlvdXQxIHsKICAgICAgdW5zaWduZWQgaW50IFVzZXJfTGljZW5zZXM7IAogICAg
ICB1bnNpZ25lZCBpbnQgQUNEX0FnZW50X0xpY2Vuc2VzOwoqKiogdTovU3lzdGVtL3Z4SW1hZ2Vz
L0JTUF9BdGxhcy9CU1BfQXRsYXNfU3JjL2tlcm5lbEFNb2RzLnMJVGh1IE5vdiAgMiAxMTozOTo0
NSAyMDA2Ci0tLSBidWlsZC9TeXN0ZW0vdnhJbWFnZXMvQlNQX0F0bGFzL0JTUF9BdGxhc19TcmMv
a2VybmVsQU1vZHMucwlUdWUgT2N0IDIzIDEyOjM4OjIyIDIwMDcKKioqKioqKioqKioqKioqCioq
KiAzNjEsMzY4ICoqKioKICAvKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqLwogIC8qIHNlbUFMaWIgbW9kcyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICovCiAgCiEgCS5nbG9iYWwJc2VtR2l2ZQohIAkuZ2xvYmFsCXNlbVRha2UKICAJLmdsb2JhbAlz
ZW1CR2l2ZQogIAkuZ2xvYmFsCXNlbUJUYWtlCiAgCS5nbG9iYWwJc2VtUUdldAotLS0gMzYxLDM2
OCAtLS0tCiAgLyoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKi8KICAvKiBzZW1BTGliIG1vZHMgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAqLwogIAoh
IAkuZ2xvYmFsCXZ4V29ya3Nfc2VtR2l2ZQohIAkuZ2xvYmFsCXZ4V29ya3Nfc2VtVGFrZQogIAku
Z2xvYmFsCXNlbUJHaXZlCiAgCS5nbG9iYWwJc2VtQlRha2UKICAJLmdsb2JhbAlzZW1RR2V0Cioq
KioqKioqKioqKioqKgoqKiogMzc5LDM4NSAqKioqCiAgCWNhbGwJCXNreUhvb2tfcG9wZiAgIAog
IAlyZXQgICAgCiAgCiEgc2VtR2l2ZToKICAJbW92CQkweDQoJWVzcCksJWVjeAogIAl0ZXN0CQkk
MHgxLCVlY3gKICAJam5lCQlfc2VtR2l2ZUdsb2JhbAotLS0gMzc5LDM4NSAtLS0tCiAgCWNhbGwJ
CXNreUhvb2tfcG9wZiAgIAogIAlyZXQgICAgCiAgCiEgdnhXb3Jrc19zZW1HaXZlOgogIAltb3YJ
CTB4NCglZXNwKSwlZWN4CiAgCXRlc3QJCSQweDEsJWVjeAogIAlqbmUJCV9zZW1HaXZlR2xvYmFs
CioqKioqKioqKioqKioqKgoqKiogNTM3LDU0MyAqKioqCiAgX3NlbUlzSW52YWxpZDoKICAJam1w
CQlzZW1JbnZhbGlkCiAgCiEgc2VtVGFrZToKICAJbW92CQkweDQoJWVzcCksJWVjeAogIAl0ZXN0
CQkkMHgxLCVlY3gKICAJam5lCQlfc2VtVGFrZUdsb2JhbAotLS0gNTM3LDU0MyAtLS0tCiAgX3Nl
bUlzSW52YWxpZDoKICAJam1wCQlzZW1JbnZhbGlkCiAgCiEgdnhXb3Jrc19zZW1UYWtlOgogIAlt
b3YJCTB4NCglZXNwKSwlZWN4CiAgCXRlc3QJCSQweDEsJWVjeAogIAlqbmUJCV9zZW1UYWtlR2xv
YmFsCioqKioqKioqKioqKioqKgoqKiogNzU5LDc2NSAqKioqCiAgCWNhbGwJCSolZWF4CiAgCWFk
ZAkJJDB4NCwlZXNwCiAgCW1vdgkJJWVheCwweDgoJWVzcCkKISAJam1wCQlzZW1UYWtlCiAgCiAg
c2VtT1Rha2U6CiAgCXB1c2gJCSQweGZmZmZmZmZmCi0tLSA3NTksNzY1IC0tLS0KICAJY2FsbAkJ
KiVlYXgKICAJYWRkCQkkMHg0LCVlc3AKICAJbW92CQklZWF4LDB4OCglZXNwKQohIAlqbXAJCXZ4
V29ya3Nfc2VtVGFrZQogIAogIHNlbU9UYWtlOgogIAlwdXNoCQkkMHhmZmZmZmZmZgoqKioqKioq
KioqKioqKioKKioqIDEwMDAsMTAwNiAqKioqCiAgCWNhbGwJCSolZWF4CiAgCWFkZGwJCSQweDQs
JWVzcAogIAltb3ZsCQklZWF4LDB4OCglZXNwLDEpCiEgCWptcAkJc2VtVGFrZQogIAogIAogIAot
LS0gMTAwMCwxMDA2IC0tLS0KICAJY2FsbAkJKiVlYXgKICAJYWRkbAkJJDB4NCwlZXNwCiAgCW1v
dmwJCSVlYXgsMHg4KCVlc3AsMSkKISAJam1wCQl2eFdvcmtzX3NlbVRha2UKICAKICAKICAK
- --FHL1W2vPLr
Content-Type: application/octet-stream
Content-Description: vcalendar file to demonstrate the problem
Content-Disposition: attachment;
	filename="test.ics"
Content-Transfer-Encoding: base64

QkVHSU46VkNBTEVOREFSClgtTE9UVVMtQ0hBUlNFVDpVVEYtOApWRVJTSU9OOjIuMApQUk9ESUQ6
LS8vTG90dXMgRGV2ZWxvcG1lbnQgQ29ycG9yYXRpb24vL05PTlNHTUwgTm90ZXMgNi4wLy9FTgpN
RVRIT0Q6UkVRVUVTVApCRUdJTjpWVElNRVpPTkUKVFpJRDpFYXN0ZXJuCkJFR0lOOlNUQU5EQVJE
CkRUU1RBUlQ6MTk1MDExMDVUMDIwMDAwClRaT0ZGU0VURlJPTTotMDQwMApUWk9GRlNFVFRPOi0w
NTAwClJSVUxFOkZSRVE9WUVBUkxZO0JZTUlOVVRFPTA7QllIT1VSPTI7QllEQVk9MVNVO0JZTU9O
VEg9MTEKRU5EOlNUQU5EQVJECkJFR0lOOkRBWUxJR0hUCkRUU1RBUlQ6MTk1MDAzMTJUMDIwMDAw
ClRaT0ZGU0VURlJPTTotMDUwMApUWk9GRlNFVFRPOi0wNDAwClJSVUxFOkZSRVE9WUVBUkxZO0JZ
TUlOVVRFPTA7QllIT1VSPTI7QllEQVk9MlNVO0JZTU9OVEg9MwpFTkQ6REFZTElHSFQKRU5EOlZU
SU1FWk9ORQpCRUdJTjpWRVZFTlQKRFRTVEFSVDtUWklEPSJFYXN0ZXJuIjoyMDA4MDIxNVQxNDMw
MDAKRFRFTkQ7VFpJRD0iRWFzdGVybiI6MjAwODAyMTVUMTUwMDAwClRSQU5TUDpPUEFRVUUKUkRB
VEU7VFpJRD0iRWFzdGVybiI7VkFMVUU9UEVSSU9EOjIwMDgwMjE1VDE0MzAwMC8yMDA4MDIxNVQx
NTAwMDAKUkVDVVJSRU5DRS1JRDoyMDA4MDIxNVQxOTAwMDBaClgtTE9UVVMtUkVDVVJJRDoyMDA4
MDIxNVQxOTAwMDBaClgtTE9UVVMtTEFTVEFMTC1SREFURVM7VFpJRD0iRWFzdGVybiI6MjAwODAx
MThUMTMzMDAwLDIwMDgwMjE1VDE0MzAwMCwKIDIwMDgwMzIxVDEzMzAwMCwyMDA4MDQxOFQxMzMw
MDAsMjAwODA1MTZUMTMzMDAwLDIwMDgwNjIwVDEzMzAwMAogLDIwMDgwNzE4VDEzMzAwMCwyMDA4
MDgxNVQxMzMwMDAsMjAwODA5MTlUMTMzMDAwLDIwMDgxMDE3VDEzMzAwMApYLUxPVFVTLUNIQU5H
RS1JTlNULURBVEVTOjIwMDgwMjE1VDE5MDAwMFoKWC1MT1RVUy1JTklUSUFMLVJEQVRFUzoyMDA4
MDExOFQxOTAwMDBaLDIwMDgwMjE1VDE5MDAwMFoKICwyMDA4MDMyMVQxODAwMDBaLDIwMDgwNDE4
VDE4MDAwMFosMjAwODA1MTZUMTgwMDAwWiwyMDA4MDYyMFQxODAwMDBaCiAsMjAwODA3MThUMTgw
MDAwWiwyMDA4MDgxNVQxODAwMDBaLDIwMDgwOTE5VDE4MDAwMFosMjAwODEwMTdUMTgwMDAwWgpE
VFNUQU1QOjIwMDgwMjE0VDE3NDQzN1oKQ09NTUVOVDp0aGUgY29tbWVudCBoYXMgYmVlbiByZW1v
dmVkClNFUVVFTkNFOjMKQVRURU5ERUU7Uk9MRT1SRVEtUEFSVElDSVBBTlQ7UEFSVFNUQVQ9TkVF
RFMtQUNUSU9OO1JTVlA9VFJVRQogOm1haWx0bzpyaWNoYXJkX3NoYXJtYW5ATWl0ZWwuQ09NCkNM
QVNTOlBVQkxJQwpERVNDUklQVElPTjpBZ2VuZGFcbnJlbW92ZWQgZnJvbSB0aGlzIGV4YW1wbGUK
U1VNTUFSWTpyZW1vdmVkIGFnYWluCk9SR0FOSVpFUjtDTj0idW5kaXNjbG9kZXMiOm1haWx0bzpz
b21lb25lQGhlcmUuY29tClVJRDo1QzY1MDE5NUMzNTkyMTcyODUyNTczQjYwMDc5OTgzRS1Mb3R1
c19Ob3Rlc19HZW5lcmF0ZWQKWC1MT1RVUy1CUk9BRENBU1Q6RkFMU0UKWC1MT1RVUy1VUERBVEUt
U0VROjEKWC1MT1RVUy1VUERBVEUtV0lTTDokUzoxOyRMOjE7JEI6MTskRToxOyRSOjMKWC1MT1RV
Uy1PUklHU1RBUlQ7VFpJRD0iRWFzdGVybiI6MjAwODAyMTVUMTQzMDAwClgtTE9UVVMtT1JJR0VO
RDtUWklEPSJFYXN0ZXJuIjoyMDA4MDIxNVQxNjAwMDAKWC1MT1RVUy1TVEFSVDtUWklEPSJFYXN0
ZXJuIjoyMDA4MDIxNVQxNDMwMDAKWC1MT1RVUy1FTkQ7VFpJRD0iRWFzdGVybiI6MjAwODAyMTVU
MTUwMDAwClgtTE9UVVMtTk9URVNWRVJTSU9OOjIKWC1MT1RVUy1OT1RJQ0VUWVBFOlUKWC1MT1RV
Uy1DSElMRF9VSUQ6N0FCQzUyRjk1NjM2QjZDQjg1MjU3M0VGMDA2MEZBRDYKRU5EOlZFVkVOVApF
TkQ6VkNBTEVOREFSCg==
- --FHL1W2vPLr
Content-Type: text/plain; charset=us-ascii
Content-Description: message body text
Content-Transfer-Encoding: 7bit


Richard


- --FHL1W2vPLr--
------- End of forwarded message -------

Re: [richard_sharman@mitel.com: icalendar: icalendar-import-buffer when finds RDATE but no RRULE]

[Ulf Jasper]

Richard Stallman <rms@gnu.org> writes:
> Would someone please DTRT and ack?  He does not say which version
> he is using, so if you need to know that, please ask him.

This is what I wrote to bug-gnu-emacs:

> Date: Sat, 16 Feb 2008 18:38:56 +0100
> From: Ulf Jasper <ulf.jasper@web.de>
> Subject: Re: icalendar: icalendar-import-buffer when finds RDATE but
> 	no RRULE
> To: richard_sharman@mitel.com
> Cc: bug-gnu-emacs@gnu.org
>
> richard_sharman@mitel.com writes:
>> In function icalendar--format-ical-event,  in the inner `cond' function,
>
> That is icalendar--convert-ical-to-diary.
>
>> if the initial rrule condition is skipped but the second case - the rdate
>> one - is taken, then variable event-ok is not set to t.   So the function
>> then treats the event as invalid.
>
> Simply setting event-ok to t is not enough. The RDATE handling is just
> missing so that by setting event-ok to t diary entries are created that
> are missing start and end time. I just started to implement the RDATE
> stuff.
>
> Thanks for pointing out and thanks for the example! (BTW you attached
> the wrong patch file.)

-- 
HOME UNTERNEHMEN DERIVATE ROHSTOFFE EXPERTEN DEVISEN KONJUNKTUR FONDS