From: Juri Linkov <juri@jurta.org>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: emacs-devel@gnu.org
Subject: Re: add INVERT to re-search-{forward, backward} (was: occur API change proposal)
Date: Mon, 25 Aug 2008 18:45:18 +0300 [thread overview]
Message-ID: <878wumj8zx.fsf@jurta.org> (raw)
In-Reply-To: <86myjrl2jz.fsf_-_@lifelogs.com> (Ted Zlatanov's message of "Tue, 05 Aug 2008 13:49:52 -0500")
>>> I propose changing the occur API to allow an optional predicate
>>> function. For example, this is useful to invert a regular expression so
>>> you don't have to run occur on the whole buffer matching everything,
>>> then limit the results.
>
> JL> The occur engine currently hard-codes the function call of
> JL> `re-search-forward'. Instead of this, we could do the same
> JL> as is done already in isearch for customization of the search
> JL> function using a variable `isearch-search-fun-function', and
> JL> add a new analogous variable `occur-fun-function'.
>
> JL> Even though such a variable will be useful for other purposes,
> JL> no simple function will allow inverting a regular expression.
> JL> Implementing this feature requires significant modification in
> JL> the logic of the occur engine: either changing the algorithm to
> JL> call `looking-at' at every line (very inefficient), or recording
> JL> a position of the previous match and outputing lines between it
> JL> and the current position (not easy to customize).
>
> After thinking about this (yes, it sat in my TODO queue for a while) I
> realize the problem is fundamental: Emacs doesn't have a way to invert
> at the re-search-{forward,backward} API level. There's no way to
> automatically invert a regular expression into another regular
> expression, so this change must happen at the API level to avoid
> unpleasant workarounds as Juri describes.
>
> I propose simply adding an optional INVERT parameter to those two
> functions. The API cost is small with an optional parameter, though I
> don't know if performance will be affected by the extra check on every
> search cycle.
>
> Once this API is in place, making the change in occur-mode and other
> places to use the new API is very easy.
It seems such an API with a new INVERT parameter will be useless
because these two character-based search functions will find too much
matches. For example, calling it with the parameter "def" on the string
"abcdefghi" will match in it 6 places, i.e. everywhere except the
position under the character "d". Thus this will provide no useful
information to occur.
Instead of this, I think the change should be done at the occur level,
since occur's algorithm is line-based and can skip lines that contain
a given regexp. This could be similar to the algorithm used by the
command `flush-lines' in the same file. `occur' currently works like the
command `keep-lines' that keeps lines containing the specified regexp.
But with a new INVERT argument, `occur' could work like `flush-lines' that
keep everything except lines containing the specified regexp.
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2008-08-25 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 16:02 occur API change proposal Ted Zlatanov
2007-12-01 0:34 ` Juri Linkov
2008-08-05 18:49 ` add INVERT to re-search-{forward, backward} (was: occur API change proposal) Ted Zlatanov
2008-08-25 15:45 ` Juri Linkov [this message]
2008-08-25 15:57 ` add INVERT to re-search-{forward, backward} Lennart Borgman (gmail)
2008-08-25 19:45 ` Juri Linkov
2008-08-25 20:07 ` Lennart Borgman (gmail)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878wumj8zx.fsf@jurta.org \
--to=juri@jurta.org \
--cc=emacs-devel@gnu.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.