From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Lazy Isearch in dired Date: Thu, 13 Nov 2008 10:32:29 -0500 Message-ID: <878wrn4p6a.fsf@cyd.mit.edu> References: <87d4h5ew7x.fsf@jurta.org> <87fxlv4pa7.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1226590447 14512 80.91.229.12 (13 Nov 2008 15:34:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Nov 2008 15:34:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 13 16:35:07 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L0eDq-0001N5-U1 for ged-emacs-devel@m.gmane.org; Thu, 13 Nov 2008 16:35:07 +0100 Original-Received: from localhost ([127.0.0.1]:48241 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0eCi-0002P4-Tq for ged-emacs-devel@m.gmane.org; Thu, 13 Nov 2008 10:33:56 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0eB6-00021q-S6 for emacs-devel@gnu.org; Thu, 13 Nov 2008 10:32:16 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0eB6-00021X-Bw for emacs-devel@gnu.org; Thu, 13 Nov 2008 10:32:16 -0500 Original-Received: from [199.232.76.173] (port=52992 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0eB5-00021R-VN for emacs-devel@gnu.org; Thu, 13 Nov 2008 10:32:16 -0500 Original-Received: from cyd.mit.edu ([18.115.2.24]:49226) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L0eB6-0007zZ-2y for emacs-devel@gnu.org; Thu, 13 Nov 2008 10:32:16 -0500 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 2210E57E09E; Thu, 13 Nov 2008 10:32:29 -0500 (EST) In-Reply-To: <87fxlv4pa7.fsf@cyd.mit.edu> (Chong Yidong's message of "Thu, 13 Nov 2008 10:30:08 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105640 Archived-At: Chong Yidong writes: >> The following patch fixes this by using a loop like the loop in the >> function `isearch-search'. The docstring of isearch-lazy-highlight-search >> says: "Attempt to do the search exactly the way the pending isearch would.", >> so no changes in the docstring are needed, because this patch makes it >> more similar to the main search function. It also calls isearch-success-function >> to skip the matches outside the current Isearch scope. By default this >> function skips invisible matches that are useless for lazy highlighting. >> This also requires setting search-invisible to nil to not match >> invisible text. > > Hmm, your patch looks reasonable, but I'm not sure. Could it possibly > lead to slowdowns in some buffers from the additional search loop? > Maybe we should hold this till after the release. Ah, I see you already installed it. That's OK. Could you do some quick testing to make sure there isn't a slowdown? (e.g., try searching in a buffer in a way that generates lots of lazy highlights).