all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tassilo@member.fsf.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: Functions in kill-emacs-hook aren't run if emacs gets killed with	SIGTERM
Date: Thu, 22 Jan 2009 10:00:43 +0100	[thread overview]
Message-ID: <878wp367gk.fsf@thinkpad.tsdh.de> (raw)
In-Reply-To: <uk58ougl8.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 22 Jan 2009 06:09:39 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> > No.  Fatal signals, such as SIGTERM, are caught by a signal
>> > handler, which runs emacs.c:shut_down_emacs.  `kill-emacs' in a
>> > nutshell runs `kill-emacs-hook' and then also calls
>> > shut_down_emacs.
>> 
>> It would probably make sense to run kill-emacs-hook when we receive
>> SIGTERM, although it does imply a significant change (basically
>> handling SIGTERM similarly to SIGUSRn).
>
> SIGUSRn are different in that they are ``soft'', and are not generally
> expected to interrupt code in dangerous state.  The fact that SIGTERM
> in this case is a programmed means to stop Emacs does not mean it's
> the only use case where SIGTERM is delivered to Emacs.  We shouldn't
> IMO change code based just on this single use case.

Is SIGTERM really such a fatal signal as you say?  I always believed
SIGTERM meant "shutdown, but do it cleanly" whereas SIGKILL meant "Die!
Die! Die! NOW!".  That's the reason tools like init first send SIGTERM
to all apps when shutting down to give them a chance to do some
organizational stuff before exiting, and after some seconds they fire a
SIGKILL to apps which didn't obey.

Maybe it would be sensible to do the buffer saving first on SIGTERM, so
that we're in a hopefully save state, then run `kill-emacs-hook' and
finally shut down.  That would minimize the risk of a function in
`kill-emacs-hook' to cause any harm.

Bye,
Tassilo




  reply	other threads:[~2009-01-22  9:00 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21  8:06 Functions in kill-emacs-hook aren't run if emacs gets killed with SIGTERM Tassilo Horn
2009-01-21 18:42 ` Eli Zaretskii
2009-01-21 19:49   ` Tassilo Horn
2009-01-21 20:35     ` Chong Yidong
2009-01-22  9:03       ` Tassilo Horn
2009-01-21 20:36   ` Stefan Monnier
2009-01-22  4:09     ` Eli Zaretskii
2009-01-22  9:00       ` Tassilo Horn [this message]
2009-01-22 18:23         ` Eli Zaretskii
2009-01-23  2:15           ` mail
2009-01-23 12:05             ` Eli Zaretskii
2009-01-22 10:08       ` Andreas Schwab
2009-01-22 18:25         ` Eli Zaretskii
2009-01-23  1:52         ` Richard M Stallman
2009-01-22 14:41       ` Stefan Monnier
2009-01-22 18:32         ` Eli Zaretskii
2009-01-22 21:16           ` Stefan Monnier
2009-01-23 15:25             ` Eli Zaretskii
2009-01-23 15:58               ` Tassilo Horn
2009-01-23 19:06                 ` Eli Zaretskii
2009-01-23 19:56                   ` David De La Harpe Golden
2009-01-23 22:39                     ` Eli Zaretskii
2009-01-23 23:00                       ` Tassilo Horn
2009-01-23 23:13                         ` Lennart Borgman
2009-01-24  9:04                           ` Tassilo Horn
2009-01-24  9:59                             ` Eli Zaretskii
2009-01-24 12:34                               ` Miles Bader
2009-01-24 10:00                             ` Eli Zaretskii
2009-01-23 20:33                   ` Dan Nicolaescu
2009-01-23 22:37                     ` Eli Zaretskii
2009-01-24  4:40               ` Jason Rumney
2009-01-24  6:11                 ` Miles Bader
2009-01-23  1:52         ` Richard M Stallman
  -- strict thread matches above, loose matches on Subject: below --
2009-01-23 19:01 grischka
2009-01-23 22:52 ` Eli Zaretskii
2009-01-24 14:16   ` grischka
2009-01-24 16:14     ` Eli Zaretskii
2009-01-24 17:56       ` grischka
2009-01-24 18:20         ` Eli Zaretskii
2009-01-24 19:11           ` grischka
2009-01-24 20:08             ` Eli Zaretskii
2009-01-24 20:28               ` grischka
2009-01-24 20:32 Stefan Monnier
2009-02-02 20:23 ` Eli Zaretskii
2009-02-02 20:52   ` Tassilo Horn
2009-02-02 21:09     ` Eli Zaretskii
2009-02-03 10:43       ` Tassilo Horn
2009-02-05  3:34   ` Stefan Monnier
2009-01-24 20:39 Stefan Monnier
2009-02-03 17:28 grischka
2009-02-05  3:37 ` Stefan Monnier
2009-02-05 13:31   ` grischka
2009-02-05 19:40     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878wp367gk.fsf@thinkpad.tsdh.de \
    --to=tassilo@member.fsf.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.