From: Kevin Ryde <user42@zip.com.au>
To: control@emacsbugs.donarmstrong.com, 2631@emacsbugs.donarmstrong.com
Subject: bug#2631: get-free-disk-space when default-directory doesn't exist
Date: Sat, 28 Mar 2009 10:17:47 +1100 [thread overview]
Message-ID: <878wmqy2qs.fsf@blah.blah> (raw)
In-Reply-To: <877i2p9fu5.fsf@blah.blah> (Kevin Ryde's message of "Tue, 17 Mar 2009 11:02:26 +1100")
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
reopen 2631
retitle 2631 get-free-disk-space when home dir also doesn't exist
tags 2631 +patch
thanks
If both default-directory and home directory both don't exist
get-free-disk-space still gets an error
(progn
(setq default-directory "/no/such/dir")
(setenv "HOME" "/another/no/such/dir")
(get-free-disk-space "/"))
=> (file-error "Setting current directory" "no such file or directory" "/another/no/such/dir/")
Although plenty of things probably depend on a home dir I don't think
get-free-disk-space needs to be one of them.
Change below is like what's also in the following funcs, I believe for
the same purpose, ie. just to make sure call-process will be happy, when
the program run doesn't care about the current directory.
Man-init-defvars,
mail-source-movemail
message-send-mail-with-sendmail
sendmail-send-it
gamegrid-add-score-with-update-game-score-1
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: files.el.disk-space-root.diff --]
[-- Type: text/x-diff, Size: 1202 bytes --]
*** files.el 28 Mar 2009 09:50:47 +1100 1.1041
--- files.el 28 Mar 2009 09:56:48 +1100
***************
*** 5336,5352 ****
(save-match-data
(with-temp-buffer
(when (and directory-free-space-program
! (let ((default-directory
! (if (and (not (file-remote-p default-directory))
! (file-directory-p default-directory)
! (file-readable-p default-directory))
! default-directory
! (expand-file-name "~/"))))
! (eq (call-process directory-free-space-program
! nil t nil
! directory-free-space-args
! dir)
! 0)))
;; Usual format is a header line followed by a line of
;; numbers.
(goto-char (point-min))
--- 5336,5349 ----
(save-match-data
(with-temp-buffer
(when (and directory-free-space-program
! (progn
! (setq dir (expand-file-name dir)) ;; in case relative
! (let ((default-directory "/"))
! (eq (call-process directory-free-space-program
! nil t nil
! directory-free-space-args
! dir)
! 0))))
;; Usual format is a header line followed by a line of
;; numbers.
(goto-char (point-min))
next prev parent reply other threads:[~2009-03-27 23:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87d4cjzf89.fsf@cyd.mit.edu>
2009-03-10 22:24 ` bug#2631: get-free-disk-space when default-directory doesn't exist Kevin Ryde
2009-03-11 2:10 ` Stefan Monnier
2009-03-11 4:23 ` Eli Zaretskii
2009-03-11 21:00 ` Kevin Ryde
2009-03-15 2:40 ` bug#2631: marked as done (get-free-disk-space when default-directory doesn't exist) Emacs bug Tracking System
2009-08-16 0:40 ` bug#2631: marked as done (get-free-disk-space when home dir also " Emacs bug Tracking System
2009-03-17 0:02 ` bug#2631: get-free-disk-space when default-directory doesn't exist Kevin Ryde
2009-03-17 4:05 ` Eli Zaretskii
2009-03-27 23:32 ` Kevin Ryde
2009-03-27 23:17 ` Kevin Ryde [this message]
2009-03-27 23:25 ` Processed: " Emacs bug Tracking System
[not found] <871vnclhoz.fsf@cyd.mit.edu>
2009-07-23 22:19 ` bug#3911: 23.1.50; get-free-disk-space relative to non-existent default-directory Kevin Ryde
2009-08-16 0:40 ` bug#3911: marked as done (23.1.50; get-free-disk-space relative to non-existent default-directory) Emacs bug Tracking System
2009-10-02 0:35 ` bug#3911: marked as done (get-free-disk-space race condition on default-directory test) Emacs bug Tracking System
2009-08-18 0:23 ` bug#3911: get-free-disk-space when default-directory doesn't exist Kevin Ryde
2009-08-18 1:02 ` Chong Yidong
2009-08-19 21:43 ` Kevin Ryde
2009-08-19 22:03 ` Kevin Ryde
2009-08-22 3:57 ` Stefan Monnier
2009-08-24 23:45 ` Kevin Ryde
2009-08-25 18:29 ` Stefan Monnier
2009-08-29 1:32 ` Kevin Ryde
2009-08-29 3:37 ` Stefan Monnier
2009-09-01 1:37 ` Kevin Ryde
2009-09-01 6:05 ` Stefan Monnier
2009-09-07 0:28 ` Kevin Ryde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878wmqy2qs.fsf@blah.blah \
--to=user42@zip.com.au \
--cc=2631@emacsbugs.donarmstrong.com \
--cc=control@emacsbugs.donarmstrong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.