abbrevs broken since 2009-11-19 03:12:51 +0000

abbrevs broken since 2009-11-19 03:12:51 +0000

[Giorgos Keramidas]

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

I pulled a new Emacs snapshot from the Git repository this morning and
noticed that typing a space in message-mode fails with a backtrace
similar to the one attached to this message.

Bisecting the changes since my last successful update I found out that
this is the first change that breaks abbrevs in message-mode:

: commit be11c6010ad352ebb93a7921f356a436a6d49f64
: Author: Stefan Monnier <monnier@cs.yale.edu>
: Date:   Thu Nov 19 03:12:51 2009 +0000
:
:     * abbrev.el (abbrev-with-wrapper-hook): (re)move...
:     * simple.el (with-wrapper-hook): ...to here.  Add argument `args'.
:     * minibuffer.el (completion-in-region-functions): New hook.
:     (completion-in-region): New function.
:     * emacs-lisp/lisp.el (lisp-complete-symbol):
:     * pcomplete.el (pcomplete-std-complete): Use it.

The backtrace is attached below, but it includes bytecode bits, so if it
doesn't help a lot, I'll try looking at the changes in a few minutes.


[-- Attachment #2: backtrace of abbrev expansion --]
[-- Type: text/plain, Size: 2231 bytes --]

Debugger entered--Lisp error: (wrong-number-of-arguments #[(G73706 funs global args) "\306\307!\306\310!\x18\211\x19
L\210\b\vL\210	J:\203HJ\v#\207" [G73705 G73704 G73703 args] 4] quote --cl-rest-- #[nil "\306 \211\x18\211A\x10@\x19\b\211A\x10@\x1a\b\211A\x10@^[\b\211A\x10@\x1c\b\203)\x16\x10	\x16\x11\v\x16\x12\316	
\v\f$)-\207" [--cl-rest-- sym name wordstart wordend value abbrev--before-point signal wrong-number-of-arguments nil 4 window-minibuffer-p selected-window undo-boundary abbrev-insert noninteractive last-abbrev-text last-abbrev last-abbrev-location] 6]] 11] 3)
  #[(G73706 funs global args) "\306\307!\306\310!\x18\211\x19\nL\210\b\vL\210	J:\203H  apply(#[(G73706 funs global args) "\306\307!\306\310!\x18\211\x19\nL\210\b\vL\210	J:\203H  (lambda (&rest --cl-rest--) (apply #[... "\306\307!\306\310!\x18\211\x19\nL\210\b\vL\210	J:\203H  apply((lambda (&rest --cl-rest--) (apply #[... "\306\307!\306\310!\x18\211\x19\nL\210\b\vL\210	J:\203H  #[(G73706 funs global args) "\306\307!\306\310!\x18\211\x19\nL\210\b\vL\210	J:\203H  apply(#[(G73706 funs global args) "\306\307!\306\310!\x18\211\x19\nL\210\b\vL\210	J:\203H  (lambda (&rest --cl-rest--) (apply #[... "\306\307!\306\310!\x18\211\x19\nL\210\b\vL\210	J:\203H  #[(G73703 G73704 G73705 &rest args) "\bJ	JA\nJ\v#\207" [G73705 G73704 G73703 args] 4](--global-- --funs-- ----cl-var--73702--)
  apply(#[(G73703 G73704 G73705 &rest args) "\bJ	JA\nJ\v#\207" [G73705 G73704 G73703 args] 4] --global-- --funs-- ----cl-var--73702-- nil)
  (lambda (&rest --cl-rest--) (apply #[... "\bJ	JA\nJ\v#\207" [G73705 G73704 G73703 args] 4] (quote --global--) (quote --funs--) (quote ----cl-var--73702--) --cl-rest--))()
  mail-abbrev-expand-wrapper((lambda (&rest --cl-rest--) (apply #[... "\bJ	JA\nJ\v#\207" [G73705 G73704 G73703 args] 4] (quote --global--) (quote --funs--) (quote ----cl-var--73702--) --cl-rest--)))
  apply(mail-abbrev-expand-wrapper (lambda (&rest --cl-rest--) (apply #[... "\bJ	JA\nJ\v#\207" [G73705 G73704 G73703 args] 4] (quote --global--) (quote --funs--) (quote ----cl-var--73702--) --cl-rest--)) nil)
  #[(G73706 funs global args) "\306\307!\306\310!\x18\211\x19\nL\210\b\vL\210	J:\203H  apply(#[(G73706 funs global args) "\306\307!\306\310!\x18\211\x19\nL\210\b\vL\210	J:\203H  (lambda (&rest --cl-rest--) (apply #[... "\306\307!\306\310!\x18\211\x19\nL\210\b\vL\210	J:\203H  expand-abbrev()

Re: abbrevs broken since 2009-11-19 03:12:51 +0000

[Manoj Srivastava]

Hi,

        I can confirm that the commit:
--8<---------------cut here---------------start------------->8---
Author: Stefan Monnier <monnier@cs.yale.edu>  2009-11-18 19:40:22
Committer: Stefan Monnier <monnier@cs.yale.edu>  2009-11-18 19:40:22
Parent: 74797b39e6e3d01909c3ea1f68be306a23d92ba5 (*** empty log message ***)
Child:  137dfaace3ef9e75f95cb2770f0da748ad994242 (Note that this version has been modified by Manoj)
Child:  be11c6010ad352ebb93a7921f356a436a6d49f64 (* abbrev.el (abbrev-with-wrapper-hook): (re)move...)
Branches: Working, debian, master, place-debian, remotes/origin/master
Follows: EMACS_PRETEST_23_0_95
Precedes: 

    (make_gap_larger): Don't make as many assumptions about the
    representation of Lisp integers.
    Reported by MJ Chan <mjchan.inbox@gmail.com>.
--8<---------------cut here---------------end--------------->8---
        Works, and
--8<---------------cut here---------------start------------->8---
Author: Stefan Monnier <monnier@cs.yale.edu>  2009-11-18 21:12:51
Committer: Stefan Monnier <monnier@cs.yale.edu>  2009-11-18 21:12:51
Parent: dedb05a9cfc445f851a890a20d1447abff240861 ((make_gap_larger): Don't make as many assumptions about the)
Child:  ca26275f0e7d093cec2b4bc677e4ac7806f6f34c (Fix entries.)
Branches: debian, master, remotes/origin/master
Follows: EMACS_PRETEST_23_0_95
Precedes: 

    * abbrev.el (abbrev-with-wrapper-hook): (re)move...
    * simple.el (with-wrapper-hook): ...to here.  Add argument `args'.
    * minibuffer.el (completion-in-region-functions): New hook.
    (completion-in-region): New function.
    * emacs-lisp/lisp.el (lisp-complete-symbol):
    * pcomplete.el (pcomplete-std-complete): Use it.
--8<---------------cut here---------------end--------------->8---
  does not.

        manoj
-- 
"Of course power tools and alcohol don't mix.  Everyone knows power
tools aren't soluble in alcohol..." -- Crazy Nigel
Manoj Srivastava <srivasta@acm.org> <http://www.golden-gryphon.com/>  
1024D/BF24424C print 4966 F272 D093 B493 410B  924B 21BA DABB BF24 424C

Re: abbrevs broken since 2009-11-19 03:12:51 +0000

[Stefan Monnier]

> I pulled a new Emacs snapshot from the Git repository this morning and
> noticed that typing a space in message-mode fails with a backtrace
> similar to the one attached to this message.

Sorry, and thanks for the report.  I just fixed it (you'll need to
rm lisp/abbrev.elc to force recompiling it with the new simple.el).


        Stefan

Re: abbrevs broken since 2009-11-19 03:12:51 +0000

[Giorgos Keramidas]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

On Thu, 19 Nov 2009 15:59:39 -0500, Stefan Monnier <monnier@IRO.UMontreal.CA> wrote:
>> I pulled a new Emacs snapshot from the Git repository this morning and
>> noticed that typing a space in message-mode fails with a backtrace
>> similar to the one attached to this message.
>
> Sorry, and thanks for the report.  I just fixed it (you'll need to
> rm lisp/abbrev.elc to force recompiling it with the new simple.el).

It's ok.  I always keep a tarball of the last 2-3 successful builds
around, so rolling back is only half a minute of work.  I'm building
a new snapshot now.  Thanks for the fast fix :-)


[-- Attachment #2: Type: application/pgp-signature, Size: 195 bytes --]

Re: abbrevs broken since 2009-11-19 03:12:51 +0000

[Giorgos Keramidas]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

On Thu, 19 Nov 2009 15:59:39 -0500, Stefan Monnier <monnier@IRO.UMontreal.CA> wrote:
>> I pulled a new Emacs snapshot from the Git repository this morning and
>> noticed that typing a space in message-mode fails with a backtrace
>> similar to the one attached to this message.
>
> Sorry, and thanks for the report.  I just fixed it (you'll need to
> rm lisp/abbrev.elc to force recompiling it with the new simple.el).

Thanks!  All works fine now.


[-- Attachment #2: Type: application/pgp-signature, Size: 195 bytes --]