From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Ryde Newsgroups: gmane.emacs.bugs Subject: bug#5394: 23.1; copyright.el show buffer being changed Date: Sat, 16 Jan 2010 09:16:08 +1100 Message-ID: <878wbznhef.fsf@blah.blah> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1263594769 14421 80.91.229.12 (15 Jan 2010 22:32:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Jan 2010 22:32:49 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 15 23:32:41 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NVuid-0005dK-Tx for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jan 2010 23:32:40 +0100 Original-Received: from localhost ([127.0.0.1]:54813 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NVuie-0003Yo-MN for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jan 2010 17:32:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NVuiZ-0003XP-HP for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2010 17:32:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NVuiV-0003Uv-PR for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2010 17:32:35 -0500 Original-Received: from [199.232.76.173] (port=37394 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NVuiV-0003Us-F8 for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2010 17:32:31 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55433) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NVuiV-0004nj-5K for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2010 17:32:31 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NVuTW-0000zd-5N; Fri, 15 Jan 2010 17:17:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Mail-Followup-To: Kevin Ryde , 5394@debbugs.gnu.org Resent-From: Kevin Ryde Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jan 2010 22:17:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: report 5394 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@debbugs.gnu.org id=B.12635938093799 (code B ref -1); Fri, 15 Jan 2010 22:17:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Jan 2010 22:16:49 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NVuTJ-0000zE-Cm for submit@debbugs.gnu.org; Fri, 15 Jan 2010 17:16:49 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NVuTH-0000z9-1t for submit@debbugs.gnu.org; Fri, 15 Jan 2010 17:16:47 -0500 Original-Received: from mx10.gnu.org ([199.232.76.166]:43407) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NVuTD-0001OM-4Q for submit@debbugs.gnu.org; Fri, 15 Jan 2010 17:16:43 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NVuTA-0006ue-Ge for submit@debbugs.gnu.org; Fri, 15 Jan 2010 17:16:42 -0500 Original-Received: from lists.gnu.org ([199.232.76.165]:47517) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NVuTA-0006uH-53 for submit@debbugs.gnu.org; Fri, 15 Jan 2010 17:16:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NVuT9-0001ai-FB for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2010 17:16:39 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NVuT3-0001Yz-Pz for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2010 17:16:38 -0500 Original-Received: from [199.232.76.173] (port=60332 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NVuT3-0001Yw-Ki for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2010 17:16:33 -0500 Original-Received: from mailout2-15.pacific.net.au ([125.255.80.142]:44515 helo=mailout2.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NVuT2-0006pn-Vo for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2010 17:16:33 -0500 Original-Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout2.pacific.net.au (Postfix) with ESMTP id B343B1AAE10 for ; Sat, 16 Jan 2010 09:16:26 +1100 (EST) Original-Received: from blah.blah (ppp2AD9.dyn.pacific.net.au [61.8.42.217]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id C39B82741F for ; Sat, 16 Jan 2010 09:16:25 +1100 (EST) Original-Received: from gg by blah.blah with local (Exim 4.71) (envelope-from ) id 1NVuSf-0002WT-GA for bug-gnu-emacs@gnu.org; Sat, 16 Jan 2010 09:16:09 +1100 User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -5.4 (-----) Resent-Date: Fri, 15 Jan 2010 17:17:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34381 Archived-At: --=-=-= When doing C-x s `save-some-buffers' with copyright-update in before-save-hook, when copyright-update asks whether to add a copyright year it'd be good if it showed you the buffer it's asking about. I tried the couple of lines below for a simple switch-to-buffer. Perhaps a `perform-replace' or similar would be even better if it highlighted the part of the buffer that's going to be changed too. 2010-01-15 Kevin Ryde * emacs-lisp/copyright.el (copyright-update-year, copyright-update): Temporary switch-to-buffer to ensure the buffer change being queried is visible. Good for save-some-buffers when copyright-update is in before-save-hook. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=copyright.el.switch-to-buffer.diff --- copyright.el.~1.82.~ 2009-07-18 11:16:37.000000000 +1000 +++ copyright.el 2010-01-16 09:08:44.000000000 +1100 @@ -158,13 +158,15 @@ (unless (string= (buffer-substring (- (match-end 3) 2) (match-end 3)) (substring copyright-current-year -2)) (if (or noquery - ;; Fixes some point-moving oddness (bug#2209). - (save-excursion - (y-or-n-p (if replace - (concat "Replace copyright year(s) by " - copyright-current-year "? ") - (concat "Add " copyright-current-year - " to copyright? "))))) + (save-window-excursion + (switch-to-buffer (current-buffer)) + ;; Fixes some point-moving oddness (bug#2209). + (save-excursion + (y-or-n-p (if replace + (concat "Replace copyright year(s) by " + copyright-current-year "? ") + (concat "Add " copyright-current-year + " to copyright? ")))))) (if replace (replace-match copyright-current-year t t nil 3) (let ((size (save-excursion (skip-chars-backward "0-9")))) @@ -224,8 +226,10 @@ (string-to-number copyright-current-gpl-version)) (or noquery (save-match-data - (y-or-n-p (format "Replace GPL version by %s? " - copyright-current-gpl-version)))) + (save-window-excursion + (switch-to-buffer (current-buffer)) + (y-or-n-p (format "Replace GPL version by %s? " + copyright-current-gpl-version))))) (progn (if (match-end 2) ;; Esperanto bilingual comment in two-column.el --=-=-= In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5) of 2009-09-14 on raven, modified by Debian configured using `configure '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' --=-=-=--