From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add notifications.el Date: Thu, 10 Jun 2010 10:26:56 +0200 Message-ID: <878w6nb8dr.fsf@gmx.de> References: <1275757657-15244-1-git-send-email-julien@danjou.info> <87631rzzxd.fsf@keller.adm.naquadah.org> <201006100833.47436.tassilo@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1276158457 19385 80.91.229.12 (10 Jun 2010 08:27:37 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 10 Jun 2010 08:27:37 +0000 (UTC) Cc: Tassilo Horn , Stefan Monnier , emacs-devel@gnu.org To: Julien Danjou Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 10 10:27:34 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OMd6c-0005ta-FV for ged-emacs-devel@m.gmane.org; Thu, 10 Jun 2010 10:27:31 +0200 Original-Received: from localhost ([127.0.0.1]:41187 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMd6W-0007dn-Ok for ged-emacs-devel@m.gmane.org; Thu, 10 Jun 2010 04:27:12 -0400 Original-Received: from [140.186.70.92] (port=58862 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMd6O-0007b6-R5 for emacs-devel@gnu.org; Thu, 10 Jun 2010 04:27:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMd6N-000673-ED for emacs-devel@gnu.org; Thu, 10 Jun 2010 04:27:04 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]:56709) by eggs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1OMd6N-00066n-0L for emacs-devel@gnu.org; Thu, 10 Jun 2010 04:27:03 -0400 Original-Received: (qmail invoked by alias); 10 Jun 2010 08:27:00 -0000 Original-Received: from p4FC18D5A.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [79.193.141.90] by mail.gmx.net (mp059) with SMTP; 10 Jun 2010 10:27:00 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX18ivrAlw0IiqrWmegjafuRM2/+/oKAsBX98ThjVlh t/zewYSt5uA8WB User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125700 Archived-At: Julien Danjou writes: > It seems to clear to me now that people may want to identify the > notification by id to use with their close/actions function, so let's > make that change until it's too late. Your patch looks reasonable to me. If you have a ChangeLog entry, I'm willing to commit it. (And maybe you have also docstrings for `notifications-on-action-signal' and `notifications-on-closed-signal') Best regards, Michael.