From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: Patch for bug #6515: unneeded let-bound variables in bookmark.el Date: Sat, 26 Jun 2010 17:50:33 -0400 Message-ID: <878w61xy3a.fsf@red-bean.com> References: <4C267485.2000804@gmail.com> <4C267553.3090109@gmail.com> Reply-To: Karl Fogel NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1277589049 20846 80.91.229.12 (26 Jun 2010 21:50:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 26 Jun 2010 21:50:49 +0000 (UTC) Cc: emacs-devel@gnu.org To: Christoph Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 26 23:50:48 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OSdGx-00010U-8f for ged-emacs-devel@m.gmane.org; Sat, 26 Jun 2010 23:50:47 +0200 Original-Received: from localhost ([127.0.0.1]:39838 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OSdGw-0000uA-Ng for ged-emacs-devel@m.gmane.org; Sat, 26 Jun 2010 17:50:46 -0400 Original-Received: from [140.186.70.92] (port=44574 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OSdGr-0000u5-HU for emacs-devel@gnu.org; Sat, 26 Jun 2010 17:50:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OSdGq-00016K-F6 for emacs-devel@gnu.org; Sat, 26 Jun 2010 17:50:41 -0400 Original-Received: from osh-net-219-98.onshore.net ([66.146.219.98]:54106 helo=sanpietro.red-bean.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSdGq-000160-Cq for emacs-devel@gnu.org; Sat, 26 Jun 2010 17:50:40 -0400 Original-Received: from localhost ([127.0.0.1]:38490 helo=floss ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.72) (envelope-from ) id 1OSdGk-0006Ph-61; Sat, 26 Jun 2010 16:50:34 -0500 In-Reply-To: <4C267553.3090109@gmail.com> (Christoph's message of "Sat, 26 Jun 2010 15:46:59 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126451 Archived-At: Christoph writes: >> Find attached a bugfix for bug #6515 >> (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515) for review. > >Sorry, this was intended to go to the bug tracker. Actually, I'm glad you sent it here. IMHO, the patch is small enough and trivial enough to go in regardless of assignment papers -- a mere description of the problem would suffice to cause any reasonable programmer to generate the exact same patch, if my understanding is correct (I haven't looked at it in depth yet, but will soon). Thanks, -Karl