[PATCH] whitespace.el leaves a spurious entry in post-command-hook

[PATCH] whitespace.el leaves a spurious entry in post-command-hook

[Geoff Gole]

Start an emacs -Q and do M-x whitespace-mode twice. There will be a
local entry left in post-command-hook.

The cause is that an appropriate call to remove-hook exists, but lacks
the `local' argument. The fix is to add it:

*** /usr/local/share/emacs/24.0.50/lisp/whitespace.el.gz
--- /tmp/buffer-content-4209UhA
***************
*** 2296,2302 ****
    ;; turn off font lock
    (when (whitespace-style-face-p)
      (font-lock-mode 0)
!     (remove-hook 'post-command-hook #'whitespace-post-command-hook)
      (when whitespace-font-lock
        (setq whitespace-font-lock nil
  	    font-lock-keywords   whitespace-font-lock-keywords))
--- 2296,2302 ----
    ;; turn off font lock
    (when (whitespace-style-face-p)
      (font-lock-mode 0)
!     (remove-hook 'post-command-hook #'whitespace-post-command-hook t)
      (when whitespace-font-lock
        (setq whitespace-font-lock nil
  	    font-lock-keywords   whitespace-font-lock-keywords))

Re: [PATCH] whitespace.el leaves a spurious entry in post-command-hook

[Chong Yidong]

Geoff Gole <geoffgole@gmail.com> writes:

> Start an emacs -Q and do M-x whitespace-mode twice. There will be a
> local entry left in post-command-hook.
>
> The cause is that an appropriate call to remove-hook exists, but lacks
> the `local' argument. The fix is to add it:

Thanks.  I've checked your fix into the emacs-23 branch.