bug#7040: 24.0.50; tramp-handle-directory-files is not loaded

bug#7040: 24.0.50; tramp-handle-directory-files is not loaded

[Thierry Volpiatto]

Hi,
tramp-handle-directory-files is not loaded.

To reproduce, try from remote to copy recursively a directory.

-- 
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

bug#7040: 24.0.50; tramp-handle-directory-files is not loaded

[Michael Albinus]

Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:

> Hi,

Hi,

> tramp-handle-directory-files is not loaded.
>
> To reproduce, try from remote to copy recursively a directory.

Works for me. Maybe, tramp-loaddefs.el is not regenerated? Try

# cd lisp; make autoloads

If this doesn't help, I need at least to know, which remote method you
have used. ssh? scp?

Best regards, Michael.

bug#7040: 24.0.50; tramp-handle-directory-files is not loaded

[Thierry Volpiatto]

Hi Michael,

Michael Albinus <michael.albinus@gmx.de> writes:

> Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:
>
>> Hi,
>
> Hi,
>
>> tramp-handle-directory-files is not loaded.
>>
>> To reproduce, try from remote to copy recursively a directory.
>
> Works for me. Maybe, tramp-loaddefs.el is not regenerated? 
Don't know, is the makefile aware of this file? 

> Try # cd lisp; make autoloads
Sorry, i can't do that yet as the emacs24 i have is installed by gentoo
from bzr, but the makefiles are removed in directory.
Maybe i can try to load the file itself? (need to switch i am on 23 now)

> If this doesn't help, I need at least to know, which remote method you
> have used. ssh? scp?
su, but i guess it's the same with ssh methods.

It's just a problem of loading the definition of
tramp-handle-directory-files, what i do here in anything-config.el
because i need this definition for compatibility with emacs versions < 23.2.
So it is working fine with this definition loaded.

> Best regards, Michael.
>

-- 
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

bug#7040: 24.0.50; tramp-handle-directory-files is not loaded

[Michael Albinus]

Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:

> Hi Michael,

Hi Thierry,

>> Works for me. Maybe, tramp-loaddefs.el is not regenerated? 
> Don't know, is the makefile aware of this file? 

It should, I have committed the patch at once, including Makefile.in
changes. However, a simple "make" does NOT generate autoloads (not only
for Tramp).

>> Try # cd lisp; make autoloads
> Sorry, i can't do that yet as the emacs24 i have is installed by gentoo
> from bzr, but the makefiles are removed in directory.
> Maybe i can try to load the file itself? (need to switch i am on 23 now)

Do you use Tramp outside the Emacs distribution? Have you downloaded
from the Tramp repo?

> It's just a problem of loading the definition of
> tramp-handle-directory-files, what i do here in anything-config.el
> because i need this definition for compatibility with emacs versions < 23.2.
> So it is working fine with this definition loaded.

Oops, it is not recommended to call `tramp-handle-*' functions directly
(you would bypass locking mechanisms). With recent Tramp 2.2, those
functions have been moved to another package. Likely, that's why you
don't see them. Instead of, call

(tramp-file-name-handler 'directory-files ...)

This shall also work with Emacs 23.

Best regards, Michael.

bug#7040: 24.0.50; tramp-handle-directory-files is not loaded

[Thierry Volpiatto]

Michael Albinus <michael.albinus@gmx.de> writes:

> Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:
>
>> Hi Michael,
>
> Hi Thierry,
>
>>> Works for me. Maybe, tramp-loaddefs.el is not regenerated? 
>> Don't know, is the makefile aware of this file? 
>
> It should, I have committed the patch at once, including Makefile.in
> changes. However, a simple "make" does NOT generate autoloads (not only
> for Tramp).
>
>>> Try # cd lisp; make autoloads
>> Sorry, i can't do that yet as the emacs24 i have is installed by gentoo
>> from bzr, but the makefiles are removed in directory.
>> Maybe i can try to load the file itself? (need to switch i am on 23 now)
>
> Do you use Tramp outside the Emacs distribution? Have you downloaded
> from the Tramp repo?
No i use tramp that come with Emacs.

>> It's just a problem of loading the definition of
>> tramp-handle-directory-files, what i do here in anything-config.el
>> because i need this definition for compatibility with emacs versions < 23.2.
>> So it is working fine with this definition loaded.
>
> Oops, it is not recommended to call `tramp-handle-*' functions directly
> (you would bypass locking mechanisms).

Yes, but i don't call this function directly, i just inline the actual
tramp-handle-directory-files to allow users of old tramp/emacs version
to use this version of the function that fix ".", "..", and sorting
(what we have fixed some months ago).

At first it was inlined inside a function with a flet, but i realized
that it is not called when i copy/rename, etc.. files, so it is now
(re)defined as defun.

I think the definition inlined in flet was confusing tramp.

I have now tried in emacs -Q (so without anything) and copy recursively
from remote work fine.

> With recent Tramp 2.2, those
> functions have been moved to another package. Likely, that's why you
> don't see them. Instead of, call
>
> (tramp-file-name-handler 'directory-files ...)

Ok thanks, that's good to know, but as said above i don't use
tramp-handle-directory-files directly, i let tramp do the job.

Sorry for the noise, but things are clearer now, thanks ;-)


-- 
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

bug#7040: 24.0.50; tramp-handle-directory-files is not loaded

[Michael Albinus]

Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:

>> Oops, it is not recommended to call `tramp-handle-*' functions directly
>> (you would bypass locking mechanisms).
>
> Yes, but i don't call this function directly, i just inline the actual
> tramp-handle-directory-files to allow users of old tramp/emacs version
> to use this version of the function that fix ".", "..", and sorting
> (what we have fixed some months ago).
>
> At first it was inlined inside a function with a flet, but i realized
> that it is not called when i copy/rename, etc.. files, so it is now
> (re)defined as defun.
>
> I think the definition inlined in flet was confusing tramp.

Maybe the best solution is defadvice. Then you don't need to redefine
Tramp's internals (and you are independent from further changes in that
function).

> I have now tried in emacs -Q (so without anything) and copy recursively
> from remote work fine.
>
>> With recent Tramp 2.2, those
>> functions have been moved to another package. Likely, that's why you
>> don't see them. Instead of, call
>>
>> (tramp-file-name-handler 'directory-files ...)
>
> Ok thanks, that's good to know, but as said above i don't use
> tramp-handle-directory-files directly, i let tramp do the job.
>
> Sorry for the noise, but things are clearer now, thanks ;-)

So we can close the bug report?

Best regards, Michael.

bug#7040: 24.0.50; tramp-handle-directory-files is not loaded

[Thierry Volpiatto]

Michael Albinus <michael.albinus@gmx.de> writes:

> Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:
>
>>> Oops, it is not recommended to call `tramp-handle-*' functions directly
>>> (you would bypass locking mechanisms).
>>
>> Yes, but i don't call this function directly, i just inline the actual
>> tramp-handle-directory-files to allow users of old tramp/emacs version
>> to use this version of the function that fix ".", "..", and sorting
>> (what we have fixed some months ago).
>>
>> At first it was inlined inside a function with a flet, but i realized
>> that it is not called when i copy/rename, etc.. files, so it is now
>> (re)defined as defun.
>>
>> I think the definition inlined in flet was confusing tramp.
>
> Maybe the best solution is defadvice. Then you don't need to redefine
> Tramp's internals (and you are independent from further changes in that
> function).
Well, i don't like defadvice, so i will see if i maintain this as
emacs23.2 is a stable emacs version.
Thank you anyway for your help and advices.

>> I have now tried in emacs -Q (so without anything) and copy recursively
>> from remote work fine.
>>
>>> With recent Tramp 2.2, those
>>> functions have been moved to another package. Likely, that's why you
>>> don't see them. Instead of, call
>>>
>>> (tramp-file-name-handler 'directory-files ...)
>>
>> Ok thanks, that's good to know, but as said above i don't use
>> tramp-handle-directory-files directly, i let tramp do the job.
>>
>> Sorry for the noise, but things are clearer now, thanks ;-)
>
> So we can close the bug report?

Yes.

> Best regards, Michael.
>

-- 
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

bug#7040: 24.0.50; tramp-handle-directory-files is not loaded

[Michael Albinus]

Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:

>> So we can close the bug report?
>
> Yes.

Done.

Best regards, Michael.