From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Custom themes Date: Thu, 14 Oct 2010 11:53:05 -0400 Message-ID: <878w20hiu6.fsf@stupidchicken.com> References: <87r5fxnwcp.fsf@stupidchicken.com> <877hhmvnxr.fsf@stupidchicken.com> <87hbgqjcwr.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1287071602 31342 80.91.229.12 (14 Oct 2010 15:53:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 14 Oct 2010 15:53:22 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 14 17:53:20 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P6Q7L-0000XB-QP for ged-emacs-devel@m.gmane.org; Thu, 14 Oct 2010 17:53:20 +0200 Original-Received: from localhost ([127.0.0.1]:56494 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P6Q7L-0005m9-ES for ged-emacs-devel@m.gmane.org; Thu, 14 Oct 2010 11:53:19 -0400 Original-Received: from [140.186.70.92] (port=60996 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P6Q7F-0005ki-Oq for emacs-devel@gnu.org; Thu, 14 Oct 2010 11:53:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P6Q79-0001h6-PF for emacs-devel@gnu.org; Thu, 14 Oct 2010 11:53:13 -0400 Original-Received: from pantheon-po16.its.yale.edu ([130.132.50.72]:36037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P6Q79-0001gw-Mi for emacs-devel@gnu.org; Thu, 14 Oct 2010 11:53:07 -0400 Original-Received: from furry (dhcp128036014158.central.yale.edu [128.36.14.158]) (authenticated bits=0) by pantheon-po16.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o9EFr5BI004660 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 14 Oct 2010 11:53:05 -0400 Original-Received: by furry (Postfix, from userid 1000) id 55624C018; Thu, 14 Oct 2010 11:53:05 -0400 (EDT) In-Reply-To: <87hbgqjcwr.fsf@stupidchicken.com> (Chong Yidong's message of "Wed, 13 Oct 2010 12:05:56 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:131706 Archived-At: Chong Yidong writes: > Juanma Barranquero writes: > >> On Wed, Oct 13, 2010 at 04:14, Chong Yidong wrote: >> >>> The original motivation for calling it foo-theme.el was so that users >>> can copy the theme file into .emacs.d (or wherever the load-directory >>> for their local Lisp files is). >> >> It seems cleaner to have an .emacs.d/themes/ dir. > > OK, I'll make the change. The change turns out to be more problematic than it seemed. If we remove lisp/themes from the load path, we have to tell the themes code how to find that directory again. We could do (dolist (dir load-path) (locate-file "themes/foo.el" dir) ...) but that means looking for a themes/ subdirectory in *all* the load-path directories, which seems silly. One alternative is to determine the themes directory at the Makefile level, similar to what we do for leim; but I don't like adding more complexity to the Makefiles just for this. Another alternative is to put the theme files in etc/, but that's not good either, since Lisp files ought to go in lisp/. De-synching the themes path from load-path also makes it more difficult for us to provide themes via a package.