all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Bastien <bastien.guerry@wikimedia.fr>
To: Arik Mitschang <arik.mitschang@mq.edu.au>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-capture - org-vm store link requires buffer file not always present [7.4]
Date: Wed, 09 Feb 2011 17:19:08 +0100	[thread overview]
Message-ID: <878vxpnptv.fsf@gnu.org> (raw)
In-Reply-To: <41zqc6bp2l518n.fsf@mq.edu.au> (Arik Mitschang's message of "Wed, 09 Feb 2011 14:35:20 +1100")

Hi Arik,

Arik Mitschang <arik.mitschang@mq.edu.au> writes:

> In VM if you have created a virtual folder, the buffer is not associated
> with any file. However, during org-capture a function called
> org-vm-store-link requires that the buffer (the vm folder in this case)
> be associated with a file causing a type-mismatch error. I can fix the
> problem with the following patch:

This looks fine to me, but I'm not using VM.  

Can some VM user double-check this?

> ----------------------------------
> diff -U3 /usr/local/share/emacs/23.2/site-lisp/org-vm.el /var/folders/Qm/Qm3iuPk7E18cewjBO5PgL5AVPiY/-Tmp-/buffer-content-66395kXL
> --- /usr/local/share/emacs/23.2/site-lisp/org-vm.el	2010-12-11 00:16:33.000000000 +1100
> +++ /var/folders/Qm/Qm3iuPk7E18cewjBO5PgL5AVPiY/-Tmp-/buffer-content-66395kXL	2011-02-09 14:27:35.000000000 +1100
> @@ -54,8 +54,12 @@
>  ;; Implementation
>  (defun org-vm-store-link ()
>    "Store a link to a VM folder or message."
> -  (when (or (eq major-mode 'vm-summary-mode)
> +  (when (and (or (eq major-mode 'vm-summary-mode)
>  	    (eq major-mode 'vm-presentation-mode))
> +			 (save-excursion (vm-select-folder-buffer)
> +							 (eq (type-of buffer-file-name)
> +							 'string)))

(Better use (stringp buffer-file-name) instead of type-of.)

-- 
 Bastien

  reply	other threads:[~2011-02-09 16:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09  3:35 Bug: org-capture - org-vm store link requires buffer file not always present [7.4] Arik Mitschang
2011-02-09 16:19 ` Bastien [this message]
2011-02-12 18:40 ` Bastien
     [not found]   ` <19800.33799.716636.291461@nobunaga.local>
2011-02-14 10:15     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878vxpnptv.fsf@gnu.org \
    --to=bastien.guerry@wikimedia.fr \
    --cc=arik.mitschang@mq.edu.au \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.