From: Juri Linkov <juri@jurta.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 9353@debbugs.gnu.org
Subject: bug#9353: 24.0.50; default grep file name face is uglier now
Date: Wed, 24 Aug 2011 00:32:39 +0300 [thread overview]
Message-ID: <878vqjvmo8.fsf@mail.jurta.org> (raw)
In-Reply-To: <D6261054A49249E39889E3401FF3503D@us.oracle.com> (Drew Adams's message of "Tue, 23 Aug 2011 13:18:54 -0700")
> See attached images. The old face inherited from `font-lock-type-face',
> and the appearace was OK (though not wonderful).
> The new face inherits from a face called `success'. It is uhhhhgggly.
FYI, old is new and new is old. I copied the default value of `success'
from the old face definition of `compilation-info' that existed in Emacs 23
and older. OTOH, colors of `font-lock-type-face' for grep are new
(6 months in the repository).
> For one thing, it should not be bold. We should almost never use a bold
> face as the default face for something, because boldness does not work
> well on some platforms and for some (many) faces.
I agree, e.g. with my 10px fonts, bold is unreadable.
So I reset the bold attribute from all used faces.
Moreover, I customized this face to "ForestGreen",
i.e. to the color you are suggesting now.
So I agree it's better than the current face definition.
The only reason why I took the old value is because I thought
it's safer to use the old face no one complained about.
> I applaud not inheriting from a font-lock face: there is no logical
> connection to a grepped file. But there is also no logical connection
> to "success" here.
I think if we'll copy the face definition from `font-lock-type-face'
to `success', the former should not inherit from the latter,
because they are not logically related.
next prev parent reply other threads:[~2011-08-23 21:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 20:18 bug#9353: 24.0.50; default grep file name face is uglier now Drew Adams
2011-08-23 21:32 ` Juri Linkov [this message]
2011-08-24 0:19 ` Drew Adams
2011-08-24 9:01 ` Juri Linkov
2011-08-24 14:55 ` Stefan Monnier
2011-08-24 18:02 ` Juri Linkov
2011-08-24 0:24 ` Stefan Monnier
2011-08-24 9:04 ` Juri Linkov
2011-08-24 13:38 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vqjvmo8.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=9353@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.