all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: 9824@debbugs.gnu.org
Subject: bug#9824: Info fails to follow multi-line links to manuals with dots
Date: Fri, 21 Oct 2011 17:10:27 +0300	[thread overview]
Message-ID: <878voehe1x.fsf@mail.jurta.org> (raw)

For example, clicking on the following link fails to navigate to another
Info manual:

  languages, are documented in a separate manual.  *Note Introduction:
  (gccint-4.4)Top.

because a regexp for leading space in `Info-following-node-name-re'
doesn't take into account multi-line case.

Links to manuals without dots in the file name currently work
just by accident, e.g. clicking on:

  are performed by running the function.  *Note What Is a Function:
  (elisp)What Is a Function.

works because the regexp for unallowed chars in node names
doesn't contain parens (but contains dots) and matches everything
including file names (without dots).

This is wrong but I hesitate to make the regexp more restrictive
by disallowing parens in node names because Info currently using
regexp matching extensively is very brittle.

The following patch makes the regexp for leading space more permissive
by allowing newlines in leading space:

=== modified file 'lisp/info.el'
--- lisp/info.el	2011-09-24 19:18:43 +0000
+++ lisp/info.el	2011-10-21 14:10:04 +0000
@@ -2020,7 +2020,7 @@ (defun Info-following-node-name-re (&opt
 Submatch 2 if non-nil is the parenthesized file name part of the node name.
 Submatch 3 is the local part of the node name.
 End of submatch 0, 1, and 3 are the same, so you can safely concat."
-  (concat "[ \t]*"			;Skip leading space.
+  (concat "[ \t\n]*"			;Skip leading space.
 	  "\\(\\(([^)]+)\\)?"	;Node name can start with a file name.
 	  "\\([" (or allowedchars "^,\t\n") "]*" ;Any number of allowed chars.
 	  "[" (or allowedchars "^,\t\n") " ]" ;The last char can't be a space.







             reply	other threads:[~2011-10-21 14:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-21 14:10 Juri Linkov [this message]
2011-10-21 17:41 ` bug#9824: Info fails to follow multi-line links to manuals with dots Stefan Monnier
2011-10-24  5:47   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878voehe1x.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=9824@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.