From: Kenichi Handa <handa@m17n.org>
To: Glenn Morris <rgm@gnu.org>
Cc: 10368@debbugs.gnu.org
Subject: bug#10368: 24.0.92; wrong char-width by display table
Date: Mon, 16 Jan 2012 08:41:34 +0900 [thread overview]
Message-ID: <878vl8ile9.fsf@m17n.org> (raw)
In-Reply-To: <l4nw0jb2q.fsf@fencepost.gnu.org> (message from Glenn Morris on Fri, 13 Jan 2012 02:50:05 -0500)
In article <l4nw0jb2q.fsf@fencepost.gnu.org>, Glenn Morris <rgm@gnu.org> writes:
> It's generally pretty straightforward with bzrmerge.el.
Ah, I didn't know about bzrmerge.el.
> However, in this case there is a merge conflict that I do not know how
> to resolve. The code in the trunk has been changed to use
> `sanitize_char_width'. If you can say what the diff against trunk should
> look like, I could merge it.
Thank you. Here's the diff against trunk.
---
Kenichi Handa
handa@m17n.org
=== modified file 'src/ChangeLog'
--- src/ChangeLog 2011-12-25 09:06:42 +0000
+++ src/ChangeLog 2011-12-26 04:57:25 +0000
@@ -1,3 +1,8 @@
+2011-12-26 Kenichi Handa <handa@m17n.org>
+
+ * character.c (char_width): New function.
+ (Fchar_width, c_string_width, lisp_string_width): Use char_width.
+
2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
* callint.c (Fcall_interactively): Don't truncate prompt string.
=== modified file 'src/character.c'
--- src/character.c 2011-11-20 02:29:42 +0000
+++ src/character.c 2011-12-26 04:55:24 +0000
@@ -308,6 +308,31 @@
}
}
+
+/* Return width (columns) of C considering the buffer display table DP. */
+
+static int
+char_width (int c, struct Lisp_Char_Table *dp)
+{
+ int width = CHAR_WIDTH (c);
+
+ if (dp)
+ {
+ Lisp_Object disp = DISP_CHAR_VECTOR (dp, c), ch;
+ int i;
+
+ if (VECTORP (disp))
+ for (i = 0, width = 0; i < ASIZE (disp); i++)
+ {
+ ch = AREF (disp, i);
+ if (CHARACTERP (ch))
+ width += CHAR_WIDTH (XFASTINT (ch));
+ }
+ }
+ return width;
+}
+
+
DEFUN ("char-width", Fchar_width, Schar_width, 1, 1, 0,
doc: /* Return width of CHAR when displayed in the current buffer.
The width is measured by how many columns it occupies on the screen.
@@ -315,21 +340,11 @@
usage: (char-width CHAR) */)
(Lisp_Object ch)
{
- Lisp_Object disp;
int c, width;
- struct Lisp_Char_Table *dp = buffer_display_table ();
CHECK_CHARACTER (ch);
c = XINT (ch);
-
- /* Get the way the display table would display it. */
- disp = dp ? DISP_CHAR_VECTOR (dp, c) : Qnil;
-
- if (VECTORP (disp))
- width = sanitize_char_width (ASIZE (disp));
- else
- width = CHAR_WIDTH (c);
-
+ width = char_width (c, buffer_display_table ());
return make_number (width);
}
@@ -350,22 +365,9 @@
while (i_byte < len)
{
- int bytes, thiswidth;
- Lisp_Object val;
+ int bytes;
int c = STRING_CHAR_AND_LENGTH (str + i_byte, bytes);
-
- if (dp)
- {
- val = DISP_CHAR_VECTOR (dp, c);
- if (VECTORP (val))
- thiswidth = sanitize_char_width (ASIZE (val));
- else
- thiswidth = CHAR_WIDTH (c);
- }
- else
- {
- thiswidth = CHAR_WIDTH (c);
- }
+ int thiswidth = char_width (c, dp);
if (precision > 0
&& (width + thiswidth > precision))
@@ -447,18 +449,7 @@
else
c = str[i_byte], bytes = 1;
chars = 1;
- if (dp)
- {
- val = DISP_CHAR_VECTOR (dp, c);
- if (VECTORP (val))
- thiswidth = sanitize_char_width (ASIZE (val));
- else
- thiswidth = CHAR_WIDTH (c);
- }
- else
- {
- thiswidth = CHAR_WIDTH (c);
- }
+ thiswidth = char_width (c, dp);
}
if (precision <= 0)
prev parent reply other threads:[~2012-01-15 23:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 5:10 bug#10368: 24.0.92; wrong char-width by display table Kenichi Handa
2011-12-27 1:16 ` Stefan Monnier
2012-01-13 2:43 ` Glenn Morris
2012-01-13 6:02 ` Kenichi Handa
2012-01-13 7:50 ` Glenn Morris
2012-01-15 23:41 ` Kenichi Handa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vl8ile9.fsf@m17n.org \
--to=handa@m17n.org \
--cc=10368@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.