From: Christopher Schmidt <christopher@ch.ristopher.com>
To: 12174@debbugs.gnu.org
Subject: bug#12174: 24.1.50; C-h f and non-symbol remap targets
Date: Fri, 10 Aug 2012 22:55:42 +0100 (BST) [thread overview]
Message-ID: <878vdme7jd@ch.ristopher.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
(global-set-key [remap write-file] (lambda () (interactive) 'rms))
C-h f write-file RET
This yields in an error because help-fns--key-bindings expects
(command-remapping 'write-file) to be a symbol.
Here is a patch that abbreviates non-symbol remap targets with "??".
This is consistent with what describe-bindings displays.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: help-fns--key-bindings.diff --]
[-- Type: text/x-diff, Size: 891 bytes --]
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2012-08-10 21:03:10 +0000
+++ lisp/ChangeLog 2012-08-10 21:53:48 +0000
@@ -1,3 +1,8 @@
+2012-08-10 Christopher Schmidt <christopher@ch.ristopher.com>
+
+ * help-fns.el (help-fns--key-bindings): Abbreviate non-symbol
+ remap targets with ?? (Bug#).
+
2012-08-10 Stefan Monnier <monnier@iro.umontreal.ca>
* emacs-lisp/rx.el (rx-constituents): Don't define as constant.
=== modified file 'lisp/help-fns.el'
--- lisp/help-fns.el 2012-08-06 21:05:48 +0000
+++ lisp/help-fns.el 2012-08-10 21:28:18 +0000
@@ -398,7 +398,7 @@
(push key non-modified-keys)))
(when remapped
(princ "Its keys are remapped to `")
- (princ (symbol-name remapped))
+ (princ (if (symbolp remapped) (symbol-name remapped) "??"))
(princ "'.\n"))
(when keys
[-- Attachment #3: Type: text/plain, Size: 21 bytes --]
Christopher
next reply other threads:[~2012-08-10 21:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 21:55 Christopher Schmidt [this message]
2012-08-14 18:12 ` bug#12174: 24.1.50; C-h f and non-symbol remap targets Christopher Schmidt
2012-08-15 2:38 ` Stefan Monnier
2012-08-15 8:33 ` Christopher Schmidt
2012-08-22 7:02 ` Glenn Morris
2012-08-22 7:21 ` Dani Moncayo
2012-08-22 7:24 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vdme7jd@ch.ristopher.com \
--to=christopher@ch.ristopher.com \
--cc=12174@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.