From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Engster Newsgroups: gmane.emacs.devel Subject: Re: Byte compiler and eval-when-compile Date: Thu, 18 Oct 2012 22:07:07 +0200 Message-ID: <878vb37dec.fsf@engster.org> References: <87a9vn7lhv.fsf@engster.org> <87626b7d02.fsf@engster.org> <876267zk1u.fsf@engster.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1350590835 22752 80.91.229.3 (18 Oct 2012 20:07:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Oct 2012 20:07:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 18 22:07:22 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TOwNG-0003kh-4m for ged-emacs-devel@m.gmane.org; Thu, 18 Oct 2012 22:07:22 +0200 Original-Received: from localhost ([::1]:35708 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOwN8-0008Kw-Hz for ged-emacs-devel@m.gmane.org; Thu, 18 Oct 2012 16:07:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOwN5-0008Js-Pg for emacs-devel@gnu.org; Thu, 18 Oct 2012 16:07:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOwN4-0002Er-RT for emacs-devel@gnu.org; Thu, 18 Oct 2012 16:07:11 -0400 Original-Received: from randomsample.de ([83.169.19.17]:52771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOwN4-0002Ef-Ea; Thu, 18 Oct 2012 16:07:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=Fkk7kJKYg4octb6I+WMz6O2HkQUJQmttSI6RIYlIGlc=; b=eP1NpvaF87mkKJr9uhr+a4kRYHqN08u78V2blBz8iA6HUUz/tHTy5TOZIvj/uvXaQT6E9hqSXsR5U1pPCv+owE6BxMaoDrtnkk9+c9aI/8LemJGOAw0PXg5yxRm0J08r; Original-Received: from dslc-082-083-062-221.pools.arcor-ip.net ([82.83.62.221] helo=spaten) by randomsample.de with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TOwN2-00032h-8r; Thu, 18 Oct 2012 22:07:08 +0200 In-Reply-To: (Glenn Morris's message of "Thu, 18 Oct 2012 15:53:02 -0400") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) Mail-Followup-To: Glenn Morris , emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 83.169.19.17 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154422 Archived-At: Glenn Morris writes: > The byte-compiler is not that smart and doesn't fully recognize defuns > that are not at top-level. This one is "hidden" inside an if. > You could eval-and-compile the whole thing (defun and all) to make the > warning go away. But lisp-imenu-generic-expression is defined in every > Emacs since at least 21.1, so I don't see the point of the if, unless > it's an XEmacs thing, in which case featurep 'xemacs can be cleaner. Actually, I first wanted to remove that test, but then bzr anotate showed his name for that line, which is why I thought there *must* be some very smart reason that test is there. Now I see that he only fixed a typo there recently, so I guess I can safely remove it. :-) Sorry for the noise, -David