From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#13000: 24.2.90; underwave doesn't look as good as other IDEs Date: Sat, 29 Dec 2012 23:54:30 +0200 Organization: JURTA Message-ID: <878v8h542n.fsf@mail.jurta.org> References: <87fw2ri9n5.fsf@mail.jurta.org> <87vcbl3er7.fsf@mail.jurta.org> <83y5ghl407.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1356819670 21938 80.91.229.3 (29 Dec 2012 22:21:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Dec 2012 22:21:10 +0000 (UTC) Cc: sdl.web@gmail.com, 13000@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 29 23:21:26 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tp4mR-0007fz-Ce for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Dec 2012 23:21:23 +0100 Original-Received: from localhost ([::1]:56842 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tp4mC-0008D7-NQ for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Dec 2012 17:21:08 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tp4mA-00088l-CJ for bug-gnu-emacs@gnu.org; Sat, 29 Dec 2012 17:21:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tp4m8-00039I-Lg for bug-gnu-emacs@gnu.org; Sat, 29 Dec 2012 17:21:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tp4m8-00039E-Ib for bug-gnu-emacs@gnu.org; Sat, 29 Dec 2012 17:21:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tp4n6-00036V-P4 for bug-gnu-emacs@gnu.org; Sat, 29 Dec 2012 17:22:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Dec 2012 22:22:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13000 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 13000-submit@debbugs.gnu.org id=B13000.135681966311837 (code B ref 13000); Sat, 29 Dec 2012 22:22:03 +0000 Original-Received: (at 13000) by debbugs.gnu.org; 29 Dec 2012 22:21:03 +0000 Original-Received: from localhost ([127.0.0.1]:36426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tp4m6-00034h-4d for submit@debbugs.gnu.org; Sat, 29 Dec 2012 17:21:02 -0500 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:48639 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tp4m1-00034L-GZ for 13000@debbugs.gnu.org; Sat, 29 Dec 2012 17:20:59 -0500 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id ECAA6451CE1D; Sat, 29 Dec 2012 14:19:54 -0800 (PST) In-Reply-To: <83y5ghl407.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Dec 2012 09:19:20 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69174 Archived-At: >> The already supported condition ((supports :underline t)) >> doesn't take into account the underwave attribute, >> and a similar condition ((supports :underline wave)) >> is not implemented. > > Implementing the missing condition should be easy. Yes, pretty easy: === modified file 'src/xfaces.c' --- src/xfaces.c 2012-11-16 17:20:23 +0000 +++ src/xfaces.c 2012-12-29 21:50:36 +0000 @@ -4877,6 +4877,8 @@ tty_supports_face_attributes_p (struct frame *f, { if (STRINGP (val)) return 0; /* ttys can't use colored underlines */ + else if (EQ (CAR_SAFE (val), QCstyle) && EQ (CAR_SAFE (CDR_SAFE (val)), Qwave)) + return 0; /* ttys can't use wave underlines */ else if (face_attr_equal_p (val, def_attrs[LFACE_UNDERLINE_INDEX])) return 0; /* same as default */ else Then its support could checked with ((supports :underline (:style wave))) === modified file 'lisp/progmodes/flymake.el' --- lisp/progmodes/flymake.el 2012-11-12 08:42:27 +0000 +++ lisp/progmodes/flymake.el 2012-12-29 21:54:08 +0000 @@ -844,12 +844,18 @@ (defun flymake-region-has-flymake-overla has-flymake-overlays)) (defface flymake-errline - '((t :inherit error)) + '((((supports :underline (:style wave))) + :underline (:style wave :color "Red1")) + (t + :inherit error)) "Face used for marking error lines." :group 'flymake) (defface flymake-warnline - '((t :inherit warning)) + '((((supports :underline (:style wave))) + :underline (:style wave :color "DarkOrange")) + (t + :inherit warning)) "Face used for marking warning lines." :group 'flymake) === modified file 'lisp/textmodes/flyspell.el' --- lisp/textmodes/flyspell.el 2012-09-17 05:41:04 +0000 +++ lisp/textmodes/flyspell.el 2012-12-29 21:54:14 +0000 @@ -445,11 +445,19 @@ (make-variable-buffer-local 'flyspell-da ;;*---------------------------------------------------------------------*/ ;;* Highlighting */ ;;*---------------------------------------------------------------------*/ -(defface flyspell-incorrect '((t :underline t :inherit error)) +(defface flyspell-incorrect + '((((supports :underline (:style wave))) + :underline (:style wave :color "Red1")) + (t + :underline t :inherit error)) "Flyspell face for misspelled words." :group 'flyspell) -(defface flyspell-duplicate '((t :underline t :inherit warning)) +(defface flyspell-duplicate + '((((supports :underline (:style wave))) + :underline (:style wave :color "DarkOrange")) + (t + :underline t :inherit warning)) "Flyspell face for words that appear twice in a row. See also `flyspell-duplicate-distance'." :group 'flyspell)