From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/emacs-24 r111116: eval-after-load fix Date: Thu, 03 Jan 2013 05:27:19 +0400 Message-ID: <878v8b839k.fsf@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1357176451 19203 80.91.229.3 (3 Jan 2013 01:27:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Jan 2013 01:27:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 03 02:27:47 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TqZb1-0002qI-Bj for ged-emacs-devel@m.gmane.org; Thu, 03 Jan 2013 02:27:47 +0100 Original-Received: from localhost ([::1]:34859 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqZam-0001Fo-4v for ged-emacs-devel@m.gmane.org; Wed, 02 Jan 2013 20:27:32 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:59137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqZaf-0001FM-1J for emacs-devel@gnu.org; Wed, 02 Jan 2013 20:27:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqZaa-0007Q6-T7 for emacs-devel@gnu.org; Wed, 02 Jan 2013 20:27:24 -0500 Original-Received: from mail-la0-f49.google.com ([209.85.215.49]:55082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqZaa-0007Px-L6; Wed, 02 Jan 2013 20:27:20 -0500 Original-Received: by mail-la0-f49.google.com with SMTP id fk20so6963154lab.22 for ; Wed, 02 Jan 2013 17:27:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=CICasG4++wJm95eSJIIYLfAGNYer5srRmFNFXRubq9k=; b=XFaRFBWkwx1dGaEXDXA9j3gtXgjJBiYrFIghPCOCZ0nq4OTgaOWtXZHNJZLnraXtZ6 7EfrXlnBqacXLucb14muGMyuFOdzOai/gyHtxHjCmGvg8qOjUe3hi2/bdNv/2vfNTizL rxHPaAp/j/x4qbCquJBxStL8jWUsyIM7l8cxhdBrkbTWZT8w9Dpo0qnBw9a7fsmNpwbZ HKn/e2VdrVyDCipWTC5PkjSlSxEw3HaFOwfXiOoN8SXuCj0tTzIaaw4vJbg1W0zKC5L1 +Zg9b8LDDEyqjZiAo652oi8elZ0fqIxujOUjviC650TElPEmXo3Yzorv0z1lR2/2ofMF aVow== X-Received: by 10.112.25.106 with SMTP id b10mr18778971lbg.68.1357176438044; Wed, 02 Jan 2013 17:27:18 -0800 (PST) Original-Received: from SOL ([178.252.98.87]) by mx.google.com with ESMTPS id ns7sm16520691lab.5.2013.01.02.17.27.15 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Jan 2013 17:27:16 -0800 (PST) In-Reply-To: (Glenn Morris's message of "Wed, 02 Jan 2013 16:50:35 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (windows-nt) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.215.49 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156054 Archived-At: I wonder, wouldn't it still make sense to purecopy the form, just not the list wrapping it? Glenn Morris writes: > ------------------------------------------------------------ > revno: 111116 > fixes bug: http://debbugs.gnu.org/13331 > committer: Glenn Morris > branch nick: emacs-24 > timestamp: Wed 2013-01-02 16:50:35 -0800 > message: > eval-after-load fix > > * lisp/subr.el (eval-after-load): Don't purecopy the form, so that it > can be nconc'd later on; reverts 2009-11-11 change. > modified: > lisp/ChangeLog > lisp/subr.el > === modified file 'lisp/ChangeLog' > --- a/lisp/ChangeLog 2013-01-03 00:43:46 +0000 > +++ b/lisp/ChangeLog 2013-01-03 00:50:35 +0000 > @@ -1,5 +1,8 @@ > 2013-01-03 Glenn Morris > > + * subr.el (eval-after-load): Don't purecopy the form, so that it > + can be nconc'd later on; reverts 2009-11-11 change. (Bug#13331) > + > * emacs-lisp/byte-run.el (defun): Place cl declarations > after any interactive spec. (Bug#13265) > > > === modified file 'lisp/subr.el' > --- a/lisp/subr.el 2013-01-01 09:11:05 +0000 > +++ b/lisp/subr.el 2013-01-03 00:50:35 +0000 > @@ -1877,7 +1877,7 @@ > ,form))) > ;; Add FORM to the element unless it's already there. > (unless (member form (cdr elt)) > - (nconc elt (purecopy (list form))))))) > + (nconc elt (list form)))))) > > (defvar after-load-functions nil > "Special hook run after loading a file.