From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#13321: 24.3.0.50; Gmail error when replying from Gnus to github Date: Sat, 23 Feb 2013 11:34:50 +0100 Organization: Emacs Helm Message-ID: <878v6f5ned.fsf@gmail.com> References: <87a9surugk.fsf@gmail.com> <87zk0rffsg.fsf@gmail.com> <87mwwqg78u.fsf@gmail.com> <87ip7eg43v.fsf@gmail.com> <87y5g4gp2c.fsf@gmail.com> <87txp5ocvp.fsf@gmail.com> <877gm1r4lv.fsf@gmail.com> <87fw0pihfz.fsf@gmail.com> <877gm0iyzj.fsf@gmail.com> <87621kek7h.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1361616650 23337 80.91.229.3 (23 Feb 2013 10:50:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 Feb 2013 10:50:50 +0000 (UTC) To: 13321@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 23 11:51:12 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U9Ch5-0005b2-Pc for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Feb 2013 11:51:04 +0100 Original-Received: from localhost ([::1]:39332 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9Cgl-000796-AM for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Feb 2013 05:50:43 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9Cgg-00078X-JM for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2013 05:50:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U9Cgd-00018X-IM for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2013 05:50:38 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9Cgd-00018T-Er for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2013 05:50:35 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U9Ci2-0003yc-Dq; Sat, 23 Feb 2013 05:52:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87a9surugk.fsf@gmail.com> Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sat, 23 Feb 2013 10:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13321 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.136161666515206 (code B ref -1); Sat, 23 Feb 2013 10:52:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Feb 2013 10:51:05 +0000 Original-Received: from localhost ([127.0.0.1]:45135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U9Ch6-0003xD-CY for submit@debbugs.gnu.org; Sat, 23 Feb 2013 05:51:04 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58235) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U9Ch2-0003wm-2Q for submit@debbugs.gnu.org; Sat, 23 Feb 2013 05:51:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U9CfW-0000cG-Kq for submit@debbugs.gnu.org; Sat, 23 Feb 2013 05:49:32 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:48524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9CfW-0000cC-IH for submit@debbugs.gnu.org; Sat, 23 Feb 2013 05:49:26 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9CfQ-0006Zj-S7 for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2013 05:49:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U9CfK-0000a4-2q for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2013 05:49:20 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:56551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9CfJ-0000Zv-PP for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2013 05:49:14 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1U9CRu-0004XO-SM for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2013 11:35:22 +0100 Original-Received: from lbe83-2-78-243-104-167.fbx.proxad.net ([78.243.104.167]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 23 Feb 2013 11:35:22 +0100 Original-Received: from thierry.volpiatto by lbe83-2-78-243-104-167.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 23 Feb 2013 11:35:22 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 126 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: lbe83-2-78-243-104-167.fbx.proxad.net User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:ol7Y+fazAp8Zj0Jvbj0eL+jLQYs= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71704 Archived-At: Hi Katsumi, Katsumi Yamaoka writes: > thierry.volpiatto@gmail.com wrote: >> Katsumi Yamaoka writes: >>> Please let me say that a wide reply doesn't contain the author >>> of an original mail in the recipient list is a bug. To exclude >>> an invalid address from a wide reply is not a feature; > >> It is not excluded in the patch, it is added to "cc" only if "wide" is >> specified. > [...] >> Please have a look at the mail examples I sent in other posts. > > Hm, I haven't gotten it yet. Could you try replying to a mail > attached in this message as well (copy it to a mail group and do > F)? > > [...] >> The point is that with the patch I sent + the headers of the rejected >> mail and the original mail where I reply to, you will be able to >> understand what happen and fix it. > > Ok, I'll surely try it. Here the whole patch: diff --git a/lisp/message.el b/lisp/message.el index 21847ac..d92c9ae 100644 --- a/lisp/message.el +++ b/lisp/message.el @@ -6753,8 +6753,7 @@ The function is called with one parameter, a cons cell ..." ;; message-header-synonyms. (setq to (or (message-fetch-field "to") (and (loop for synonym in message-header-synonyms - when (memq 'Original-To synonym) - return t) + thereis (memq 'Original-To synonym)) (message-fetch-field "original-to"))) cc (message-fetch-field "cc") extra (when message-extra-wide-headers @@ -6764,16 +6763,15 @@ The function is called with one parameter, a cons cell ..." ", ")) mct (message-fetch-field "mail-copies-to") author (or (message-fetch-field "mail-reply-to") - (message-fetch-field "reply-to")) + (message-fetch-field "reply-to") + (message-fetch-field "from") "") mft (and message-use-mail-followup-to (message-fetch-field "mail-followup-to"))) ;; Make sure this message goes to the author if this is a wide ;; reply, since Reply-To address may be a list address a mailing ;; list server added. (when (and wide author) - (setq cc (concat author ", " cc))) - (when (or wide (not author)) - (setq author (or (message-fetch-field "from") "")))) + (setq cc (concat author ", " cc)))) ;; Handle special values of Mail-Copies-To. (when mct @@ -6829,13 +6827,9 @@ want to get rid of this query permanently."))) (setq recipients (concat ", " mft))) (t (setq recipients (if never-mct "" (concat ", " author))) - (if to (setq recipients (concat recipients ", " to))) - (if cc (setq recipients (concat recipients ", " cc))) - (if extra (setq recipients (concat recipients ", " extra))) - (if mct (setq recipients (concat recipients ", " mct))))) - (if (>= (length recipients) 2) - ;; Strip the leading ", ". - (setq recipients (substring recipients 2))) + (loop for h in `(,to ,cc ,extra ,mct) + for recip = (and recipients (not (string= recipients ""))) + when h do (setq recipients (concat recipients (and recip ", ") h))))) ;; Squeeze whitespace. (while (string-match "[ \t][ \t]+" recipients) (setq recipients (replace-match " " t t recipients))) @@ -6854,31 +6848,20 @@ want to get rid of this query permanently."))) (cons (downcase (mail-strip-quoted-names addr)) addr)) (cons (downcase (mail-strip-quoted-names addr)) addr))) - (message-tokenize-header recipients))) - ;; Remove all duplicates. - (let ((s recipients)) - (while s - (let ((address (car (pop s)))) - (while (assoc address s) - (setq recipients (delq (assoc address s) recipients) - s (delq (assoc address s) s)))))) + ;; Remove all duplicates. + (loop with recip for mess in (message-tokenize-header recipients) + unless (member mess recip) collect mess into recip + finally return recip))) ;; Remove hierarchical lists that are contained within each other, ;; if message-hierarchical-addresses is defined. (when message-hierarchical-addresses - (let ((plain-addrs (mapcar 'car recipients)) - subaddrs recip) - (while plain-addrs - (setq subaddrs (assoc (car plain-addrs) - message-hierarchical-addresses) - plain-addrs (cdr plain-addrs)) - (when subaddrs - (setq subaddrs (cdr subaddrs)) - (while subaddrs - (setq recip (assoc (car subaddrs) recipients) - subaddrs (cdr subaddrs)) - (if recip - (setq recipients (delq recip recipients)))))))) + (setq recipients + (loop for (r . a) in recipients + for assoc = (cdr (assoc r message-hierarchical-addresses)) + when assoc append assoc into recip + unless (or (member r recip) (assoc r results)) + collect (cons r a) into results finally return results))) (setq recipients (message-prune-recipients recipients)) -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997