From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Aidan Gauland Newsgroups: gmane.emacs.devel Subject: Re: pcase is autoloaded? Date: Sat, 02 Mar 2013 20:36:08 +1300 Message-ID: <878v66nthz.fsf@dimension8.tehua.net> References: <87wqttqsyz.fsf@ferrier.me.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1362209783 13528 80.91.229.3 (2 Mar 2013 07:36:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Mar 2013 07:36:23 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 02 08:36:47 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UBgzv-00016V-0f for ged-emacs-devel@m.gmane.org; Sat, 02 Mar 2013 08:36:47 +0100 Original-Received: from localhost ([::1]:43336 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBgzZ-0006oc-PY for ged-emacs-devel@m.gmane.org; Sat, 02 Mar 2013 02:36:25 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBgzW-0006oM-IP for emacs-devel@gnu.org; Sat, 02 Mar 2013 02:36:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UBgzV-0007fX-GG for emacs-devel@gnu.org; Sat, 02 Mar 2013 02:36:22 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:58181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBgzV-0007fT-9Z for emacs-devel@gnu.org; Sat, 02 Mar 2013 02:36:21 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UBgzm-0000yL-Mz for emacs-devel@gnu.org; Sat, 02 Mar 2013 08:36:38 +0100 Original-Received: from 114-134-7-192.rurallink.co.nz ([114.134.7.192]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 02 Mar 2013 08:36:38 +0100 Original-Received: from aidalgol by 114-134-7-192.rurallink.co.nz with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 02 Mar 2013 08:36:38 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 29 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 114-134-7-192.rurallink.co.nz User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) Cancel-Lock: sha1:+n/lvCtvmIoAgvofr7ezmb6IlNM= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157478 Archived-At: Stefan Monnier writes: >> This means that people leave it to be autoloaded rather than >> specifically required. In our case it broke our test badly because our >> file-system mock was loading pcase.el (which didn't work, surprise!) > > I have no idea what problem you bumped into. I don't know what is your > "file system mock", nor do I know why loading pcase.el didn't work (or > why it should come as (no?) surprise). > >> Is this a good idea? I don't think so. > > Please give more concrete details, Here is the relevant backtrace: https://gist.github.com/aidalgol/5070012 If pcase is not loaded when the test is run, this happens; if pcase *is* loaded when the test is run, this error does not occur. This does seem to suggest that the autoloading of pcase causes a problem, but as Sacha Chua pointed out (on #emacs), `fakir--expand-file-name' does not correctly handle the a nil case, and calls `file-name-as-directory' with nil. (I do not know how that case should be handled.) >From what I can tell, pcase being autoloaded is not the problem, it's just exposing a bug in fakir, and explicitly loading pcase before running the above test only masks the problem. Regards, Aidan Gauland