From: Michael Heerdegen <michael_heerdegen@web.de>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 14926@debbugs.gnu.org
Subject: bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be called at toplevel"
Date: Fri, 16 Aug 2013 13:09:41 +0200 [thread overview]
Message-ID: <878v017uyy.fsf@web.de> (raw)
In-Reply-To: <CAAeL0SRj=oNph6tQaJqnN2ooaL=+jpOPe=h7RoweAAK=-R=rxg@mail.gmail.com> (Juanma Barranquero's message of "Fri, 16 Aug 2013 09:45:18 +0200")
Juanma Barranquero <lekktu@gmail.com> writes:
> FWIW, looking at the change I've had the same reaction as Drew.
Well, it was the best short formulation that came to my mind.
> The message still suggests that using make-variable-buffer-local other
> than at toplevel is erroneous.
>
> It should say something like
>
> Use of make-variable-buffer-local other than at top-level could be
> an error; perhaps you wanted to use make-local-variable?
>
> only shortish and better redacted.
The "shortish" part is the problem. Is it even allowed to use more than
one line? Presumably this kind of warning would not appear to often
when you do things right, so using a longer formulation could be
justified.
Michael.
next prev parent reply other threads:[~2013-08-16 11:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 21:11 bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be called at toplevel" Drew Adams
2013-07-22 2:59 ` Stefan Monnier
2013-07-22 4:31 ` Drew Adams
2013-08-15 14:43 ` Michael Heerdegen
2013-08-15 16:33 ` Stefan Monnier
2013-08-15 18:19 ` Michael Heerdegen
2013-08-16 6:54 ` Glenn Morris
2013-08-16 7:34 ` Drew Adams
2013-08-16 7:45 ` Juanma Barranquero
2013-08-16 11:09 ` Michael Heerdegen [this message]
2013-08-16 14:07 ` Drew Adams
2013-08-16 21:23 ` Michael Heerdegen
2013-08-16 22:14 ` Drew Adams
2013-08-16 16:25 ` Stefan Monnier
2013-08-16 16:31 ` Juanma Barranquero
2013-08-16 17:58 ` Drew Adams
2013-08-16 18:01 ` Glenn Morris
2013-08-16 21:26 ` Michael Heerdegen
2013-08-16 21:40 ` Glenn Morris
2013-08-16 23:02 ` Michael Heerdegen
2014-02-08 5:28 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878v017uyy.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=14926@debbugs.gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.