From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be called at toplevel" Date: Sat, 17 Aug 2013 01:02:36 +0200 Message-ID: <878v012q9f.fsf@web.de> References: <2aaa3bfa-1556-4135-b70a-1308e6cc7cdd@default> <8738qb816m.fsf@web.de> <8stxip5xcz.fsf@fencepost.gnu.org> <87r4dtfhst.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1376694198 26113 80.91.229.3 (16 Aug 2013 23:03:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 16 Aug 2013 23:03:18 +0000 (UTC) Cc: 14926@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 17 01:03:18 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VAT37-0001Ef-Nx for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Aug 2013 01:03:17 +0200 Original-Received: from localhost ([::1]:33427 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAT37-0001t9-B4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2013 19:03:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAT2y-0001cV-ME for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2013 19:03:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VAT2s-0000hn-S3 for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2013 19:03:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAT2s-0000hi-OT for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2013 19:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VAT2s-0001Pg-F1 for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2013 19:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Aug 2013 23:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14926-submit@debbugs.gnu.org id=B14926.13766941705408 (code B ref 14926); Fri, 16 Aug 2013 23:03:02 +0000 Original-Received: (at 14926) by debbugs.gnu.org; 16 Aug 2013 23:02:50 +0000 Original-Received: from localhost ([127.0.0.1]:35427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VAT2g-0001P5-0r for submit@debbugs.gnu.org; Fri, 16 Aug 2013 19:02:50 -0400 Original-Received: from mout.web.de ([212.227.15.4]:51638) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VAT2e-0001Ok-18 for 14926@debbugs.gnu.org; Fri, 16 Aug 2013 19:02:48 -0400 Original-Received: from drachen.dragon ([90.186.51.161]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0MBTIY-1VHZn442sg-00AWXc for <14926@debbugs.gnu.org>; Sat, 17 Aug 2013 01:02:41 +0200 In-Reply-To: (Glenn Morris's message of "Fri, 16 Aug 2013 17:40:35 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Provags-ID: V03:K0:iUPlgRapE/UIkW6dlfv7PzXvGJU6oKkHGbPf3UJES3Kxf52ASSA VyQKBX4kr6TFZhhU+SiNPWXyQwFWaD3uYhIJpWo/WwiQt/oQZVuI5Bo5HkB53DfyMHQ9lwr ywBPin1THBUSQ309mmeXQUrOo1875SQiPNVg+wOoAB/8GfC7m57kC6CaXPy3bUCxD7sYVzb ks8IiS1sU6LBOG4w5RV1w== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:77455 Archived-At: Glenn Morris writes: > This feature is 8 years old, BTW. > > So "Is this something new?" in Jul 2013 tells you something about how > much of an issue this has been in practice. I'll tell you something funny. When Stefan said that 99% of non-top-level uses of `make-variable-buffer-local' were wrong, I searched my large .emacs for counter-examples. I found 4 such places, and for every place, it was by mistake! Of course I knew the difference when I wrote that code, but these function names sound so similar... All these occurrences were wrapped inside something like (add-hook 'hook (lambda () ... (make-variable-buffer-local ...))) or inside `with-eval-after-load' (that also wraps the body inside a lambda) and no warning had been printed all the time. It would be good to warn also for calls inside lambdas. Michael.