* bug#16143: 24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkbox
@ 2013-12-14 12:35 Kenjiro NAKAYAMA
2013-12-14 16:22 ` bug#16143: 24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkboxx Kenjiro NAKAYAMA
0 siblings, 1 reply; 3+ messages in thread
From: Kenjiro NAKAYAMA @ 2013-12-14 12:35 UTC (permalink / raw)
To: 16143
Keybind of the toggle-checkbox with space key is wrong.
I am sorry If I'm wrong. The key bind [space] can not work in my
environment.
Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
* net/eww.el (eww-checkbox-map): fixed wrong key bind to eww-toggle-checkbox
---
lisp/net/eww.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 34c6728..a6447f2 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -563,7 +563,7 @@ appears in a <link> or <a> tag."
(defvar eww-checkbox-map
(let ((map (make-sparse-keymap)))
- (define-key map [space] 'eww-toggle-checkbox)
+ (define-key map " " 'eww-toggle-checkbox)
(define-key map "\r" 'eww-toggle-checkbox)
(define-key map [(control c) (control c)] 'eww-submit)
map))
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#16143: 24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkboxx
2013-12-14 12:35 bug#16143: 24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkbox Kenjiro NAKAYAMA
@ 2013-12-14 16:22 ` Kenjiro NAKAYAMA
2013-12-21 20:50 ` Ted Zlatanov
0 siblings, 1 reply; 3+ messages in thread
From: Kenjiro NAKAYAMA @ 2013-12-14 16:22 UTC (permalink / raw)
To: Kenjiro NAKAYAMA; +Cc: 16143
I resend my patch with a fixed comment.
Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
* net/eww.el (eww-checkbox-map): Fix wrong key bind to eww-toggle-checkbox.
---
lisp/net/eww.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 34c6728..a6447f2 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -563,7 +563,7 @@ appears in a <link> or <a> tag."
(defvar eww-checkbox-map
(let ((map (make-sparse-keymap)))
- (define-key map [space] 'eww-toggle-checkbox)
+ (define-key map " " 'eww-toggle-checkbox)
(define-key map "\r" 'eww-toggle-checkbox)
(define-key map [(control c) (control c)] 'eww-submit)
map))
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#16143: 24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkboxx
2013-12-14 16:22 ` bug#16143: 24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkboxx Kenjiro NAKAYAMA
@ 2013-12-21 20:50 ` Ted Zlatanov
0 siblings, 0 replies; 3+ messages in thread
From: Ted Zlatanov @ 2013-12-21 20:50 UTC (permalink / raw)
To: Kenjiro NAKAYAMA; +Cc: 16143-done
On Sun, 15 Dec 2013 01:22:07 +0900 Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> wrote:
KN> I resend my patch with a fixed comment.
KN> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
KN> * net/eww.el (eww-checkbox-map): Fix wrong key bind to eww-toggle-checkbox.
Applied, thank you.
Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-21 20:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-14 12:35 bug#16143: 24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkbox Kenjiro NAKAYAMA
2013-12-14 16:22 ` bug#16143: 24.3.50; [PATCH] eww: fixed wrong key bind to eww-toggle-checkboxx Kenjiro NAKAYAMA
2013-12-21 20:50 ` Ted Zlatanov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.