From: Ivan Shmakov <ivan@siamics.net>
To: 18198@debbugs.gnu.org
Subject: bug#18198: Gnus fails to read ~/.newsrc with group names which are not symbols
Date: Tue, 05 Aug 2014 10:07:50 +0000 [thread overview]
Message-ID: <878un3ckqx.fsf@violet.siamics.net> (raw)
Package: emacs, gnus
Severity: minor
Tags: patch
As it seems, gnus-newsrc-to-gnus-format fails to correctly
process ~/.newsrc entries with group names not being /complete/
Emacs Lisp expressions (integers, symbols, etc.), as in:
[Hello]/World: 42
[[[This-fails: 1
I believe that the problem is at the following point.
2556 (narrow-to-region
2557 (point)
2558 (progn (skip-chars-forward "^ \t!:\n") (point)))
2559 (goto-char (point-min))
2560 (setq symbol
2561 (and (/= (point-min) (point-max))
2562 (let ((obarray gnus-active-hashtb)) (read buf))))
2563 (widen)
Here, the “group” field of .newsrc is read as an Emacs Lisp
expression. Which may result either in an error, or, in the
case of [Hello]/World – and, similarly, (Hello)/World – in only
the leading [Hello] or (Hello) being actually read.
Instead, I believe that the entire string is to be read and
interned, as in (untested):
(setq symbol
(let ((save (point)))
(skip-chars-forward "^ \t!:\n")
(and (> (point) save)
(intern (buffer-substring-no-properties save (point))
gnus-active-hashtb))))
2582 (symbol
2583 ;; Group names can be just numbers.
2584 (when (numberp symbol)
2585 (setq symbol (intern (int-to-string symbol) gnus-active-hashtb)))
2586 (unless (boundp symbol)
2587 (set symbol nil))
Naturally, the numberp check above will no longer be necessary
after the change suggested.
Please note that this change also prevents the boundp check here
from raising an error should the group name be a valid Emacs
Lisp non-symbol form (say, a vector or a list.)
--
FSF associate member #7257 http://boycottsystemd.org/ … 3013 B6A0 230E 334A
next reply other threads:[~2014-08-05 10:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 10:07 Ivan Shmakov [this message]
2015-02-13 8:43 ` bug#18198: Gnus fails to read ~/.newsrc with group names which are not symbols Lars Ingebrigtsen
2015-02-14 8:05 ` Ivan Shmakov
2015-02-14 10:41 ` Eric Abrahamsen
2015-02-14 10:55 ` Ivan Shmakov
2015-02-14 11:27 ` Eric Abrahamsen
2015-02-15 4:42 ` Lars Ingebrigtsen
2015-02-15 5:52 ` Ivan Shmakov
2017-01-25 18:24 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878un3ckqx.fsf@violet.siamics.net \
--to=ivan@siamics.net \
--cc=18198@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.