* [PATCH] `file-name-base' missing in Emacs < 24.3
@ 2014-08-25 14:53 Nicolas Berthier
2014-10-12 11:55 ` Bastien
2014-12-01 15:53 ` Bastien
0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Berthier @ 2014-08-25 14:53 UTC (permalink / raw
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 205 bytes --]
Hello,
A recent patch introduced a call to `file-name-base' in contributed
"ox-bibtex.el"; however, this function was only introduced in Emacs
version 24.3. The attached patch is a basic fix for that.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-contrib-lisp-ox-bibtex.el-Fixup-for-Emacs-24.3.patch --]
[-- Type: text/x-patch, Size: 1109 bytes --]
From 362e07699a767ea16d99a7f67f6fcb92d1521e0c Mon Sep 17 00:00:00 2001
From: Nicolas Berthier <nberth@member.fsf.org>
Date: Mon, 25 Aug 2014 16:01:20 +0200
Subject: [PATCH] contrib/lisp/ox-bibtex.el: Fixup for Emacs < 24.3
* contrib/lisp/ox-bibtex.el (org-bibtex-process-bib-files): Avoid
using `file-name-base', only available since Emacs version 24.3.
---
contrib/lisp/ox-bibtex.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/lisp/ox-bibtex.el b/contrib/lisp/ox-bibtex.el
index 7cb8972..4016480 100644
--- a/contrib/lisp/ox-bibtex.el
+++ b/contrib/lisp/ox-bibtex.el
@@ -200,7 +200,8 @@ Return new parse tree."
(file-name-sans-extension file) file))
;; Outpufiles of bibtex2html will be put into current working directory
;; so define a variable for this.
- (setq out-file (file-name-base file))
+ (setq out-file (file-name-sans-extension
+ (file-name-nondirectory file)))
;; limit is set: collect citations throughout the document
;; in TEMP-FILE and pass it to "bibtex2html" as "-citefile"
;; argument.
--
2.0.0.rc4
[-- Attachment #3: Type: text/plain, Size: 88 bytes --]
Regards,
--
Nicolas Berthier FSF Member #7975
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] `file-name-base' missing in Emacs < 24.3
2014-08-25 14:53 [PATCH] `file-name-base' missing in Emacs < 24.3 Nicolas Berthier
@ 2014-10-12 11:55 ` Bastien
2014-12-01 15:53 ` Bastien
1 sibling, 0 replies; 3+ messages in thread
From: Bastien @ 2014-10-12 11:55 UTC (permalink / raw
To: Nicolas Berthier; +Cc: emacs-orgmode
Hi Nicolas,
Nicolas Berthier <nberth@member.fsf.org> writes:
> A recent patch introduced a call to `file-name-base' in contributed
> "ox-bibtex.el"; however, this function was only introduced in Emacs
> version 24.3. The attached patch is a basic fix for that.
Can you write a compatibility function named `org-file-name-base'
instead and put it in org-compat.el?
Thanks in advance,
--
Bastien
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] `file-name-base' missing in Emacs < 24.3
2014-08-25 14:53 [PATCH] `file-name-base' missing in Emacs < 24.3 Nicolas Berthier
2014-10-12 11:55 ` Bastien
@ 2014-12-01 15:53 ` Bastien
1 sibling, 0 replies; 3+ messages in thread
From: Bastien @ 2014-12-01 15:53 UTC (permalink / raw
To: Nicolas Berthier; +Cc: emacs-orgmode
Hi Nicolas,
Nicolas Berthier <nberth@member.fsf.org> writes:
> A recent patch introduced a call to `file-name-base' in contributed
> "ox-bibtex.el"; however, this function was only introduced in Emacs
> version 24.3. The attached patch is a basic fix for that.
Applied, thanks, and sorry for the delay.
--
Bastien
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-01 15:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-25 14:53 [PATCH] `file-name-base' missing in Emacs < 24.3 Nicolas Berthier
2014-10-12 11:55 ` Bastien
2014-12-01 15:53 ` Bastien
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.