From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Petton Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate` Date: Tue, 25 Aug 2015 10:32:46 +0200 Message-ID: <878u8zahu9.fsf@petton.fr> References: <20150823191413.17383.23210@vcs.savannah.gnu.org> <87k2skaj5y.fsf@petton.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Trace: ger.gmane.org 1440491600 24940 80.91.229.3 (25 Aug 2015 08:33:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Aug 2015 08:33:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 25 10:33:11 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZU9fA-0002sz-T7 for ged-emacs-devel@m.gmane.org; Tue, 25 Aug 2015 10:33:04 +0200 Original-Received: from localhost ([::1]:58688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZU9f8-0006Ee-T1 for ged-emacs-devel@m.gmane.org; Tue, 25 Aug 2015 04:32:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZU9f3-0006De-Rk for emacs-devel@gnu.org; Tue, 25 Aug 2015 04:32:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZU9ey-0007la-SV for emacs-devel@gnu.org; Tue, 25 Aug 2015 04:32:53 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:33097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZU9ey-0007lM-Mc for emacs-devel@gnu.org; Tue, 25 Aug 2015 04:32:48 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 5CDFD2044B for ; Tue, 25 Aug 2015 04:32:48 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Tue, 25 Aug 2015 04:32:48 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=qh2x4bqoi8gTBg05PARLGkqdFgQ=; b=FVEOK tLy3udd5QTbBS4GM4CSkB2oi4/8q6xfq25Pkw1wob6fQnzmvWJfVCuVNV9bQwTot ceuL+cBtgS0Fxs+O0EF28kpQ+/oxXpzZaW7gOspNIQqZCyA4SneeEUcmFr0Z9r2f /XBc8CvEQWZ/5DMpdRvoLowLCP9ng5CN9Vyf4c= X-Sasl-enc: XUPIZktZbWA6w6W+lXd2iLvk6cGvG4bmck35CJbQX3l5 1440491568 Original-Received: from blueberry (ip-165.net-89-3-149.rev.numericable.fr [89.3.149.165]) by mail.messagingengine.com (Postfix) with ESMTPA id C8861C0001D; Tue, 25 Aug 2015 04:32:47 -0400 (EDT) In-Reply-To: User-Agent: Notmuch/0.19 (http://notmuchmail.org) Emacs/25.0.50.2 (x86_64-unknown-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189145 Archived-At: --=-=-= Content-Type: text/plain Stefan Monnier writes: >>> I don't understand this change. Can't it cause two CL-structs to be >>> vconcat'd together, which wouldn't make much sense? >> The previous version of `seq-concatenate' did not prevent that, since >> CL-structs are vectors, thus sequences, and the function was using >> `sequencep' to determine if the seq had to be converted or not. > > Indeed, but if we intend to work for new "sequence" types defined via > CL-struct, that's still a problem. Yes, it is still a problem. One solution would be to test if the seq is a cl-struct with, in which case we could use `seq-into'. But then that would only fix the cl-struct case, not any other. Nico --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: GPGTools - http://gpgtools.org iQEcBAEBCAAGBQJV3CguAAoJECM1h6R8IHkQ/A8H/jvVTzvD4F8nz4vc1mLy2/e2 Ik7TQ3QUWgRN5WXVpZevAbyHdD4sI9HVcK+WifQBi+aeTun4h622hvWPK7lPSBKY l14IxcnpmnwDHcTq/rCM/oH0iI8dt1tcibvtlGxRAnrDJoqMmvX1QDiEzASHjv+i Pz2OVjoA9MajE9QhMSKadfdINeskRXwKQJmuW6pWgKpvc1E3t75FLNOyuV2ZETwW XlX8ZNfI2NpEJ/LkitoJqboQaDPgFmyu7rn1XKmOIB5ZguhyNtCrufelAbUisLlt ghF+C+K2f4jgdofY++ci+nGbRmB+ItcdMuAWSjiSGF0SpVy1QSZjdBicLcL/oys= =hb/V -----END PGP SIGNATURE----- --=-=-=--